Skip to content

Commit b0689a7

Browse files
Fix: Fixing the logic of the adaptive layer height for supports
Removing `tree_support_adaptive_layer_height` because its logic duplicates `independent_support_layer_height`
1 parent e922411 commit b0689a7

File tree

6 files changed

+5
-13
lines changed

6 files changed

+5
-13
lines changed

src/libslic3r/Preset.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -933,7 +933,7 @@ static std::vector<std::string> s_Preset_print_options {
933933
"set_other_flow_ratios", "first_layer_flow_ratio", "outer_wall_flow_ratio", "inner_wall_flow_ratio", "overhang_flow_ratio", "sparse_infill_flow_ratio", "internal_solid_infill_flow_ratio", "gap_fill_flow_ratio", "support_flow_ratio", "support_interface_flow_ratio",
934934
"role_based_wipe_speed", "wipe_speed", "accel_to_decel_enable", "accel_to_decel_factor", "wipe_on_loops", "wipe_before_external_loop",
935935
"bridge_density","internal_bridge_density", "precise_outer_wall", "bridge_acceleration",
936-
"sparse_infill_acceleration", "internal_solid_infill_acceleration", "tree_support_adaptive_layer_height", "tree_support_auto_brim",
936+
"sparse_infill_acceleration", "internal_solid_infill_acceleration", "tree_support_auto_brim",
937937
"tree_support_brim_width", "gcode_comments", "gcode_label_objects",
938938
"initial_layer_travel_speed", "exclude_object", "slow_down_layers", "infill_anchor", "infill_anchor_max","initial_layer_min_bead_width",
939939
"make_overhang_printable", "make_overhang_printable_angle", "make_overhang_printable_hole_size" ,"notes",

src/libslic3r/PrintConfig.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5761,12 +5761,6 @@ void PrintConfigDef::init_fff_params()
57615761
def->max_literal = 35;
57625762
def->mode = comAdvanced;
57635763
def->set_default_value(new ConfigOptionPercent(30));
5764-
5765-
def = this->add("tree_support_adaptive_layer_height", coBool);
5766-
def->label = L("Adaptive layer height");
5767-
def->category = L("Quality");
5768-
def->tooltip = L("Enabling this option means the height of tree support layer except the first will be automatically calculated.");
5769-
def->set_default_value(new ConfigOptionBool(1));
57705764

57715765
def = this->add("tree_support_auto_brim", coBool);
57725766
def->label = L("Auto brim width");

src/libslic3r/PrintConfig.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -957,7 +957,6 @@ PRINT_CONFIG_CLASS_DEFINE(
957957
((ConfigOptionFloat, tree_support_branch_diameter_angle))
958958
((ConfigOptionFloat, tree_support_angle_slow))
959959
((ConfigOptionInt, tree_support_wall_count))
960-
((ConfigOptionBool, tree_support_adaptive_layer_height))
961960
((ConfigOptionBool, tree_support_auto_brim))
962961
((ConfigOptionFloat, tree_support_brim_width))
963962
((ConfigOptionBool, detect_narrow_internal_solid_infill))

src/libslic3r/PrintObject.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1138,7 +1138,7 @@ bool PrintObject::invalidate_state_by_config_options(
11381138
|| opt_key == "support_object_first_layer_gap"
11391139
|| opt_key == "support_base_pattern_spacing"
11401140
|| opt_key == "support_expansion"
1141-
//|| opt_key == "independent_support_layer_height" // BBS
1141+
|| opt_key == "independent_support_layer_height" // Orca
11421142
|| opt_key == "support_threshold_angle"
11431143
|| opt_key == "support_threshold_overlap"
11441144
|| opt_key == "support_ironing"
@@ -1151,7 +1151,6 @@ bool PrintObject::invalidate_state_by_config_options(
11511151
|| opt_key == "bridge_no_support"
11521152
|| opt_key == "max_bridge_length"
11531153
|| opt_key == "initial_layer_line_width"
1154-
|| opt_key == "tree_support_adaptive_layer_height"
11551154
|| opt_key == "tree_support_auto_brim"
11561155
|| opt_key == "tree_support_brim_width"
11571156
|| opt_key == "tree_support_top_rate"

src/slic3r/GUI/ConfigManipulation.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -816,8 +816,9 @@ void ConfigManipulation::toggle_print_fff_options(DynamicPrintConfig *config, co
816816
for (auto el : {"flush_into_infill", "flush_into_support", "flush_into_objects"})
817817
toggle_field(el, have_prime_tower);
818818

819-
// BBS: MusangKing - Hide "Independent support layer height" option
820-
toggle_line("independent_support_layer_height", have_support_material && !have_prime_tower);
819+
// Orca: This option enables adaptive layer height for supports, but can't be used with the prime tower
820+
int filament_cnt = wxGetApp().preset_bundle->filament_presets.size();
821+
toggle_line("independent_support_layer_height", have_support_material && (!have_prime_tower || filament_cnt == 1));
821822

822823
bool have_avoid_crossing_perimeters = config->opt_bool("reduce_crossing_wall");
823824
toggle_line("max_travel_detour_distance", have_avoid_crossing_perimeters);

src/slic3r/GUI/Tab.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2582,7 +2582,6 @@ void TabPrint::build()
25822582
optgroup->append_single_option_line("tree_support_branch_angle", "support_settings_tree#branch-angle");
25832583
optgroup->append_single_option_line("tree_support_branch_angle_organic", "support_settings_tree#branch-angle");
25842584
optgroup->append_single_option_line("tree_support_angle_slow", "support_settings_tree#preferred-branch-angle");
2585-
optgroup->append_single_option_line("tree_support_adaptive_layer_height", "support_settings_tree");
25862585
optgroup->append_single_option_line("tree_support_auto_brim", "support_settings_tree");
25872586
optgroup->append_single_option_line("tree_support_brim_width", "support_settings_tree");
25882587

0 commit comments

Comments
 (0)