isURL method always returns false

[zilahir]

Describe the bug
A clear and concise description of what the bug is.

The isURL method always returns false, regardless what the input string is. Also ignores the config object.

Examples

function checkIfUrlIsValid(url) {
   isURL(url)
}

checkIfUrlIsValid('www.index.hu') --> false
checkIfUrlIsValid('index.hu') --> false
checkIfUrlIsValid('https://www.index.hu') --> false
checkIfUrlIsValid('google.com') --> false

Additional context
Validator.js version: 13.1.1
Node.js version: node/12.8.1
OS platform: macOS

[ezkemboi]

@zilahir, I tried this on MacOS, node/12.8.1 and validator.js 13.1.1 but it works fine.

var validator = require('validator') 

function checkIfUrlIsValid(url) {
    return validator.isURL(url)
}

console.log(checkIfUrlIsValid('www.index.hu')) // true 
console.log(checkIfUrlIsValid('index.hu')) // true
console.log(checkIfUrlIsValid('https://www.index.hu')) // true
console.log(checkIfUrlIsValid('google.com')) // true

I will need to do more investigations.

[zilahir]

@ezkemboi hmmm interesting. i will create a demo project soon! thanks for the reply.

[adrienv1520]

It should not, google.com, index.hu and www.index.hu are all domain's names not URIs based on RFC-3986.

I was facing the same issues with your module and valid-url so I decided to build a module as reliable as possible strictly based on RFC-3986: https://github.com/adrienv1520/node-uri

You can:

• parse any URI (URNs, URLs, URIs with IDNs support, etc.);
• get the safe Punycode ASCII or Unicode serialization of a domain;
• check an URI, HTTP/HTTPS/Sitemap URL, IP, domain is valid with clear checking errors;
• encode/decode an URI, HTTP/HTTPS/Sitemap URL.

I hope it could help.

[salos1982]

I have the same issue.
isUrl('http://localhost:9200/testFiles/assets/channels/1.jpg') -> false

Code

const validator = require('validator')

if (validator.isURL('http://localhost:9200/testFiles/assets/channels/1.jpg')) {
  console.log('url');
} else {
  console.log('not url')
}

prints 'not url'

[htchaan]

I have the same issue. isUrl('http://localhost:9200/testFiles/assets/channels/1.jpg') -> false

Code

const validator = require('validator')

if (validator.isURL('http://localhost:9200/testFiles/assets/channels/1.jpg')) {
  console.log('url');
} else {
  console.log('not url')
}

prints 'not url'

Because localhost is considered invalid. set require_tld to false to skip domain check.

validator.js/test/validators.js

Line 395 in 4ec30b7

'http://localhost:3000/',

[jtlapp]

There should be some configuration under which http://localhost is valid and http://foobar is not.

[skteiche]

Which options are necessary to allow a simple localhost?

I previously used

if ( !isURL(control.value, { protocols: [], allowUnderscores: true, requireTld: false, // eslint-disable-next-line @typescript-eslint/naming-convention require_host: false }) { return { urlInvalid: true }; }
and this worked in an older version. After update, it returns urlInvalid:true.