Skip to content

Added isTaxID implementation, test cases and updated readme for 'en-IN' #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added isTaxID implementation, test cases and updated readme for 'en-IN' #2032

wants to merge 3 commits into from

Conversation

ajinkyac03
Copy link

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Aug 22, 2022 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (86a07ba) to head (8502d26).
Report is 155 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #2032   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2203      2203           
  Branches       477       477           
=========================================
  Hits          2203      2203

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

braaar
braaar reviewed Aug 22, 2022
View reviewed changes
braaar
braaar reviewed Aug 23, 2022
View reviewed changes
@ajinkyac03
Copy link
Author

@braaar anything more needed from my end?

@braaar
Copy link
Contributor

braaar commented Sep 13, 2022

No, I don't think so. We just have to wait for maintainer review.

@WikiRik WikiRik added the mc-to-land Just merge-conflict standing between the PR and landing. label Mar 28, 2025
@WikiRik
Copy link
Member

WikiRik commented Mar 28, 2025

Please resolve the merge conflicts and then we should be able to merge this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braaar braaar braaar approved these changes

@rubiin rubiin rubiin approved these changes

@WikiRik WikiRik WikiRik approved these changes

Assignees
No one assigned
Labels
mc-to-land Just merge-conflict standing between the PR and landing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a new identity card validator for the Indian PAN card
4 participants
@ajinkyac03 @braaar @WikiRik @rubiin