Merge pull request #25 from siavash119/patch-1

mkmkme · web-flow · commit 898c3c87712f · 2024-11-07T11:49:47.000+02:00
Fix reply map value memory leak
diff --git a/src/reader.c b/src/reader.c
@@ -87,13 +87,13 @@ static void *tryParentize(const valkeyReadTask *task, PyObject *obj) {
                         Py_DECREF(obj);
                         return NULL;
                     }
-                    if (PyDict_SetItem(parent, self->pendingObject, obj) < 0) {
-                        Py_DECREF(obj);
-                        Py_DECREF(self->pendingObject);
-                        self->pendingObject = NULL;
+                    int x = PyDict_SetItem(parent, self->pendingObject, obj);
+                    Py_DECREF(obj);
+                    Py_DECREF(self->pendingObject);
+                    self->pendingObject = NULL;
+                    if (x < 0) {
                         return NULL;
                     }
-                    self->pendingObject = NULL;
                 }
                 break;
             case VALKEY_REPLY_SET:

Original file line number	Diff line number	Diff line change
`@@ -87,13 +87,13 @@ static void tryParentize(const valkeyReadTask task, PyObject *obj) {`
`87`	`87`	`Py_DECREF(obj);`
`88`	`88`	`return NULL;`
`89`	`89`	`}`
`90`		`- if (PyDict_SetItem(parent, self->pendingObject, obj) < 0) {`
`91`		`- Py_DECREF(obj);`
`92`		`- Py_DECREF(self->pendingObject);`
`93`		`- self->pendingObject = NULL;`
	`90`	`+ int x = PyDict_SetItem(parent, self->pendingObject, obj);`
	`91`	`+ Py_DECREF(obj);`
	`92`	`+ Py_DECREF(self->pendingObject);`
	`93`	`+ self->pendingObject = NULL;`
	`94`	`+ if (x < 0) {`
`94`	`95`	`return NULL;`
`95`	`96`	`}`
`96`		`- self->pendingObject = NULL;`
`97`	`97`	`}`
`98`	`98`	`break;`
`99`	`99`	`case VALKEY_REPLY_SET:`