Skip to content

Commit 6d77c8a

Browse files
Fix client performance. (#20)
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
1 parent 8891eda commit 6d77c8a

2 files changed

Lines changed: 1 addition & 22 deletions

File tree

rust/src/lib.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ pub unsafe extern "C-unwind" fn create_client(
136136
let request = unsafe { create_connection_request(config) };
137137
let runtime = Builder::new_multi_thread()
138138
.enable_all()
139+
.worker_threads(10)
139140
.thread_name("GLIDE C# thread")
140141
.build()
141142
.unwrap();

tests/Valkey.Glide.IntegrationTests/TestConfiguration.cs

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -29,22 +29,6 @@ public static ClusterClientConfigurationBuilder DefaultClusterClientConfig() =>
2929
.WithProtocolVersion(ConnectionConfiguration.Protocol.RESP3)
3030
.WithTls(TLS);
3131

32-
public static GlideClient DefaultStandaloneClientWithExtraTimeout()
33-
=> GlideClient.CreateClient(
34-
DefaultClientConfig()
35-
.WithRequestTimeout(TimeSpan.FromSeconds(1))
36-
.Build())
37-
.GetAwaiter()
38-
.GetResult();
39-
40-
public static GlideClusterClient DefaultClusterClientWithExtraTimeout()
41-
=> GlideClusterClient.CreateClient(
42-
DefaultClusterClientConfig()
43-
.WithRequestTimeout(TimeSpan.FromSeconds(1))
44-
.Build())
45-
.GetAwaiter()
46-
.GetResult();
47-
4832
public static GlideClient DefaultStandaloneClient()
4933
=> GlideClient.CreateClient(DefaultClientConfig().Build()).GetAwaiter().GetResult();
5034

@@ -73,14 +57,12 @@ public static TheoryData<GlideClient> TestStandaloneClients
7357
{
7458
GlideClient resp2client = GlideClient.CreateClient(
7559
DefaultClientConfig()
76-
.WithRequestTimeout(TimeSpan.FromSeconds(1))
7760
.WithProtocolVersion(ConnectionConfiguration.Protocol.RESP2)
7861
.Build()
7962
).GetAwaiter().GetResult();
8063
resp2client.SetInfo("RESP2");
8164
GlideClient resp3client = GlideClient.CreateClient(
8265
DefaultClientConfig()
83-
.WithRequestTimeout(TimeSpan.FromSeconds(1))
8466
.WithProtocolVersion(ConnectionConfiguration.Protocol.RESP3)
8567
.Build()
8668
).GetAwaiter().GetResult();
@@ -101,14 +83,12 @@ public static TheoryData<GlideClusterClient> TestClusterClients
10183
{
10284
GlideClusterClient resp2client = GlideClusterClient.CreateClient(
10385
DefaultClusterClientConfig()
104-
.WithRequestTimeout(TimeSpan.FromSeconds(1))
10586
.WithProtocolVersion(ConnectionConfiguration.Protocol.RESP2)
10687
.Build()
10788
).GetAwaiter().GetResult();
10889
resp2client.SetInfo("RESP2");
10990
GlideClusterClient resp3client = GlideClusterClient.CreateClient(
11091
DefaultClusterClientConfig()
111-
.WithRequestTimeout(TimeSpan.FromSeconds(1))
11292
.WithProtocolVersion(ConnectionConfiguration.Protocol.RESP3)
11393
.Build()
11494
).GetAwaiter().GetResult();
@@ -138,7 +118,6 @@ public static ConfigurationOptions DefaultCompatibleConfig()
138118
ConfigurationOptions config = new();
139119
config.EndPoints.Add(STANDALONE_HOSTS[0].host, STANDALONE_HOSTS[0].port);
140120
config.Ssl = TLS;
141-
config.ResponseTimeout = 1000;
142121
return config;
143122
}
144123

@@ -147,7 +126,6 @@ public static ConfigurationOptions DefaultCompatibleClusterConfig()
147126
ConfigurationOptions config = new();
148127
config.EndPoints.Add(CLUSTER_HOSTS[0].host, CLUSTER_HOSTS[0].port);
149128
config.Ssl = TLS;
150-
config.ResponseTimeout = 1000;
151129
return config;
152130
}
153131

0 commit comments

Comments
 (0)