-
Notifications
You must be signed in to change notification settings - Fork 9
Open
Description
Summary
TLS tests are not being executed in CI - they are currently skipped on every CI run.
Description of the Status Quo
The PHP client test suite has TLS test coverage, but these tests are never executed in CI:
- CI runs test without the
--tlsflag. - TLS tests are skipped when
--tlsflag is absent. - Only non-TLS tests run in CI.
Bottom line: TLS functionality is not validated in automated testing
Steps to Reproduce
- Check any CI run in GitHub Actions
- Observe test execution runs without
--tlsflag - Observe TLS tests are skipped in test output
- Verify TLS tests only run when manually executed with
--tlsflag.
Proposed Solution
Update GitHub workflow(s) so that both TLS and non-TLS test run. This could involve a larger refactoring of PHP client test infrastructure. The current approach, which separates TLS and non-TLS tests, does not seem ideal!
Effort & Complexity Estimates
| Estimate | Explanation | |
|---|---|---|
| Effort | Low-Medium | Depends on scope of solution. |
| Complexity | Low-Medium | Same as above |
Related Issues
- TODO
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels