add multiprocess support to sync

Signed-off-by: Lior Sventitzky <[email protected]>

Author: liorsve

python/python/glide/sync/glide_client.py

@@ -1,5 +1,6 @@
 # Copyright Valkey GLIDE Project Contributors - SPDX Identifier: Apache-2.0
 
+import os
 import sys
 from pathlib import Path
 from typing import List, Optional, Union
@@ -48,8 +49,19 @@ def create(cls, config: BaseClientConfiguration) -> Self:
         self._init_ffi()
         self.config = config
         self._is_closed = False
-        conn_req = config._create_a_protobuf_conn_request(
-            cluster_mode=type(config) is GlideClusterClientConfiguration
+
+        os.register_at_fork(after_in_child=self._reset_client_connection)
+
+        self._create_new_core_client()
+
+        return self
+
+    def _reset_client_connection(self):
+        self._create_new_core_client()
+
+    def _create_new_core_client(self):
+        conn_req = self.config._create_a_protobuf_conn_request(
+            cluster_mode=type(self.config) is GlideClusterClientConfiguration
         )
         conn_req_bytes = conn_req.SerializeToString()
         client_type = self.ffi.new(
@@ -82,7 +94,6 @@ def create(cls, config: BaseClientConfiguration) -> Self:
             self.lib.free_connection_response(client_response_ptr)
         else:
             raise ClosingError("Failed to create client, response pointer is NULL.")
-        return self
 
     def _init_ffi(self):
         self.ffi = FFI()

python/tests/sync_tests/test_sync_client.py

@@ -4,6 +4,7 @@
 from __future__ import annotations
 
 import math
+import os
 import threading
 import time
 from datetime import date, datetime, timedelta, timezone
@@ -380,6 +381,26 @@ def connect_to_client():
         # Clean up the main client
         client.close()
 
+    @pytest.mark.parametrize("cluster_mode", [True, False])
+    @pytest.mark.parametrize("protocol", [ProtocolVersion.RESP2, ProtocolVersion.RESP3])
+    def test_sync_fork(self, glide_sync_client: TGlideClient):
+        try:
+            pid = os.fork()
+        except OSError as e:
+            pytest.fail(f"Fork failed: {e}")
+
+        if pid == 0:
+            # Child process
+            glide_sync_client.set("key", "value")
+            assert glide_sync_client.get("key") == "value".encode()
+            os._exit(0)
+        else:
+            # Parent process
+            glide_sync_client.set("key", "value")
+            assert glide_sync_client.get("key") == "value".encode()
+            _, status = os.waitpid(pid, 0)
+            if not os.WIFEXITED(status) or os.WEXITSTATUS(status) != 0:
+                pytest.fail(f"Child process failed with status {status}")
 
 class TestCommands:
     @pytest.mark.smoke_test

python/tests/utils/utils.py

@@ -446,6 +446,7 @@ async def delete_acl_username_and_password(client: TGlideClient, username: str):
             ["ACL", "DELUSER", username], route=AllNodes()
         )
 
+
 def create_client_config(
     request,
     cluster_mode: bool,
@@ -509,6 +510,7 @@ def create_client_config(
         )
     return config
 
+
 def run_sync_func_with_timeout_in_thread(
     func: Callable, timeout: float, on_timeout=None
 ):