Add commands and tests + fix tests that were using asyncio (#3793)

* added sync commands and tests

Signed-off-by: Lior Sventitzky <[email protected]>

* fixes to tests that were using asyncio

Signed-off-by: Lior Sventitzky <[email protected]>

* lint fix

Signed-off-by: Lior Sventitzky <[email protected]>

* fixed client name and version

Signed-off-by: Lior Sventitzky <[email protected]>

* addressed comments

Signed-off-by: Lior Sventitzky <[email protected]>

* addressed final comments

Signed-off-by: Lior Sventitzky <[email protected]>

---------

Signed-off-by: Lior Sventitzky <[email protected]>

Author: liorsve

ffi/.cargo/config.toml

@@ -1,5 +1,5 @@
 [env]
-GLIDE_NAME = { value = "GlideFFI", force = true }
+GLIDE_NAME = "GlideFFI"
 GLIDE_VERSION = "0.1.0"
 # Suppress error
 # > ... was built for newer 'macOS' version (14.5) than being linked (14.0)

python/dev.py

@@ -26,6 +26,8 @@ def find_project_root() -> Path:
 VENV_BIN_DIR = VENV_DIR / "bin"
 PYTHON_EXE = VENV_BIN_DIR / "python"
 FFI_DIR = GLIDE_ROOT / "ffi"
+GLIDE_SYNC_NAME = "GlidePySync"
+GLIDE_ASYNC_NAME = "GlidePy"
 
 
 def check_dependencies() -> None:
@@ -129,26 +131,48 @@ def generate_protobuf_files() -> None:
     print(f"[OK] Protobuf files (.py + .pyi) generated at: {proto_dst}")
 
 
-def build_async_client(release: bool, no_cache: bool = False) -> None:
+def build_async_client(
+    glide_version: str, release: bool, no_cache: bool = False
+) -> None:
     print(
-        f"[INFO] Building async client in {'release' if release else 'debug'} mode..."
+        f"[INFO] Building async client with version={glide_version} in {'release' if release else 'debug'} mode..."
     )
     env = activate_venv(no_cache)
+    env.update(
+        {  # Update it with your GLIDE variables
+            "GLIDE_NAME": GLIDE_ASYNC_NAME,
+            "GLIDE_VERSION": glide_version,
+        }
+    )
     generate_protobuf_files()
 
     cmd = [str(PYTHON_EXE), "-m", "maturin", "develop"]
     if release:
         cmd += ["--release", "--strip"]
 
-    run_command(cmd, cwd=PYTHON_DIR, env=env, label="maturin develop")
+    run_command(
+        cmd,
+        cwd=PYTHON_DIR,
+        env=env,
+        label="maturin develop",
+    )
     print("[OK] Async client build completed")
 
 
-def build_sync_client() -> None:
-    print("[INFO] Building sync client...")
+def build_sync_client(glide_version: str) -> None:
+    print(f"[INFO] Building sync client with version={glide_version}...")
     generate_protobuf_files()
 
-    run_command(["cargo", "build"], cwd=FFI_DIR, label="cargo build ffi")
+    run_command(
+        ["cargo", "build"],
+        cwd=FFI_DIR,
+        label="cargo build ffi",
+        env={
+            "GLIDE_NAME": GLIDE_SYNC_NAME,
+            "GLIDE_VERSION": glide_version,
+            **os.environ,
+        },
+    )
 
     print("[OK] Sync client build completed")
 
@@ -255,6 +279,12 @@ def main() -> None:
         action="store_true",
         help="Install Python dependencies without cache",
     )
+    build_parser.add_argument(
+        "--glide-version",
+        type=str,
+        default="unknown",
+        help="Specify the client version that will be used for server identification and displayed in CLIENT INFO output",
+    )
 
     subparsers.add_parser(
         "protobuf", help="Generate Python protobuf files including .pyi stubs"
@@ -295,10 +325,10 @@ def main() -> None:
         no_cache = args.no_cache
         if args.client in ["async", "all"]:
             print(f"🛠 Building async client ({args.mode} mode)...")
-            build_async_client(release, no_cache)
+            build_async_client(args.glide_version, release, no_cache)
         if args.client in ["sync", "all"]:
             print("🛠 Building sync client...")
-            build_sync_client()
+            build_sync_client(glide_version=args.glide_version)
 
     print("[✅ DONE] Task completed successfully.")