addressed comments

Signed-off-by: Lior Sventitzky <[email protected]>

Author: liorsve

python/python/glide/sync/glide_client.py

@@ -51,16 +51,13 @@ def create(cls, config: BaseClientConfiguration) -> Self:
         self.config = config
         self._is_closed = False
 
-        os.register_at_fork(after_in_child=self._reset_client_connection)
+        os.register_at_fork(after_in_child=self._create_core_client)
 
-        self._create_new_core_client()
+        self._create_core_client()
 
         return self
 
-    def _reset_client_connection(self):
-        self._create_new_core_client()
-
-    def _create_new_core_client(self):
+    def _create_core_client(self):
         conn_req = self.config._create_a_protobuf_conn_request(
             cluster_mode=type(self.config) is GlideClusterClientConfiguration
         )

python/tests/sync_tests/test_sync_client.py

@@ -384,12 +384,14 @@ def connect_to_client():
     @pytest.mark.parametrize("cluster_mode", [True, False])
     @pytest.mark.parametrize("protocol", [ProtocolVersion.RESP2, ProtocolVersion.RESP3])
     def test_sync_fork(self, glide_sync_client: TGlideClient):
+        parent_pid = os.getpid()
         try:
             pid = os.fork()
         except OSError as e:
             pytest.fail(f"Fork failed: {e}")
 
-        if pid == 0:
+        current_pid = os.getpid()
+        if current_pid != parent_pid:
             # Child process
             glide_sync_client.set("key", "value")
             assert glide_sync_client.get("key") == "value".encode()