Skip to content

[OPTIMIZATION] Don't parse search/creation parameters into Protobufs #1100

@mnunberg1

Description

@mnunberg1

What operations aren't optimal?

Protobufs is for network transport... it seems odd and counter-intuitive to be using them for internal application usage. Even if these parameters eventually become serialized to the network, it's worth the extra lines of code to do this. We're speaking about Valkeg entry points, so I highly doubt performance is a big concern, after parsing the command and doing all sorts of other sanity checks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    optimizationNo functionality change, just faster and/or smaller.

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions