Merge pull request #2303 from valory-xyz/chore/continue-on-error

Remove `continue-on-error` so the default applies

Author: Adamantios

.github/workflows/main_workflow.yml

@@ -12,7 +12,6 @@ env:
 
 jobs:
   lock_check:
-    continue-on-error: False
     runs-on: ${{ matrix.os }}
 
     strategy:
@@ -46,7 +45,6 @@ jobs:
         ptime pipenv lock
 
   install_check:
-    continue-on-error: False
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
@@ -64,7 +62,6 @@ jobs:
         autonomy --help
 
   copyright_doc_and_dependencies_check:
-    continue-on-error: False
     runs-on: ${{ matrix.os }}
 
     strategy:
@@ -102,7 +99,6 @@ jobs:
       run: tox -e check-dependencies
 
   linter_checks:
-    continue-on-error: False
     runs-on: ${{ matrix.os }}
 
     strategy:
@@ -186,7 +182,6 @@ jobs:
           gitleaks detect --report-format json --report-path leak_report -v
 
   test:
-    continue-on-error: True
     needs:
       - lock_check
       - install_check
@@ -195,6 +190,7 @@ jobs:
     runs-on: ${{ matrix.os }}
 
     strategy:
+      fail-fast: false  # prevents all matrix jobs from canceling if one fails
       matrix:
         os: [ ubuntu-latest, macos-latest-large, windows-latest ]
         python-version: [ "3.8", "3.9", "3.10.9", "3.11" ]
@@ -381,7 +377,6 @@ jobs:
           fail_ci_if_error: false
 
   e2e:
-    continue-on-error: True
     needs:
       - lock_check
       - install_check

.github/workflows/release.yml

@@ -135,7 +135,7 @@ jobs:
 
   publish-user-images:
     name: Publish User Images
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     needs:
       - publish-autonomy-packages
     steps:

HISTORY.md

@@ -1,14 +1,32 @@
 # Release History - `open-autonomy`
 
+
+# 0.19.4 (2025-02-18)
+
+Autonomy:
+- Fixes infinite loop in dev mode #2304
+- Fixes autonomy deploy build command #2305
+- Fixes the regressed CLI tests #2306
+
+Packages:
+- Fixes typo in `gas_pricing` #2308
+- Fixes the regressed packages' tests #2310
+
+CI:
+- Removes `continue-on-error` so the default applies #2303
+
 # 0.19.3 (2025-02-13)
+
 Chores:
 - Bumps `open-aea@1.64.0` #2307
 
 # 0.19.2 (2025-02-05)
+
 Packages:
 - Fixes char encodings for Windows #2300
 
 # 0.19.1 (2025-02-04)
+
 Autonomy:
 - Temporarily works around an issue with the path directory when using the build command #2292
 

autonomy/__version__.py

@@ -22,7 +22,7 @@
 __title__ = "open-autonomy"
 __description__ = "A framework for the creation of autonomous agent services."
 __url__ = "https://github.com/valory-xyz/open-autonomy.git"
-__version__ = "0.19.3"
+__version__ = "0.19.4"
 __author__ = "Valory AG"
 __license__ = "Apache-2.0"
 __copyright__ = "2021-2024 Valory AG"

autonomy/cli/deploy.py

@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-
 # ------------------------------------------------------------------------------
 #
-#   Copyright 2022-2024 Valory AG
+#   Copyright 2022-2025 Valory AG
 #
 #   Licensed under the Apache License, Version 2.0 (the "License");
 #   you may not use this file except in compliance with the License.
@@ -21,6 +21,7 @@
 
 import os
 import shutil
+from itertools import chain
 from pathlib import Path
 from typing import List, Optional, cast
 
@@ -33,7 +34,8 @@
     reraise_as_click_exception,
 )
 from aea.cli.utils.context import Context
-from aea.configurations.constants import DEFAULT_ENV_DOTFILE
+from aea.configurations.constants import DEFAULT_ENV_DOTFILE, PACKAGES
+from aea.package_manager.base import PACKAGES_FILE
 
 from autonomy.chain.config import ChainType
 from autonomy.cli.helpers.deployment import (
@@ -65,14 +67,13 @@
 
 
 def _validate_packages_path(path: Optional[Path] = None) -> Path:
-    """Find packages dir for development mode."""
-    path = Path(path or Path.cwd()).resolve()
-    while path != path.root:
-        if path.name == "packages" and (path / "packages.json").exists():
-            return path
-        path = path.parent
+    """Find the 'packages' directory for development mode by traversing up the path."""
+    path = (path or Path.cwd()).resolve()
+    for current_path in chain({path}, path.parents):
+        if current_path.name == PACKAGES and (current_path / PACKAGES_FILE).is_file():
+            return current_path
     raise click.ClickException(
-        "Please provide path to packages directory for development mode"
+        "Please provide a valid path to the `packages` directory for development mode."
     )
 
 

autonomy/cli/helpers/deployment.py

@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-
 # ------------------------------------------------------------------------------
 #
-#   Copyright 2022-2024 Valory AG
+#   Copyright 2022-2025 Valory AG
 #
 #   Licensed under the Apache License, Version 2.0 (the "License");
 #   you may not use this file except in compliance with the License.
@@ -66,10 +66,10 @@
 from autonomy.deploy.image import build_image
 
 
-def _build_dirs(build_dir: Path, mkdir: List[str]) -> None:
-    """Build necessary directories."""
+def _build_dirs(build_dir: Path, mkdir: Optional[List[str]] = None) -> None:
+    """Build the necessary directories."""
 
-    mkdirs = [(new_dir_name,) for new_dir_name in mkdir]
+    mkdirs = [(new_dir_name,) for new_dir_name in mkdir] if mkdir else []
 
     for dir_path in [
         (PERSISTENT_DATA_DIR,),
@@ -282,6 +282,7 @@ def build_deployment(  # pylint: disable=too-many-arguments, too-many-locals
     build_dir.mkdir()
     if service_hash_id is None:
         service_hash_id = build_hash_id()
+    _build_dirs(build_dir, mkdir)
 
     report = generate_deployment(
         service_hash_id=service_hash_id,
@@ -306,8 +307,6 @@ def build_deployment(  # pylint: disable=too-many-arguments, too-many-locals
         image_author=image_author,
         resources=resources,
     )
-    if mkdir is not None:
-        _build_dirs(build_dir, mkdir)
 
     click.echo(report)
 

autonomy/constants.py

@@ -65,5 +65,5 @@
 ACN_IMAGE_NAME = os.environ.get("ACN_IMAGE_NAME", "valory/open-acn-node")
 DEFAULT_DOCKER_IMAGE_AUTHOR = "valory"
 OAR_IMAGE = "{image_author}/oar-{agent}:{version}"
-ABSTRACT_ROUND_ABCI_SKILL_WITH_HASH = "valory/abstract_round_abci:0.1.0:bafybeigyuls35k6rc2x5j5pcnrghfyojzqzjshhfoaco47ctfm3wjiapce"
+ABSTRACT_ROUND_ABCI_SKILL_WITH_HASH = "valory/abstract_round_abci:0.1.0:bafybeia27qmw6w5ds5fcrpj2475brnz742aampe3sgochloijs2l7jovai"
 OLAS_DOCS_URL = "https://docs.autonolas.network"

autonomy/deploy/base.py

@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-
 # ------------------------------------------------------------------------------
 #
-#   Copyright 2021-2024 Valory AG
+#   Copyright 2021-2025 Valory AG
 #
 #   Licensed under the Apache License, Version 2.0 (the "License");
 #   you may not use this file except in compliance with the License.
@@ -99,6 +99,7 @@
 DEFAULT_AGENT_CPU_LIMIT = float(os.environ.get("AUTONOMY_AGENT_CPU_LIMIT", 1.0))
 DEFAULT_AGENT_MEMORY_REQUEST = int(os.environ.get("AUTONOMY_AGENT_MEMORY_REQUEST", 256))
 DEFAULT_AGENT_CPU_REQUEST = float(os.environ.get("AUTONOMY_AGENT_CPU_REQUEST", 1.0))
+AUTONOMY_PKEY_PASSWORD = "OPEN_AUTONOMY_PRIVATE_KEY_PASSWORD"  # nosec
 
 
 def tm_write_to_log() -> bool:
@@ -729,9 +730,7 @@ def generate_common_vars(self, agent_n: int) -> Dict:
             ENV_VAR_ID: agent_n,
             ENV_VAR_AEA_AGENT: self.service.agent,
             ENV_VAR_LOG_LEVEL: self.log_level,
-            ENV_VAR_AEA_PASSWORD: os.environ.get(
-                "OPEN_AUTONOMY_PRIVATE_KEY_PASSWORD", ""
-            ),
+            ENV_VAR_AEA_PASSWORD: os.environ.get(AUTONOMY_PKEY_PASSWORD, ""),
         }
         return agent_vars
 

autonomy/deploy/generators/docker_compose/base.py

@@ -22,6 +22,7 @@
 import ipaddress
 import os
 from pathlib import Path
+from string import Template
 from typing import Dict, List, Optional, Set, cast
 
 import yaml
@@ -77,6 +78,7 @@
 
 DEFAULT_PACKAGES_PATH = Path.cwd().absolute() / "packages"
 DEFAULT_OPEN_AEA_DIR: Path = Path.home().absolute() / "open-aea"
+AGENT_ENV_TEMPLATE = Template("agent_${node_id}.env")
 
 
 def get_docker_client() -> DockerClient:
@@ -136,7 +138,7 @@ def to_env_file(agent_vars: Dict, node_id: int, build_dir: Path) -> None:
     """Create a env file under the `agent_build` folder."""
     agent_vars["PYTHONHASHSEED"] = 0
     agent_vars["LOG_FILE"] = f"/logs/aea_{node_id}.txt"
-    env_file_path = build_dir / f"agent_{node_id}.env"
+    env_file_path = build_dir / AGENT_ENV_TEMPLATE.substitute(node_id=node_id)
     with open(env_file_path, "w", encoding=DEFAULT_ENCODING) as env_file:
         for key, value in agent_vars.items():
             env_file.write(f"{key}={value}\n")
@@ -444,7 +446,7 @@ def _populate_keys(self) -> None:
             )
             key = cast(List[Dict[str, str]], self.service_builder.keys)[x][PRIVATE_KEY]
             keys_file = path / PRIVATE_KEY_PATH_SCHEMA.format(ledger)
-            path.mkdir(parents=True)
+            path.mkdir()
             with keys_file.open(mode="w", encoding=DEFAULT_ENCODING) as f:
                 f.write(key)
 

deployments/Dockerfiles/autonomy-user/requirements.txt

@@ -1,4 +1,4 @@
-open-autonomy[all]==0.19.3
+open-autonomy[all]==0.19.4
 open-aea[all]==1.64.0
 open-aea-cli-ipfs==1.64.0
 open-aea-ledger-ethereum==1.64.0