Skip to content

Commit 5461b09

Browse files
fo2ristvanniktech
authored andcommitted
Fix slow file traversal in configuration phase (#163)
Replace .files with .getFrom() for ConfigurableFileCollection objectsFiles list all folder content that could be extermely slow for the second build
1 parent 9607c93 commit 5461b09

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/main/groovy/com/vanniktech/android/junit/jacoco/GenerationPlugin.groovy

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,9 @@ class GenerationPlugin implements Plugin<Project> {
8989
mergeTask.executionData.setFrom(executionData.files + mergeTask.executionData.files)
9090
}
9191
if (mergedReportTask != null) {
92-
mergedReportTask.classDirectories.setFrom(classDirectories.files + mergedReportTask.classDirectories.files)
93-
mergedReportTask.additionalSourceDirs.setFrom(additionalSourceDirs.files + mergedReportTask.additionalSourceDirs.files)
94-
mergedReportTask.sourceDirectories.setFrom(sourceDirectories.files + mergedReportTask.sourceDirectories.files)
92+
mergedReportTask.classDirectories.setFrom(classDirectories.getFrom() + mergedReportTask.classDirectories.getFrom())
93+
mergedReportTask.additionalSourceDirs.setFrom(additionalSourceDirs.getFrom() + mergedReportTask.additionalSourceDirs.getFrom())
94+
mergedReportTask.sourceDirectories.setFrom(sourceDirectories.getFrom() + mergedReportTask.sourceDirectories.getFrom())
9595
}
9696
}
9797

@@ -248,9 +248,9 @@ class GenerationPlugin implements Plugin<Project> {
248248
mergeTask.executionData.setFrom(executionData.files + mergeTask.executionData.files)
249249
}
250250
if (mergedReportTask != null && addToMergeTask) {
251-
mergedReportTask.classDirectories.setFrom(classDirectories.files + mergedReportTask.classDirectories.files)
252-
mergedReportTask.additionalSourceDirs.setFrom(additionalSourceDirs.files + mergedReportTask.additionalSourceDirs.files)
253-
mergedReportTask.sourceDirectories.setFrom(sourceDirectories.files + mergedReportTask.sourceDirectories.files)
251+
mergedReportTask.classDirectories.setFrom(classDirectories.getFrom() + mergedReportTask.classDirectories.getFrom())
252+
mergedReportTask.additionalSourceDirs.setFrom(additionalSourceDirs.getFrom() + mergedReportTask.additionalSourceDirs.getFrom())
253+
mergedReportTask.sourceDirectories.setFrom(sourceDirectories.getFrom() + mergedReportTask.sourceDirectories.getFrom())
254254
}
255255
}
256256

0 commit comments

Comments
 (0)