Skip to content

Commit 03e4c6f

Browse files
authored
Fix oppia#15986: Animate loading dots while response is loading (oppia#24489)
* Fix animation of loading dots while response is loading * Fix CSS lint errors for loading dots animation * Fix CSS formatting for loading dots * Fix CSS property order for animation delay * Fix animation-delay property order for loading dots * Fix: added removed class * fix * Fix: align div attributes to satisfy HTML lint
1 parent e52ab33 commit 03e4c6f

File tree

2 files changed

+21
-15
lines changed

2 files changed

+21
-15
lines changed

core/templates/pages/exploration-player-page/current-lesson-player/learner-experience/input-response-pair.component.css

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -68,16 +68,19 @@ oppia-input-response-pair .oppia-popover {
6868
max-width: 300px;
6969
}
7070

71-
oppia-input-response-pair .conversation-skin-feedback-dot-one,
72-
oppia-input-response-pair .conversation-skin-feedback-dot-two,
73-
oppia-input-response-pair .conversation-skin-feedback-dot-three {
71+
oppia-input-response-pair .oppia-loading-dot-one,
72+
oppia-input-response-pair .oppia-loading-dot-two,
73+
oppia-input-response-pair .oppia-loading-dot-three {
7474
background-color: #666;
75+
border-radius: 50%;
7576
display: inline-block;
76-
height: 2px;
77-
width: 2px;
77+
font-size: 0;
78+
height: 5px;
79+
margin-right: 4px;
80+
width: 5px;
7881
}
7982

80-
oppia-input-response-pair .conversation-skin-feedback-dot-one {
83+
oppia-input-response-pair .oppia-loading-dot-one {
8184
-webkit-animation: dot 1.0s infinite;
8285
-moz-animation: dot 1.0s infinite;
8386
animation: dot 1.0s infinite;
@@ -87,7 +90,7 @@ oppia-input-response-pair .conversation-skin-feedback-dot-one {
8790
opacity: 0;
8891
}
8992

90-
oppia-input-response-pair .conversation-skin-feedback-dot-two {
93+
oppia-input-response-pair .oppia-loading-dot-two {
9194
-webkit-animation: dot 1.0s infinite;
9295
-moz-animation: dot 1.0s infinite;
9396
animation: dot 1.0s infinite;
@@ -97,13 +100,14 @@ oppia-input-response-pair .conversation-skin-feedback-dot-two {
97100
opacity: 0;
98101
}
99102

100-
oppia-input-response-pair .conversation-skin-feedback-dot-three {
101-
-webkit-animation: dot 1.0s infinite;
103+
oppia-input-response-pair .oppia-loading-dot-three {
102104
-moz-animation: dot 1.0s infinite;
105+
-webkit-animation: dot 1.0s infinite;
103106
animation: dot 1.0s infinite;
104-
-webkit-animation-delay: 0.4s;
105107
-moz-animation-delay: 0.4s;
108+
-webkit-animation-delay: 0.4s;
106109
animation-delay: 0.4s;
110+
margin-right: 0;
107111
opacity: 0;
108112
}
109113

core/templates/pages/exploration-player-page/current-lesson-player/learner-experience/input-response-pair.component.html

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,15 +36,17 @@
3636
</div>
3737
</div>
3838

39-
<div class="conversation-skin-oppia-feedback-container" *ngIf="data.oppiaResponse !== '' && feedbackIsEnabled">
39+
<div class="conversation-skin-oppia-feedback-container"
40+
*ngIf="data.oppiaResponse !== '' && feedbackIsEnabled">
4041
<img class="conversation-skin-oppia-avatar rounded-circle"
4142
[src]="oppiaAvatarImageUrl"
4243
alt="">
4344
<div *ngIf="!data.oppiaResponse && isCurrentCardAtEndOfTranscript()"
44-
class="e2e-test-input-response-loading-dots">
45-
<div class="conversation-skin-feedback-dot-one"></div>
46-
<div class="conversation-skin-feedback-dot-two"></div>
47-
<div class="conversation-skin-feedback-dot-three"></div>
45+
class="e2e-test-input-response-loading-dots"
46+
dir="auto">
47+
<div class="oppia-rte-viewer conversation-skin-oppia-feedback-content">
48+
<loading-dots></loading-dots>
49+
</div>
4850
</div>
4951
<span id="getInputResponsePairId()"></span>
5052
<div dir="auto">

0 commit comments

Comments
 (0)