Skip to content

Commit e0c8bb6

Browse files
committed
nio updates, fix #96
1 parent 58ef649 commit e0c8bb6

File tree

4 files changed

+31
-10
lines changed

4 files changed

+31
-10
lines changed

Package.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@ let package = Package(
88
],
99
dependencies: [
1010
// 🌎 Utility package containing tools for byte manipulation, Codable, OS APIs, and debugging.
11-
.package(url: "https://github.com/vapor/core.git", .branch("nio")),
11+
.package(url: "https://github.com/vapor/core.git", from: "3.0.0-rc.2"),
1212

1313
// 📦 Dependency injection / inversion of control framework.
14-
.package(url: "https://github.com/vapor/service.git", .branch("nio")),
14+
.package(url: "https://github.com/vapor/service.git", from: "1.0.0-rc.2"),
1515

1616
// 📄 Easy-to-use foundation for building powerful templating languages in Swift.
17-
.package(url: "https://github.com/vapor/template-kit.git", .branch("nio")),
17+
.package(url: "https://github.com/vapor/template-kit.git", from: "1.0.0-rc.2"),
1818
],
1919
targets: [
2020
.target(name: "Leaf", dependencies: ["Async", "Bits", "CodableKit", "COperatingSystem", "Service", "TemplateKit"]),

Sources/Leaf/Service/LeafProvider.swift

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,17 @@ public final class LeafProvider: Provider {
1313
/// See Service.Provider.Register
1414
public func register(_ services: inout Services) throws {
1515
services.register(TemplateRenderer.self) { container -> LeafRenderer in
16-
let config = try container.make(LeafConfig.self, for: LeafRenderer.self)
16+
let config = try container.make(LeafConfig.self)
1717
return LeafRenderer(
1818
config: config,
1919
using: container
2020
)
2121
}
2222

2323
services.register { container -> LeafConfig in
24-
let dir = try container.make(DirectoryConfig.self, for: LeafRenderer.self)
24+
let dir = try container.make(DirectoryConfig.self)
2525
return try LeafConfig(
26-
tags: container.make(for: LeafConfig.self),
26+
tags: container.make(),
2727
viewsDir: dir.workDir + "Resources/Views",
2828
shouldCache: container.environment != .development
2929
)
@@ -35,5 +35,7 @@ public final class LeafProvider: Provider {
3535
}
3636

3737
/// See Service.Provider.boot
38-
public func boot(_ container: Container) throws { }
38+
public func didBoot(_ container: Container) throws -> Future<Void> {
39+
return .done(on: container)
40+
}
3941
}

Tests/LeafTests/LeafTests.swift

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -396,6 +396,26 @@ class LeafTests: XCTestCase {
396396
try XCTAssertEqual(renderer.testRender(home, data), expected)
397397
}
398398

399+
func testGH96() throws {
400+
let template = """
401+
#for(name in names) {
402+
#(name): index=#(index) last=#(isLast) first=#(isFirst)
403+
#if(!isLast) {
404+
405+
}
406+
}
407+
"""
408+
let expected = """
409+
tanner: index=0 last=false first=true
410+
ziz: index=1 last=false first=false
411+
vapor: index=2 last=true first=false
412+
"""
413+
let data = try TemplateDataEncoder().encode([
414+
"names": ["tanner", "ziz", "vapor"]
415+
])
416+
try XCTAssertEqual(renderer.testRender(template, data), expected)
417+
}
418+
399419
static var allTests = [
400420
("testPrint", testPrint),
401421
("testConstant", testConstant),
@@ -424,6 +444,7 @@ class LeafTests: XCTestCase {
424444
("testKeyEqual", testKeyEqual),
425445
("testInvalidForSyntax", testInvalidForSyntax),
426446
("testTemplating", testTemplating),
447+
("testGH96", testGH96),
427448
]
428449
}
429450

circle.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,9 @@ jobs:
1111

1212
linux:
1313
docker:
14-
- image: norionomura/swift:swift-4.1-branch
14+
- image: codevapor/swift:4.1
1515
steps:
1616
- checkout
17-
- run: apt-get update
18-
- run: apt-get install -yq libssl-dev
1917
- run: swift build
2018
- run: swift test
2119
- run: swift build -c release

0 commit comments

Comments
 (0)