Fully clear up NIO and get the tests passing

Author: 0xTim

Package.swift

@@ -16,7 +16,6 @@ let package = Package(
     dependencies: [
         .package(url: "https://github.com/apple/swift-collections.git", from: "1.1.0"),
         .package(url: "https://github.com/apple/swift-log.git", from: "1.5.4"),
-        .package(url: "https://github.com/apple/swift-nio.git", from: "2.84.0"),
     ],
     targets: [
         .target(
@@ -37,8 +36,6 @@ let package = Package(
         .testTarget(
             name: "SQLKitTests",
             dependencies: [
-                .product(name: "NIOCore", package: "swift-nio"),
-                .product(name: "NIOEmbedded", package: "swift-nio"),
                 .target(name: "SQLKit"),
                 .target(name: "SQLKitBenchmark"),
             ],

Tests/SQLKitTests/BaseTests.swift

@@ -1,7 +1,5 @@
 @testable import SQLKit
 import struct Logging.Logger
-import protocol NIOCore.EventLoop
-import class NIOCore.EventLoopFuture
 import SQLKitBenchmark
 import Testing
 
@@ -171,11 +169,6 @@ struct BaseTests {
         #expect(db.queryLogLevel == db.queryLogLevel)
         await #expect(throws: Never.self) { try await db.execute(sql: SQLRaw("TEST"), { _ in }) }
     }
-    
-    @Test("database default async impl")
-    func databaseDefaultAsyncImpl() async throws {
-        await #expect(throws: Never.self) { try await TestNoAsyncDatabase().execute(sql: SQLRaw("TEST"), { _ in }) }
-    }
 
     @Test("database version")
     func databaseVersion() {

Tests/SQLKitTests/TestMocks.swift

@@ -1,12 +1,6 @@
 import OrderedCollections
 public import SQLKit
-import protocol NIOCore.EventLoop
-import class NIOCore.EventLoopFuture
-import class NIOEmbedded.NIOAsyncTestingEventLoop
 import Logging
-#if canImport(Dispatch)
-import class Dispatch.DispatchQueue
-#endif
 
 extension SQLQueryBuilder {
     /// Serialize this builder's query and return the textual SQL, discarding any bindings.
@@ -28,23 +22,11 @@ extension SQLQueryBuilder {
 /// its internal arrays of accumulated "results". Most things about its dialect are mutable.
 final class TestDatabase: SQLDatabase, @unchecked Sendable {
     let logger: Logger = { var l = Logger(label: "codes.vapor.sql.test"); l.logLevel = .debug; return l }()
-    let eventLoop: any EventLoop = NIOAsyncTestingEventLoop()
     var results: [String] = []
     var bindResults: [[any Encodable & Sendable]] = []
     var outputs: [any SQLRow] = []
     var dialect: any SQLDialect { self._dialect }
     var _dialect: GenericDialect = .init()
-    
-    func execute(sql query: any SQLExpression, _ onRow: @escaping (any SQLRow) -> ()) -> EventLoopFuture<Void> {
-        let (sql, binds) = self.serialize(query)
-
-        self.results.append(sql)
-        self.bindResults.append(binds)
-        while let row = self.outputs.popLast() {
-            onRow(row)
-        }
-        return self.eventLoop.makeSucceededFuture(())
-    }
 
     func execute(sql query: any SQLExpression, _ onRow: @escaping (any SQLRow) -> ()) async throws {
         let (sql, binds) = self.serialize(query)
@@ -145,11 +127,3 @@ extension SQLKit.SQLDataType: Swift.Equatable {
         }
     }
 }
-
-/// Used when testing defaulted async implementations
-struct TestNoAsyncDatabase: SQLDatabase {
-    func execute(sql query: any SQLExpression, _ onRow: @escaping @Sendable (any SQLRow) -> ()) -> EventLoopFuture<Void> { self.eventLoop.makeSucceededVoidFuture() }
-    var logger: Logger { .init(label: "l") }
-    var eventLoop: any EventLoop { NIOAsyncTestingEventLoop() }
-    var dialect: any SQLDialect { GenericDialect() }
-}