EACDemuxer.cs: error checking and compatibility improvements

 * add error checking for eac3to
 * manually specify the location of eac3to logs to ensure compatibility with the log generation behavior of eac3to versions >= v3.49
 * now the eac3to logs will still be placed in the temporary working directory, sharing the same name as the input file and ending with the .eac3to.log suffix

Author: sinsanction

OKEGui/OKEGui/JobProcessor/Demuxer/EACDemuxer.cs

@@ -104,19 +104,33 @@ public EACDemuxer(string eacPath, string fileName, TaskProfile jobProfile)
             Logger.Debug($"SkipAllAudioTracks: {jobProfile.SkipAllAudioTracks}, SkipAllSubtitleTracks: {jobProfile.SkipAllSubtitleTracks}");
         }
 
-        private void StartEac(string arguments, bool asyncRead)
+        private void StartEac(string arguments, string logPath, bool asyncRead)
         {
+            // Since eac3to does not support log paths containing spaces, we first calculate a short hash 
+            // from the intended log path to serve as the log filename. We then launch eac3to in the 
+            // working directory to generate the log, and finally rename the log file back to its full name.
+            var workingPathDir = Path.GetDirectoryName(WorkingPathPrefix);
+            var logPathFull = Path.Combine(workingPathDir, logPath);
+            byte[] buffer = Encoding.UTF8.GetBytes(logPathFull);
+            var crc = CRC32.Compute(buffer);
+            var logHashPath = crc.ToString("X8") + ".eac3to.log";
+
+            Logger.Trace($"workingPathDir: {workingPathDir}");
+            Logger.Trace($"eac3to logPathFull: {logPathFull}");
+            Logger.Trace($"eac3to logHashPath: {logHashPath}");
+
             var startInfo = new ProcessStartInfo
             {
                 FileName = _eacPath,
-                Arguments = arguments + " -progressnumbers",
+                Arguments = arguments + $" -log=\"{logHashPath}\"" + " -progressnumbers",
                 RedirectStandardOutput = true,
                 RedirectStandardError = true,
                 StandardOutputEncoding = Encoding.UTF8,
                 StandardErrorEncoding = Encoding.UTF8,
                 UseShellExecute = false,
                 WindowStyle = ProcessWindowStyle.Hidden,
                 CreateNoWindow = true,
+                WorkingDirectory = workingPathDir,
             };
             Logger.Info(startInfo.FileName + " " + startInfo.Arguments);
 
@@ -135,6 +149,24 @@ private void StartEac(string arguments, bool asyncRead)
                     readStream(proc.StandardOutput);
                     proc.WaitForExit();
                 }
+
+                FileInfo logFile = new FileInfo(Path.Combine(workingPathDir, logHashPath));
+                if (logFile.Exists)
+                {
+                    FileInfo logFileFinal = new FileInfo(logPathFull);
+                    if (logFileFinal.Exists)
+                    {
+                        logFileFinal.Delete();
+                    }
+                    logFile.MoveTo(logPathFull);
+                }
+
+                if (proc.ExitCode != 0)
+                {
+                    OKETaskException ex = new OKETaskException(Constants.eac3toErrorSmr);
+                    ex.Data["EXIT_CODE"] = proc.ExitCode;
+                    throw ex;
+                }
             }
             catch (Exception e) { throw e; }
         }
@@ -295,10 +327,14 @@ public MediaFile Extract(Action<double, EACProgressType> progressCallback)
             {
                 return null;
             }
+
+            var baseName = Path.GetFileNameWithoutExtension(sourceFile);
+            string logPath = $"{baseName}.eac3to.log";
+
             _progressCallback = progressCallback;
 
             state = ProcessState.FetchStream;
-            StartEac($"\"{sourceFile}\"", false);
+            StartEac($"\"{sourceFile}\"", logPath, false);
 
             if (SkipAllAudioTracks)
             {
@@ -390,7 +426,7 @@ public MediaFile Extract(Action<double, EACProgressType> progressCallback)
             JobSub.RemoveAll(info => info.MuxOption == MuxOption.Skip);
 
             state = ProcessState.ExtractStream;
-            StartEac($"\"{sourceFile}\" {string.Join(" ", args)}", true);
+            StartEac($"\"{sourceFile}\" {string.Join(" ", args)}", logPath, true);
 
             foreach (TrackInfo track in extractResult)
             {

OKEGui/OKEGui/JobProcessor/ExceptionParser.cs

@@ -69,6 +69,10 @@ public static ExceptionMsg Parse(OKETaskException ex, TaskDetail task)
             }
             switch (ex.summary)
             {
+                case Constants.eac3toErrorSmr:
+                    msg.errorMsg = string.Format(Constants.eac3toErrorMsg, ex.Data["EXIT_CODE"], task.InputFile);
+                    break;
+
                 case Constants.audioNumMismatchSmr:
                     msg.errorMsg = string.Format(Constants.audioNumMismatchMsg, ex.Data["SRC_TRACK"], ex.Data["DST_REQ_TRACK"], ex.Data["DST_OPT_TRACK"], task.InputFile);
                     break;

OKEGui/OKEGui/Utils/Cleaner.cs

@@ -14,7 +14,7 @@ class Cleaner
         private const string TIME_FMT = "ddHHmm";
 
         public Cleaner() : this(
-            new List<string> { "flac", "alac", "aac", "ac3", "dts", "eac3", "sup", "Log.txt", "vpy", "qpf", "lwi", "rpc", "pyc" },
+            new List<string> { "flac", "alac", "aac", "ac3", "dts", "eac3", "sup", "Log.txt", "eac3to.log", "vpy", "qpf", "lwi", "rpc", "pyc" },
             new List<string> { "hevc", "mkv", "mp4", "mka", "h264" })
         {
         }

OKEGui/OKEGui/Utils/Constants.cs

@@ -39,7 +39,9 @@ public static class Constants
         public const string language = "jpn";
 
         //Error messages and summaries
-       
+        public const string eac3toErrorMsg = "eac3to出错: 退出代码{0}，请查看日志并手动运行eac3to获取更多信息。该文件{1}将跳过处理。请转告技术总监复查。";
+        public const string eac3toErrorSmr = "eac3to出错";
+
         public const string audioNumMismatchMsg = "当前的视频含有轨道数{0}，与json中指定的数量{1}必须+{2}可选不符合。该文件{3}将跳过处理。请转告技术总监复查。";
         public const string audioNumMismatchSmr = "音轨数不一致";