Skip to content

Commit 7cf1284

Browse files
committed
Deprecate support for "SkipMuxing", "IncludeSub" and "SubtitleLanguage"
1 parent 74d6f6f commit 7cf1284

File tree

5 files changed

+14
-23
lines changed

5 files changed

+14
-23
lines changed

OKEGui/OKEGui/Model/Info/AudioInfo.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@ public class AudioInfo : Info
1010
{
1111
public string OutputCodec;
1212
public int Bitrate;
13-
[ObsoleteAttribute("SkipMuxing is obsolete. Use MuxOption instead.", false)]
14-
public bool SkipMuxing;
1513

1614
public AudioInfo() : base()
1715
{

OKEGui/OKEGui/Properties/AssemblyInfo.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,4 +47,4 @@
4747
//可以指定所有这些值,也可以使用“生成号”和“修订号”的默认值,
4848
// 方法是按如下所示使用“*”: :
4949
// [assembly: AssemblyVersion("1.0.*")]
50-
[assembly: AssemblyVersion("4.11.*")]
50+
[assembly: AssemblyVersion("5.0.*")]

OKEGui/OKEGui/Task/AddTaskService.cs

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,16 @@ public static class AddTaskService
1515
public static TaskProfile LoadJsonAsProfile(string filePath, DirectoryInfo jsonDir)
1616
{
1717
string profileStr = File.ReadAllText(filePath);
18+
19+
foreach (string option in Constants.deprecatedOptions)
20+
{
21+
if (profileStr.IndexOf(option, StringComparison.OrdinalIgnoreCase) >= 0)
22+
{
23+
MessageBox.Show(option + "已不再支持", "json文件版本太老了", MessageBoxButton.OK, MessageBoxImage.Error);
24+
return null;
25+
}
26+
}
27+
1828
TaskProfile json;
1929
try
2030
{
@@ -125,17 +135,6 @@ public static TaskProfile ProcessJsonProfile(TaskProfile json, DirectoryInfo pro
125135
}
126136
}
127137

128-
json.SubtitleLanguage = string.IsNullOrEmpty(json.SubtitleLanguage) ? Constants.language : json.SubtitleLanguage;
129-
if (json.IncludeSub && json.SubtitleTracks == null)
130-
{
131-
MessageBox.Show("现在用SubtitleTracks指定字幕,指定了IncludeSub = true将视为有一条视频轨道", "IncludeSub不再使用", MessageBoxButton.OK, MessageBoxImage.Warning);
132-
Info info = new Info
133-
{
134-
Language = json.SubtitleLanguage
135-
};
136-
json.SubtitleTracks = new List<Info> { info };
137-
}
138-
139138
if (json.AudioTracks != null && json.AudioTracks.Count > 0)
140139
{
141140
// 主音轨
@@ -160,11 +159,6 @@ public static TaskProfile ProcessJsonProfile(TaskProfile json, DirectoryInfo pro
160159
{
161160
track.Language = Constants.language;
162161
}
163-
if (track.MuxOption == MuxOption.Default && track.SkipMuxing)
164-
{
165-
MessageBox.Show("现在用MuxOption指定封装法则,指定了SkipMuxing = true的音轨将不被抽取。", "SkipMuxing不再使用", MessageBoxButton.OK, MessageBoxImage.Warning);
166-
track.MuxOption = MuxOption.Skip;
167-
}
168162
}
169163
}
170164
else

OKEGui/OKEGui/Task/TaskProfile.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,6 @@ public class TaskProfile : ICloneable
2222
public uint FpsDen;
2323
public List<AudioInfo> AudioTracks;
2424
public string InputScript;
25-
[ObsoleteAttribute("IncludeSub is obsolete. Use SubtitleTracks instead.", false)]
26-
public bool IncludeSub;
27-
[ObsoleteAttribute("SubtitleLanguage is obsolete. Use SubtitleTracks instead.", false)]
28-
public string SubtitleLanguage;
2925
public List<Info> SubtitleTracks;
3026
public List<string> InputFiles;
3127
public EpisodeConfig Config;

OKEGui/OKEGui/Utils/Constants.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,5 +66,8 @@ public static class Constants
6666
public static readonly Regex inputRegex = new Regex("# *OKE:INPUTFILE([\\s]+\\w+[ ]*=[ ]*)([r]*[\"'].*[\"'])", RegexOptions.Multiline | RegexOptions.IgnoreCase);
6767
public static readonly Regex debugRegex = new Regex("# *OKE:DEBUG([\\s]+\\w+[ ]*=[ ]*)(\\w+)", RegexOptions.Multiline | RegexOptions.IgnoreCase);
6868

69+
//Deprecated option list
70+
public static readonly List<string> deprecatedOptions = new List<string> { "SkipMuxing", "IncludeSub", "SubtitleLanguage" };
71+
6972
}
7073
}

0 commit comments

Comments
 (0)