Fixed possible crash trying to find Gum location if FRB is added to too-shallow of a path

fixes #1714

Author: vchelaru

Engines/FlatRedBallXNA/FlatRedBall/IO/FilePath.cs

@@ -176,16 +176,25 @@ public override int GetHashCode()
 
         public bool Exists()
         {
-            var standardized = this.StandardizedCaseSensitive;
-            if(standardized.EndsWith("/"))
+            try
             {
-                return System.IO.Directory.Exists(this.StandardizedCaseSensitive);
+                var standardized = this.StandardizedCaseSensitive;
+                if(standardized.EndsWith("/"))
+                {
+                    return System.IO.Directory.Exists(this.StandardizedCaseSensitive);
+                }
+                else
+                {
+                    // Update - this may be a directory like "c:/SomeDirectory/" or "c:/SomeDirectory/". We don't know, so we have to check both directory and file:
+                    return System.IO.File.Exists(this.StandardizedCaseSensitive) ||
+                        System.IO.Directory.Exists(this.StandardizedCaseSensitive);
+                }
             }
-            else
+            catch(InvalidOperationException)
             {
-                // Update - this may be a directory like "c:/SomeDirectory/" or "c:/SomeDirectory/". We don't know, so we have to check both directory and file:
-                return System.IO.File.Exists(this.StandardizedCaseSensitive) ||
-                    System.IO.Directory.Exists(this.StandardizedCaseSensitive);
+                // This can happen if we have a file path with too many ../'s, going past the root
+                // In that case, the file does not exist
+                return false;
             }
         }
 

FRBDK/Glue/Glue/Plugins/ExportedImplementations/CommandInterfaces/FileCommands.cs

@@ -563,26 +563,7 @@ public void OpenFileInDefaultProgram(string fileName, string OpensWith = null)
                     if (string.IsNullOrEmpty(executable) && !WindowsFileAssociation.NativelyHandledExtensions.Contains(effectiveExtension))
                     {
                         //Attempt to get relative projects
-                        FilePath? absoluteExe = null;
-                        if (GumFileExtensions.Contains(textExtension.ToLower()))
-                        {
-                            absoluteExe = GlueState.Self.GlueExeDirectory + "../../../../../../Gum/Gum/bin/Debug/Data/Gum.exe";
-
-                            if(absoluteExe?.Exists() == false)
-                            {
-                                absoluteExe = GlueState.Self.GlueExeDirectory + "Gum/Data/Gum.exe";
-                            }
-                        }
-                        if (String.Equals(textExtension, "achx", StringComparison.OrdinalIgnoreCase))
-                        {
-                            absoluteExe = GlueState.Self.GlueExeDirectory + "../../../../AnimationEditor/PreviewProject/bin/Debug/AnimationEditor.exe";
-                            var foundAnimationEditor = absoluteExe?.Exists() == true;
-                            if(!foundAnimationEditor)
-                            {
-                                // check if it's in the default built location if the user is running from prebuilt:
-                                absoluteExe = GlueState.Self.GlueExeDirectory + "AnimationEditor/AnimationEditor.exe";
-                            }
-                        }
+                        FilePath absoluteExe = TryToGetFilePathFromExtension(textExtension);
                         if ((absoluteExe != "") && absoluteExe?.Exists() == true)
                         {
                             Process.Start(new ProcessStartInfo(absoluteExe.FullPath, fileName));
@@ -655,6 +636,32 @@ void OpenProcess()
             }
         }
 
+        private FilePath TryToGetFilePathFromExtension(string textExtension)
+        {
+            FilePath? absoluteExe = null;
+            if (GumFileExtensions.Contains(textExtension.ToLower()))
+            {
+                absoluteExe = GlueState.Self.GlueExeDirectory + "../../../../../../Gum/Gum/bin/Debug/Data/Gum.exe";
+
+                if (absoluteExe?.Exists() == false)
+                {
+                    absoluteExe = GlueState.Self.GlueExeDirectory + "Gum/Data/Gum.exe";
+                }
+            }
+            if (String.Equals(textExtension, "achx", StringComparison.OrdinalIgnoreCase))
+            {
+                absoluteExe = GlueState.Self.GlueExeDirectory + "../../../../AnimationEditor/PreviewProject/bin/Debug/AnimationEditor.exe";
+                var foundAnimationEditor = absoluteExe?.Exists() == true;
+                if (!foundAnimationEditor)
+                {
+                    // check if it's in the default built location if the user is running from prebuilt:
+                    absoluteExe = GlueState.Self.GlueExeDirectory + "AnimationEditor/AnimationEditor.exe";
+                }
+            }
+
+            return absoluteExe;
+        }
+
         private static string GetFileName(ReferencedFileSave currentReferencedFileSave)
         {
             string fileName = null;