Fixed crash trying to instantiate forms objects.

Author: vchelaru

FRBDK/Glue/GumPlugin/GumPlugin/CodeGeneration/GueDerivingClassCodeGenerator.cs

@@ -510,17 +510,29 @@ public void GenerateConstructor(ElementSave elementSave, ICodeBlock currentBlock
 
             bool hasBase = !string.IsNullOrEmpty(elementSave.BaseType);
 
-            if(hasBase)
+            string throwaway;
+            var thisIsAFormsObject =
+                GetIfShouldGenerateFormsCode(elementSave, out throwaway) || FormsClassCodeGenerator.Self.GetIfShouldGenerate(elementSave);
+
+            if (hasBase)
             {
-                baseCall = "base(false, tryCreateFormsObject)";
+                // If this is a Forms object, then it should NOT try to create a forms object at the base level
+                if(thisIsAFormsObject)
+                {
+                    // don't generate at the base, do it here at the derived
+                    baseCall = "base(false, false)";
+                }
+                else
+                {
+                    baseCall = "base(false, tryCreateFormsObject)";
+                }
             }
             var constructor = currentBlock.Constructor("public", runtimeClassName, "bool fullInstantiation = true, bool tryCreateFormsObject = true",  baseCall );
 
             // This may not have a value, so if not, don't set it:
             var state = elementSave.DefaultState;
 
-            string throwaway;
-            if (GetIfShouldGenerateFormsCode(elementSave, out throwaway) || FormsClassCodeGenerator.Self.GetIfShouldGenerate(elementSave))
+            if (thisIsAFormsObject)
             {
                 constructor.Line("this.tryCreateFormsObject = tryCreateFormsObject;");
             }

Tests/TestProjectDesktopNet6/TestProjectDesktopNet6/Content/GumProject/Components/UserControlDerived.gucx

@@ -32,6 +32,24 @@
       <Category>Rendering</Category>
       <SetsValue>true</SetsValue>
     </Variable>
+    <Variable>
+      <Type>float</Type>
+      <Name>ButtonInstance.Width</Name>
+      <Value xsi:type="xsd:float">124</Value>
+      <SetsValue>true</SetsValue>
+    </Variable>
+    <Variable>
+      <Type>float</Type>
+      <Name>ButtonInstance.X</Name>
+      <Value xsi:type="xsd:float">13</Value>
+      <SetsValue>true</SetsValue>
+    </Variable>
+    <Variable>
+      <Type>float</Type>
+      <Name>ButtonInstance.Y</Name>
+      <Value xsi:type="xsd:float">17</Value>
+      <SetsValue>true</SetsValue>
+    </Variable>
     <Variable>
       <Type>ChildrenLayout</Type>
       <Name>ChildrenLayout</Name>
@@ -236,5 +254,10 @@
     <BaseType>DefaultForms/ColoredFrame</BaseType>
     <DefinedByBase>true</DefinedByBase>
   </Instance>
+  <Instance>
+    <Name>ButtonInstance</Name>
+    <BaseType>DefaultForms/Button</BaseType>
+    <DefinedByBase>false</DefinedByBase>
+  </Instance>
   <Behaviors />
 </ComponentSave>

Tests/TestProjectDesktopNet6/TestProjectDesktopNet6/TestProjectDesktopNet6.csproj

@@ -2053,6 +2053,7 @@
     <Compile Include="Factories\VariantEntityBaseFactory.Generated.cs" />
     <Compile Include="Factories\VariantEntityDerivedFactory.Generated.cs" />
     <Compile Include="FileAliases.Generated.cs" />
+    <Compile Include="Forms\Components\UserControlDerivedForms.Generated.cs" />
     <Compile Include="Forms\Controls\CustomUserControl.cs" />
     <Compile Include="Forms\Screens\BaseGlueScreenNotBaseGumForms.Generated.cs" />
     <Compile Include="Forms\Screens\DerivedOfDerivedScreenGumForms.Generated.cs" />