Addessed same-named animations/categories by not allowing it in Gum. (#2554)

Author: vchelaru

GEMINI.md

@@ -11,3 +11,31 @@ Before proceeding with any request, you **MUST** read and adhere to the guidelin
 1.  **Project Overview & Build/Test Rules**: Read **`CLAUDE.md`**. Use the solution-based building and testing workflows defined there.
 2.  **Code Style & Architecture**: Read **`.claude/code-style.md`**.
 3.  **Task-Specific Logic (Skills)**: Search the **`.claude/skills/`** directory. If a skill exists for the current task (e.g., `gum-cross-platform-unification`), you MUST load its `SKILL.md` and follow its specific checklists and status tracking.
+
+## Agent Workflow
+For every task, invoke the appropriate agent from `.claude/agents/` before proceeding. The agent's instructions provide guidelines for how the task should be performed. Before doing any work, announce which agent you are using such as "Invoking coder agent for this task..."
+
+Available agents:
+- **coder** — Writing or modifying code and unit tests for new features or bugs
+- **qa** — Testing, reviewing changes, and verifying correctness
+- **refactoring-specialist** — Refactoring and improving code structure
+- **docs-writer** — Writing or updating documentation
+- **product-manager** — Breaking down tasks and tracking progress
+- **security-auditor** — Security reviews and vulnerability assessments
+
+Select the agent that best matches the task at hand. For tasks that span multiple concerns (e.g., implement a feature and write tests), invoke the relevant agents in sequence.
+
+## Building and Testing
+
+**Always build and test via a solution file**, not individual `.csproj` files. Plugin projects use `$(SolutionDir)` in post-build scripts, which is undefined when building a `.csproj` directly.
+
+Pick the solution based on what you're working on:
+
+* **`GumFull.sln`** — the Gum tool and all tool-related projects (WPF editor, plugins, `GumToolUnitTests`, `Gum.Cli.Tests`, etc.). Use this when working on anything under `Tool/`, `Gum/`, plugins, or tool-side code.
+* **`AllLibraries.sln`** — all runtime-related projects (`GumCommon`, `MonoGameGum`, `KniGum`, `FnaGum`, `SkiaGum`, `RaylibGum`, and their test projects including `MonoGameGum.Tests`). Use this when working on runtime libraries, `GumCommon`, or anything a shipped game would reference.
+
+Examples:
+* Build: `dotnet build GumFull.sln` or `dotnet build AllLibraries.sln`
+* Test: `dotnet test AllLibraries.sln --filter "TestClassName"`
+
+If a change spans both (e.g. editing `GumCommon` which is linked into both), build both solutions.

Gum/Managers/INameVerifier.cs

@@ -20,6 +20,8 @@ public interface INameVerifier
 
     bool IsInstanceNameValid(string instanceName, InstanceSave instanceSave, IInstanceContainer instanceContainer, out string? whyNotValid);
 
+    bool IsNameValidTopLevel(string name, ElementSave element, object? objectToIgnore, out string? whyNotValid);
+
     bool IsVariableNameValid(string variableName, ElementSave elementSave, VariableSave variableSave, out string? whyNotValid);
 
     bool IsBehaviorNameValid(string behaviorName, BehaviorSave behaviorSave, out string? whyNotValid);

Gum/Managers/NameVerifier.cs

@@ -3,6 +3,7 @@
 using Gum.DataTypes.Variables;
 using Gum.Logic;
 using System.CodeDom.Compiler;
+using System.Collections.Generic;
 using System.Collections.Immutable;
 using System.Globalization;
 using System.Linq;
@@ -137,15 +138,17 @@ public class NameVerifier : INameVerifier
 
     private readonly StandardElementsManager _standardElementsManager;
     private readonly IVariableSaveLogic _variableSaveLogic;
+    private readonly Plugins.IPluginManager _pluginManager;
 
     #endregion
 
     #region Folder
 
-    public NameVerifier(IVariableSaveLogic variableSaveLogic)
+    public NameVerifier(IVariableSaveLogic variableSaveLogic, Plugins.IPluginManager pluginManager)
     {
         _standardElementsManager = StandardElementsManager.Self;
         _variableSaveLogic = variableSaveLogic;
+        _pluginManager = pluginManager;
     }
     public bool IsFolderNameValid(string? folderName, out string whyNotValid)
     {
@@ -208,6 +211,11 @@ public bool IsCategoryNameValid(string? name, IStateContainer categoryContainer,
             }
         }
 
+        if(string.IsNullOrEmpty(whyNotValid) && categoryContainer is ElementSave element)
+        {
+            IsNameValidTopLevel(name, element, null, out whyNotValid);
+        }
+
         return string.IsNullOrEmpty(whyNotValid);
     }
     public bool IsStateNameValid(string name, StateSaveCategory category, StateSave stateSave, out string whyNotValid)
@@ -247,6 +255,12 @@ public bool IsInstanceNameValid(string instanceName, InstanceSave instanceSave,
         {
             IsNameAlreadyUsed(instanceName, instanceSave, instanceContainer, out whyNotValid);
         }
+
+        if (string.IsNullOrEmpty(whyNotValid) && instanceContainer is ElementSave element)
+        {
+            IsNameValidTopLevel(instanceName, element, instanceSave, out whyNotValid);
+        }
+
         return string.IsNullOrEmpty(whyNotValid);
     }
     private void IsNameUsedByStandardVariables(string nameToCheck, out string whyNotValid)
@@ -263,6 +277,43 @@ private void IsNameUsedByStandardVariables(string nameToCheck, out string whyNot
             whyNotValid = $"\"Name\" is a reserved keyword so it cannot be used as a name";
         }
     }
+    public bool IsNameValidTopLevel(string name, ElementSave element, object? objectToIgnore, out string? whyNotValid)
+    {
+        whyNotValid = null;
+        var names = new List<TopLevelName>();
+
+        foreach (var instance in element.Instances)
+        {
+            names.Add(new TopLevelName(instance.Name, "Instance", instance));
+        }
+
+        foreach (var category in element.Categories)
+        {
+            names.Add(new TopLevelName(category.Name, "Category", category));
+        }
+
+        if (element.DefaultState != null)
+        {
+            foreach (var variable in element.DefaultState.Variables.Where(item => !string.IsNullOrEmpty(item.ExposedAsName)))
+            {
+                names.Add(new TopLevelName(variable.ExposedAsName, "Variable", variable));
+            }
+        }
+
+        _pluginManager.FillTopLevelNames(element, names);
+
+        string standardizedName = Standardize(name);
+
+        var match = names.FirstOrDefault(item => item.SourceObject != objectToIgnore && Standardize(item.Name) == standardizedName);
+
+        if (match != null)
+        {
+            whyNotValid = $"The name {name} is already used by a(n) {match.Type}";
+            return false;
+        }
+
+        return true;
+    }
     public bool IsVariableNameValid(string variableName, ElementSave elementSave, VariableSave variableSave, out string whyNotValid)
     {
         whyNotValid = null;
@@ -280,6 +331,12 @@ public bool IsVariableNameValid(string variableName, ElementSave elementSave, Va
         {
             IsNameAlreadyUsed(variableName, variableSave, elementSave, out whyNotValid);
         }
+
+        if (string.IsNullOrEmpty(whyNotValid) && elementSave != null)
+        {
+            IsNameValidTopLevel(variableName, elementSave, variableSave, out whyNotValid);
+        }
+
         if (string.IsNullOrEmpty(whyNotValid))
         {
             var existingVariable = elementSave?.GetVariableFromThisOrBase(variableName);

Gum/Managers/TopLevelName.cs

@@ -0,0 +1,3 @@
+namespace Gum.Managers;
+
+public record TopLevelName(string Name, string Type, object? SourceObject);

Gum/Plugins/BaseClasses/PluginBase.cs

@@ -260,6 +260,8 @@ protected PluginBase()
         _dialogService = Locator.GetRequiredService<IDialogService>();
     }
 
+    public virtual void FillTopLevelNames(ElementSave element, List<TopLevelName> names) { }
+
     public abstract void StartUp();
     public abstract bool ShutDown(PluginShutDownReason shutDownReason);
 

Gum/Plugins/IPluginManager.cs

@@ -140,6 +140,7 @@ public interface IPluginManager
     IEnumerable<IPositionedSizedObject>? GetSelectedIpsos();
     System.Numerics.Vector2? GetWorldCursorPosition(InputLibrary.Cursor cursor);
     void FillWithErrors(List<ErrorViewModel> errors, PluginBase? plugin = null);
+    void FillTopLevelNames(ElementSave element, List<TopLevelName> names);
     bool GetIfShouldSuppressRemoveEditorHighlight();
     void FocusSearch();
     bool ShouldExclude(VariableSave defaultVariable, RecursiveVariableFinder rvf);

Gum/Plugins/PluginManager.cs

@@ -657,6 +657,9 @@ public void FillWithErrors(List<ErrorViewModel> errors, PluginBase? plugin = nul
 
     }
 
+    public void FillTopLevelNames(ElementSave element, List<TopLevelName> names) =>
+        CallMethodOnPlugin(plugin => plugin.FillTopLevelNames(element, names));
+
     /// <summary>
     /// Returns whether any plugins are asking un-highlighting to be suppressed when moving over the editor.
     /// If true, then the editor will not un-highlight the currently-highlighted object. This allows other plugins

Gum/StateAnimationPlugin/MainStateAnimationPlugin.cs

@@ -68,6 +68,18 @@ public override Version Version
         get { return new Version(0, 0, 0, 2); }
     }
 
+    public override void FillTopLevelNames(ElementSave element, List<TopLevelName> names)
+    {
+        var animationsSave = _animationCollectionViewModelManager.GetElementAnimationsSave(element);
+        if (animationsSave != null)
+        {
+            foreach (var anim in animationsSave.Animations)
+            {
+                names.Add(new TopLevelName(anim.Name, "Animation", anim));
+            }
+        }
+    }
+
     ObservableCollection<string> AvailableStates { get; set; } = new ObservableCollection<string>();
 
     #endregion

Gum/StateAnimationPlugin/Validation/NameValidator.cs

@@ -16,8 +16,8 @@ public NameValidator(INameVerifier nameVerifier)
     {
         _nameVerifier = nameVerifier;
     }
-    public bool IsAnimationNameValid(string? animationName,
-        IEnumerable<AnimationViewModel> existingAnimations, out string? whyNotValid)
+    public bool IsAnimationNameValid(string? animationName, Gum.DataTypes.ElementSave element,
+        IEnumerable<AnimationViewModel> existingAnimations, out string? whyNotValid, object? objectToIgnore = null)
     {
         whyNotValid = null;
 
@@ -35,11 +35,16 @@ public bool IsAnimationNameValid(string? animationName,
         {
             return false;
         }
-        if(existingAnimations.Any(item=>item.Name.Equals(animationName, StringComparison.InvariantCultureIgnoreCase)))
+        if(existingAnimations.Any(item=>item.Name.Equals(animationName, StringComparison.InvariantCultureIgnoreCase) && item != objectToIgnore))
         {
             whyNotValid = $"The name \"{animationName}\" is already being used.";
             return false;
         }
+
+        if(element != null)
+        {
+            _nameVerifier.IsNameValidTopLevel(animationName, element, objectToIgnore, out whyNotValid);
+        }
 
         return string.IsNullOrEmpty(whyNotValid);
     }

Gum/StateAnimationPlugin/ViewModels/AddAnimationDialogViewModel.cs

@@ -14,11 +14,14 @@ public string Name
         {
             if (Set(value))
             {
+                NotifyPropertyChanged(nameof(ValidationMessage));
                 AffirmativeCommand.NotifyCanExecuteChanged();
             }
         }
     }
 
+    public string? ValidationMessage => Validator?.Invoke(Name);
+
     public bool Loops
     {
         get => Get<bool>();