Merge pull request #35 from vcon-dev/CON-349/relax-validation-for-dispositions-in-vcon-mcp

Refactor dialog disposition handling to accept any string value

Author: pavanputhra

src/tools/vcon-crud.ts

@@ -56,7 +56,7 @@ export const DialogSchema = z.object({
   encoding: z.enum(['base64url', 'json', 'none']).optional(),
   url: z.string().optional(),
   content_hash: z.union([z.string(), z.array(z.string())]).optional(),
-  disposition: z.enum(['no-answer', 'congestion', 'failed', 'busy', 'hung-up', 'voicemail-no-message']).optional(),
+  disposition: z.string().optional().describe('Call disposition; any string accepted (spec suggests no-answer, congestion, failed, busy, hung-up, voicemail-no-message)'),
   session_id: z.string().optional().describe('Session identifier'),  // ✅ New field
   application: z.string().optional().describe('Application that created this dialog'),  // ✅ New field
   message_id: z.string().optional().describe('Message identifier'),  // ✅ New field

src/types/vcon.ts

@@ -107,7 +107,7 @@ export interface Dialog {
   url?: string;             // HTTPS URL to external content
   content_hash?: string | string[];  // SHA-256 hash for integrity verification
 
-  disposition?: DialogDisposition;
+  disposition?: string;  // Any string accepted; spec suggests no-answer, congestion, failed, busy, hung-up, voicemail-no-message
   session_id?: string;      // Section 4.3.10 - Session identifier
   party_history?: PartyHistory[];  // Section 4.3.11
   application?: string;     // Section 4.3.13 - Application identifier
@@ -249,10 +249,11 @@ export function isValidEncoding(encoding: string): encoding is Encoding {
 }
 
 /**
- * Type guard to check if a string is a valid DialogDisposition
+ * Accept any non-empty string as disposition (forgiving of values outside spec).
+ * Spec suggests: no-answer, congestion, failed, busy, hung-up, voicemail-no-message.
  */
-export function isValidDisposition(disposition: string): disposition is DialogDisposition {
-  return ['no-answer', 'congestion', 'failed', 'busy', 'hung-up', 'voicemail-no-message'].includes(disposition);
+export function isValidDisposition(disposition: string): boolean {
+  return typeof disposition === 'string';
 }
 
 /**

src/utils/validation.ts

@@ -11,8 +11,7 @@ import {
   Dialog, 
   Party,
   isValidDialogType,
-  isValidEncoding,
-  isValidDisposition 
+  isValidEncoding
 } from '../types/vcon.js';
 
 export interface ValidationResult {
@@ -114,16 +113,13 @@ export class VConValidator {
         );
       }
 
-      // Incomplete dialogs must have disposition
+      // Incomplete dialogs must have disposition (any string is accepted)
       if (dialog.type === 'incomplete' && !dialog.disposition) {
         this.errors.push(`Dialog ${index} is incomplete but has no disposition`);
       }
 
-      // Validate disposition values
-      if (dialog.disposition && !isValidDisposition(dialog.disposition)) {
-        this.errors.push(
-          `Dialog ${index} has invalid disposition: ${dialog.disposition}`
-        );
+      if (dialog.disposition != null && typeof dialog.disposition !== 'string') {
+        this.errors.push(`Dialog ${index} disposition must be a string`);
       }
 
       // Transfer dialogs must have transfer fields

supabase/migrations/20260226120000_dialog_disposition_allow_any_string.sql

@@ -0,0 +1,4 @@
+-- Allow any string for dialog.disposition (forgiving of values outside spec).
+-- Spec suggests: no-answer, congestion, failed, busy, hung-up, voicemail-no-message.
+-- Drop the CHECK that restricted to only those values.
+ALTER TABLE dialog DROP CONSTRAINT IF EXISTS dialog_disposition_check;

tests/crud-schemas.test.ts

@@ -178,10 +178,11 @@ describe('CRUD Schema Validation', () => {
       }
     });
 
-    it('should validate disposition values', () => {
-      const validDispositions = ['no-answer', 'congestion', 'failed', 'busy', 'hung-up', 'voicemail-no-message'];
-      
-      validDispositions.forEach(disposition => {
+    it('should accept any string for disposition (spec values and custom)', () => {
+      const specDispositions = ['no-answer', 'congestion', 'failed', 'busy', 'hung-up', 'voicemail-no-message'];
+      const customDispositions = ['Customer Hung Up', 'Abandoned', ''];
+
+      [...specDispositions, ...customDispositions].forEach(disposition => {
         const dialog = {
           type: 'incomplete',
           disposition,