Skip to content

Commit 21336e2

Browse files
JavierMatosDJavier MatosJavier Matos
authored
Remove "Compatibility" field from package card. (#154)
* remove compatibility information * remove baseline data from merged data * removed unused code * rebuild * sync with commit on main * use main commit * wip --------- Co-authored-by: Javier Matos <[email protected]> Co-authored-by: Javier Matos <[email protected]>
1 parent b094ac4 commit 21336e2

File tree

4 files changed

+3029
-25027
lines changed

4 files changed

+3029
-25027
lines changed

dist/packages.js

+2-100
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ var wording = {
44
en: {
55
version: 'Version: ',
66
more: ' More...',
7-
compat: 'Compatibility:',
87
website: 'Website',
98
star: 'Star',
109
'total-pkgs': 'Total Packages: ',
@@ -25,7 +24,6 @@ var triplets = [
2524
'x64-windows-static',
2625
'x86-windows',
2726
];
28-
var compatFilter = [];
2927
$(document).ready(function () {
3028
$(".load-results").on("click", function(e) {
3129
renderMorePackages();
@@ -103,84 +101,6 @@ var renderCardDescription = function (fullDesc) {
103101
descriptionDiv.appendChild(shortDescSpan);
104102
return descriptionDiv;
105103
};
106-
var renderCompatibility = function (pkg, packageDiv) {
107-
var compatRowDiv = document.createElement('div');
108-
compatRowDiv.className = 'package-compatibility';
109-
110-
// Compatibility text
111-
var compatDiv = document.createElement('span');
112-
compatDiv.className = 'package-compatibility-text';
113-
compatDiv.textContent = wording[lang]['compat'];
114-
compatRowDiv.appendChild(compatDiv);
115-
116-
// Display processor statuses
117-
let statusDiv = document.createElement('div');
118-
statusDiv.className = 'processor-status';
119-
120-
let compatRowFrag = document.createDocumentFragment();
121-
for (var t of triplets) {
122-
var procStatusDiv = statusDiv.cloneNode(true);
123-
var status = pkg[t];
124-
var simplifiedStatus = status === 'pass' || status === 'fail' ? status : 'unknown';
125-
procStatusDiv.classList.add(simplifiedStatus);
126-
127-
// hide card if it doesn't pass the compatibility filter
128-
if (packageDiv && simplifiedStatus === 'fail' && compatFilter.indexOf(t) !== -1) {
129-
packageDiv.classList.add('hide');
130-
}
131-
132-
let statusIcon;
133-
let alt_text;
134-
switch (simplifiedStatus) {
135-
case 'pass':
136-
statusIcon = '✓';
137-
alt_text = 'Compatible with ' + t;
138-
break;
139-
case 'fail':
140-
statusIcon = '!';
141-
alt_text = 'Not Compatible with ' + t;
142-
break;
143-
default:
144-
statusIcon = '?';
145-
alt_text = 'Compatibility unknown on ' + t;
146-
}
147-
148-
procStatusDiv.textContent = statusIcon + ' ' + t;
149-
let spanTip = document.createElement('span');
150-
151-
spanTip.textContent = alt_text;
152-
procStatusDiv.appendChild(spanTip);
153-
procStatusDiv.classList.add('tip');
154-
compatRowFrag.appendChild(procStatusDiv);
155-
}
156-
compatRowDiv.appendChild(compatRowFrag);
157-
return compatRowDiv;
158-
};
159-
var renderCompability = function (pkg, packageDiv) {
160-
var compatRowDiv = document.createElement('div');
161-
compatRowDiv.className = 'package-compatibility';
162-
// Compatibility text
163-
var compatDiv = document.createElement('span');
164-
compatDiv.className = 'package-compatibility-text';
165-
compatDiv.textContent = wording[lang]['compat'];
166-
compatRowDiv.appendChild(compatDiv);
167-
// Display processor statuses
168-
var statusDiv = document.createElement('div');
169-
statusDiv.className = 'processor-status';
170-
var compatRowFrag = document.createDocumentFragment();
171-
var platformPassesString = "";
172-
for (var _i = 0, triplets_1 = triplets; _i < triplets_1.length; _i++) {
173-
var t = triplets_1[_i];
174-
var status = pkg[t];
175-
if(status === 'pass') {
176-
platformPassesString += ", " + triplets_1[_i]
177-
}
178-
}
179-
statusDiv.textContent = platformPassesString.substring(2);
180-
compatRowFrag.appendChild(statusDiv);
181-
compatRowDiv.appendChild(compatRowFrag);
182-
return compatRowDiv;
183-
};
184104
function expandText(moreDescSpan, extraDescSpan) {
185105
extraDescSpan.classList.remove('hide');
186106
moreDescSpan.className = 'hide';
@@ -261,8 +181,6 @@ function renderPackageDetails(package, packageDiv, isCard) {
261181
: renderModalDescription(fullDesc);
262182
detailFrag.appendChild(descriptionDiv);
263183
}
264-
// Package Processor Compatibilities
265-
detailFrag.appendChild(renderCompatibility(package, packageDiv));
266184

267185
detailFrag.appendChild(vcpkgPage);
268186

@@ -409,7 +327,7 @@ function renderCard(package, mainDiv, oldCancellationToken) {
409327
// Div for each package
410328
var packageDiv = parentPackageDiv.cloneNode(true);
411329
var cardFrag = document.createDocumentFragment();
412-
//package details (e.g description, compatibility, website)
330+
//package details (e.g description, website)
413331
cardFrag.appendChild(renderPackageDetails(package, packageDiv));
414332
// Add the package card to the page
415333
packageDiv.appendChild(cardFrag);
@@ -572,25 +490,9 @@ function sortPackages() {
572490
break;
573491
}
574492
}
575-
function filterCompat() {
576-
compatFilter = Array.from(document.querySelectorAll(".compat-card input[type='checkbox']:checked")).map(function (e) { return e.value; });
577-
renderPackages();
578-
}
579493

580494
function loadTotalPackages() {
581495
var totalPackages = document.getElementsByClassName('total-packages')[0];
582-
var hiddenPackages = new Set();
583-
for (var i = 0; i < currentPackages.length; i++) {
584-
for (var _i = 0, triplets_2 = triplets; _i < triplets_2.length; _i++) {
585-
var t = triplets_2[_i];
586-
var status_1 = currentPackages[i][t];
587-
var simplifiedStatus = status_1 === 'pass' || status_1 === 'fail' ? status_1 : 'unknown';
588-
if (simplifiedStatus === 'fail' && compatFilter.indexOf(t) !== -1) {
589-
hiddenPackages.add(currentPackages[i]);
590-
}
591-
}
592-
}
593-
594-
let packagesFound = currentPackages.length - hiddenPackages.size;
496+
let packagesFound = currentPackages.length;
595497
totalPackages.textContent = 'Showing 1-' + maxPackageLength + ' of ' + packagesFound + ' packages';
596498
}

0 commit comments

Comments
 (0)