ignore empty keys

if the API returns keys with as key a falsey value, do not represent that key value pair in the mapping

Author: vdloo

consul_kv/api.py

@@ -97,7 +97,7 @@ def get_kv(k=None, recurse=False, endpoint=DEFAULT_KV_ENDPOINT, timeout=socket._
         # values are stored base64 encoded in consul, they
         # are decoded before returned by this function.
         r['Key']: b64decode(r['Value']).decode('utf-8')
-        if r['Value'] else None for r in result
+        if r['Value'] else None for r in result if r['Key']
     }
     return mapping
 

tests/unit/api/test_get_kv.py

@@ -92,3 +92,16 @@ def test_get_kv_returns_empty_results_as_none(self):
             'key1': None
         }
         self.assertEqual(ret, expected_mapping)
+
+    def test_get_kv_ignores_empty_keys(self):
+        self.json_dump = '[{"Key": "", "Value": null}]'
+        self.request.urlopen.return_value.__enter__ = lambda x: Mock(
+            read=lambda: Mock(
+                decode=lambda _: self.json_dump
+            )
+        )
+
+        ret = get_kv('some/path', recurse=True)
+
+        expected_mapping = {}
+        self.assertEqual(ret, expected_mapping)