fix: release CI (#1391)

Author: darrenkel

.github/workflows/on-release.yaml

@@ -53,108 +53,23 @@ jobs:
             exit 1
           fi
 
-  # Split the job in 2. First one finds the relevant RC tag, and outputs it. The next job should be manually approved by the release team.
-  find-and-pull-rc-image:
-    name: Find and Pull RC Image
-    runs-on: ubuntu-22.04
-    permissions:
-      contents: read
+  publish-docker-image:
+    name: Publish Docker Image
+    uses: ./.github/workflows/publish-docker-images.yaml
+    secrets: inherit
     needs:
       - validate
-    outputs:
-      rc_tag: ${{ steps.find-rc.outputs.latest_rc_tag }}
-    steps:
-      - name: Find Latest RC Tag
-        id: find-rc
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: |
-          echo "Release tag: ${{ github.ref_name }}"
-          # Find all RC tags for this version and get the latest one
-          latest_rc=$(gh api repos/${{github.repository}}/git/refs/tags \
-            --jq '[.[]
-              | select(.ref | test("refs/tags/${{ github.ref_name }}-rc.[0-9]+$"))
-              | {ref, rc: (.ref | capture("rc\\.(?<num>[0-9]+)$").num | tonumber)}
-            ]
-            | sort_by(.rc)
-            | last
-            | .ref')
-
-          # remove the "refs/tags/" prefix
-          latest_rc="${latest_rc#refs/tags/}"
-          
-          if [ -z "$latest_rc" ]; then
-            echo "No RC tag found for ${{ github.ref_name }}"
-            exit 1
-          fi
-          
-          echo "Latest RC tag: $latest_rc"
-          echo "latest_rc_tag=$latest_rc" >> $GITHUB_OUTPUT
-
-      - name: Pull RC Image from Docker Hub
-        run: |
-          RC_TAG="${{ steps.find-rc.outputs.latest_rc_tag }}"
-          REPO="${{ github.repository }}"
-          
-          echo "Pulling RC image: $REPO:$RC_TAG"
-          # Pull from Docker Hub (public, no login needed)
-          docker pull $REPO:$RC_TAG
-
-  retag-and-publish-docker-image:
-    name: Retag and Publish Docker Image
-    runs-on: ubuntu-22.04
-    needs:
-      - find-and-pull-rc-image
     permissions:
       contents: read
       packages: write
-    environment: docker-publish
-    steps:
-      - name: Log in to Docker Hub
-        uses: docker/login-action@v3
-        with:
-          username: ${{ secrets.DOCKERHUB_USERNAME }}
-          password: ${{ secrets.DOCKERHUB_TOKEN }}
-
-      - name: Log in to the Container registry
-        uses: docker/login-action@v3
-        with:
-          registry: ghcr.io
-          username: ${{ github.actor }}
-          password: ${{ secrets.GITHUB_TOKEN }}
-
-      - name: Pull, Retag and Push Docker Images
-        env:
-          RC_TAG: ${{ needs.find-and-pull-rc-image.outputs.rc_tag }}
-          RELEASE_TAG: ${{ github.ref_name }}
-          REPO: ${{ github.repository }}
-        run: |
-          echo "Using RC tag: $RC_TAG"
-          echo "Release tag: $RELEASE_TAG"
-          
-          # Pull RC images from both registries
-          docker pull $REPO:$RC_TAG
-          docker pull ghcr.io/$REPO:$RC_TAG
-          
-          echo "Retagging images for release: $RELEASE_TAG"
-          
-          # Retag Docker Hub images
-          docker tag $REPO:$RC_TAG $REPO:$RELEASE_TAG
-          docker tag $REPO:$RC_TAG $REPO:latest
-          
-          # Retag GHCR images  
-          docker tag ghcr.io/$REPO:$RC_TAG ghcr.io/$REPO:$RELEASE_TAG
-          docker tag ghcr.io/$REPO:$RC_TAG ghcr.io/$REPO:latest
-          
-          echo "Pushing retagged images"
-          
-          # Push to Docker Hub
-          docker push $REPO:$RELEASE_TAG
-          docker push $REPO:latest
-          
-          # Push to GHCR
-          docker push ghcr.io/$REPO:$RELEASE_TAG
-          docker push ghcr.io/$REPO:latest
+    with:
+      environment: docker-publish
+      images: |
+        ${{ github.repository }}
+        ghcr.io/${{ github.repository }}
+      tags: |
+        type=raw,value=${{ github.ref_name }}
+        type=raw,value=latest
 
   publish-binaries:
     name: Publish Binaries