txpool: modernize test loops (range, WaitGroup.Go)

Author: libotony

txpool/tx_object_test.go

@@ -85,7 +85,7 @@ func mineLegacyTxWithWork(
 	evalWork := builder.Build().EvaluateWork(from.Address)
 
 	const maxAttempts = 20_000_000
-	for nonce := uint64(0); nonce < maxAttempts; nonce++ {
+	for nonce := range uint64(maxAttempts) {
 		if evalWork(nonce).Cmp(minWork) >= 0 {
 			return tx.MustSign(builder.Nonce(nonce).Build(), from.PrivateKey)
 		}

txpool/tx_pool_benchmark_test.go

@@ -26,7 +26,7 @@ func newBenchPool() *TxPool {
 // Signing is ECDSA and expensive, so it must happen outside the timed region.
 func genBenchTxs(pool *TxPool, n, workerIdx int) []*tx.Transaction {
 	txs := make([]*tx.Transaction, n)
-	for i := 0; i < n; i++ {
+	for i := range n {
 		from := devAccounts[(workerIdx+i)%len(devAccounts)]
 		txs[i] = newTx(tx.TypeLegacy, pool.repo.ChainTag(), nil, 21000, tx.BlockRef{}, 100, nil, tx.Features(0), from)
 	}
@@ -38,7 +38,7 @@ func benchAddRemove(b *testing.B, workers, perWorker int, withWash bool) {
 	defer pool.Close()
 
 	sets := make([][]*tx.Transaction, workers)
-	for w := 0; w < workers; w++ {
+	for w := range workers {
 		sets[w] = genBenchTxs(pool, perWorker, w)
 	}
 
@@ -62,11 +62,11 @@ func benchAddRemove(b *testing.B, workers, perWorker int, withWash bool) {
 
 	var wg sync.WaitGroup
 	per := b.N / workers
-	for w := 0; w < workers; w++ {
+	for w := range workers {
 		wg.Add(1)
 		go func(set []*tx.Transaction) {
 			defer wg.Done()
-			for i := 0; i < per; i++ {
+			for i := range per {
 				trx := set[i%len(set)]
 				_ = pool.Add(trx)                 // publishes pricing snapshot (atomic Store) + bookkeeping (map lock)
 				pool.Remove(trx.Hash(), trx.ID()) // reads Cost()/Payer() (atomic Load) + bookkeeping (map lock)

txpool/tx_pool_wash_race_test.go

@@ -48,7 +48,7 @@ func TestConcurrentWashAddRemove(t *testing.T) {
 	// tx it successfully adds is also removed by the same goroutine, so by
 	// the time all workers join, every worker-added tx has had a matching
 	// Remove call (whether or not wash got to it first).
-	for w := 0; w < numAddRemoveWorkers; w++ {
+	for w := range numAddRemoveWorkers {
 		wg.Add(1)
 		go func(workerIdx int) {
 			defer wg.Done()
@@ -70,10 +70,8 @@ func TestConcurrentWashAddRemove(t *testing.T) {
 
 	// Wash workers: repeatedly evaluate/evict/promote against the churning
 	// pool, exercising the lock-free pricing snapshot publish/read path.
-	for w := 0; w < numWashWorkers; w++ {
-		wg.Add(1)
-		go func() {
-			defer wg.Done()
+	for range numWashWorkers {
+		wg.Go(func() {
 			for {
 				select {
 				case <-stop:
@@ -82,7 +80,7 @@ func TestConcurrentWashAddRemove(t *testing.T) {
 				}
 				_, _, _, _ = pool.wash(best, true)
 			}
-		}()
+		})
 	}
 
 	time.Sleep(500 * time.Millisecond)