ignore gosec false positives (#1622)

Author: paologalligit

p2p/discover/node.go

@@ -125,8 +125,8 @@ var incompleteNodeURL = regexp.MustCompile("(?i)^(?:enode://)?([0-9a-f]+)$")
 //
 // For incomplete nodes, the designator must look like one of these
 //
-//    enode://<hex node id>
-//    <hex node id>
+//	enode://<hex node id>
+//	<hex node id>
 //
 // For complete nodes, the node ID is encoded in the username portion
 // of the URL, separated from the host by an @ sign. The hostname can
@@ -139,7 +139,7 @@ var incompleteNodeURL = regexp.MustCompile("(?i)^(?:enode://)?([0-9a-f]+)$")
 // a node with IP address 10.3.58.6, TCP listening port 30303
 // and UDP discovery port 30301.
 //
-//    enode://<hex node id>@10.3.58.6:30303?discport=30301
+//	enode://<hex node id>@10.3.58.6:30303?discport=30301
 func ParseNode(rawurl string) (*Node, error) {
 	if m := incompleteNodeURL.FindStringSubmatch(rawurl); m != nil {
 		id, err := HexID(m[1])
@@ -424,9 +424,9 @@ func hashAtDistance(a common.Hash, n int) (b common.Hash) {
 		pos++
 		bit = 0x80
 	}
-	b[pos] = a[pos]&^bit | ^a[pos]&bit // TODO: randomize end bits
+	b[pos] = a[pos]&^bit | ^a[pos]&bit
 	for i := pos + 1; i < len(a); i++ {
-		b[i] = byte(rand.Intn(255))
+		b[i] = byte(rand.Intn(255)) //#nosec G404
 	}
 	return b
 }

p2p/discover/table.go

@@ -113,7 +113,7 @@ func newTable(t transport, ourID NodeID, ourAddr *net.UDPAddr, nodeDBPath string
 		initDone:   make(chan struct{}),
 		closeReq:   make(chan struct{}),
 		closed:     make(chan struct{}),
-		rand:       mrand.New(mrand.NewSource(0)),
+		rand:       mrand.New(mrand.NewSource(0)), //#nosec G404
 		ips:        netutil.DistinctNetSet{Subnet: tableSubnet, Limit: tableIPLimit},
 	}
 	if err := tab.setFallbackNodes(bootnodes); err != nil {

p2p/discv5/node.go

@@ -133,8 +133,8 @@ var incompleteNodeURL = regexp.MustCompile("(?i)^(?:enode://)?([0-9a-f]+)$")
 //
 // For incomplete nodes, the designator must look like one of these
 //
-//    enode://<hex node id>
-//    <hex node id>
+//	enode://<hex node id>
+//	<hex node id>
 //
 // For complete nodes, the node ID is encoded in the username portion
 // of the URL, separated from the host by an @ sign. The hostname can
@@ -147,7 +147,7 @@ var incompleteNodeURL = regexp.MustCompile("(?i)^(?:enode://)?([0-9a-f]+)$")
 // a node with IP address 10.3.58.6, TCP listening port 30303
 // and UDP discovery port 30301.
 //
-//    enode://<hex node id>@10.3.58.6:30303?discport=30301
+//	enode://<hex node id>@10.3.58.6:30303?discport=30301
 func ParseNode(rawurl string) (*Node, error) {
 	if m := incompleteNodeURL.FindStringSubmatch(rawurl); m != nil {
 		id, err := HexID(m[1])
@@ -430,9 +430,9 @@ func hashAtDistance(a common.Hash, n int) (b common.Hash) {
 		pos++
 		bit = 0x80
 	}
-	b[pos] = a[pos]&^bit | ^a[pos]&bit // TODO: randomize end bits
+	b[pos] = a[pos]&^bit | ^a[pos]&bit
 	for i := pos + 1; i < len(a); i++ {
-		b[i] = byte(rand.Intn(255))
+		b[i] = byte(rand.Intn(255)) //#nosec G404
 	}
 	return b
 }

p2p/discv5/ticket.go

@@ -760,7 +760,7 @@ func globalRandRead(b []byte) {
 	val := 0
 	for n := range b {
 		if pos == 0 {
-			val = rand.Int()
+			val = rand.Int() //#nosec G404
 			pos = 7
 		}
 		b[n] = byte(val)

p2p/rlpx.go

@@ -470,7 +470,7 @@ func sealEIP8(msg any, h *encHandshake) ([]byte, error) {
 	}
 	// pad with random amount of data. the amount needs to be at least 100 bytes to make
 	// the message distinguishable from pre-EIP-8 handshakes.
-	pad := padSpace[:mrand.Intn(len(padSpace)-100)+100]
+	pad := padSpace[:mrand.Intn(len(padSpace)-100)+100] //#nosec G404
 	buf.Write(pad)
 	prefix := make([]byte, 2)
 	binary.BigEndian.PutUint16(prefix, uint16(buf.Len()+eciesOverhead))
@@ -588,8 +588,8 @@ func newRLPXFrameRW(conn io.ReadWriter, s secrets) *rlpxFrameRW {
 	iv := make([]byte, encc.BlockSize())
 	return &rlpxFrameRW{
 		conn:       conn,
-		enc:        cipher.NewCTR(encc, iv),
-		dec:        cipher.NewCTR(encc, iv),
+		enc:        cipher.NewCTR(encc, iv), //#nosec G407
+		dec:        cipher.NewCTR(encc, iv), //#nosec G407
 		macCipher:  macc,
 		egressMAC:  s.EgressMAC,
 		ingressMAC: s.IngressMAC,