Commit 6c5afd8
fix(redis sink): treat PUBLISH with 0 subscribers as success
For Channel data_type, Redis PUBLISH returns the number of subscribers
that received the message. When no subscribers are connected (e.g. the
consumer momentarily dropped its subscription), Redis returns 0.
redis-rs deserializes this integer 0 as bool false into Vec<bool>,
causing is_successful() to return false and Vector to retry the same
request indefinitely — even though the connection and Redis are healthy.
Fix: short-circuit is_successful() to true for DataType::Channel.
A zero-subscriber publish is a valid outcome in pub/sub, not an error.1 parent 92ee2b2 commit 6c5afd8
1 file changed
Lines changed: 8 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
| 75 | + | |
75 | 76 | | |
76 | 77 | | |
77 | 78 | | |
| |||
82 | 83 | | |
83 | 84 | | |
84 | 85 | | |
| 86 | + | |
85 | 87 | | |
86 | 88 | | |
87 | 89 | | |
| |||
96 | 98 | | |
97 | 99 | | |
98 | 100 | | |
| 101 | + | |
99 | 102 | | |
100 | 103 | | |
101 | 104 | | |
102 | 105 | | |
103 | 106 | | |
104 | 107 | | |
105 | | - | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
106 | 112 | | |
107 | 113 | | |
108 | 114 | | |
| |||
0 commit comments