Question about PRs (First-Time Contributor here)

[AdwaitKulkarni58]

Hi!

I am looking to make my first contribution to the repo, and just to go through the process, I made a small documentation change (PR: #26313) through my organization. The PR has been opened; do I need to do anything else now? I see some people add reviewers to their PRs, but I am not seeing that option anywhere. Just want to know what the best practices are. Thank you!

[azat44]

Hi @AdwaitKulkarni58 — welcome, and no, you don't need to do anything else.

The reviewer option isn't missing, it's hidden: only people with write or triage permission on the repo can assign reviewers, so it never shows for outside contributors. The people you've seen doing it are maintainers. Reviewers here get pulled in automatically, so your PR is already in the queue.

The one thing worth checking is the checks section at the bottom of your PR. If anything there is red, that blocks review regardless of how small the change is, and it's on you to fix rather than the maintainers. Common ones on a first PR are lint and the DCO sign-off (commits need a Signed-off-by line — git commit -s adds it, and you can fix existing commits with git rebase --signoff).

Otherwise it's just waiting. Docs PRs on a repo this size can sit a while; a polite bump after a week or so is normal and not considered rude.

[AdwaitKulkarni58]

Sounds good, thanks for the prompt reply!

[azat44]

Glad it helped! If it answered your question, there's a "Mark as answer" option in the ... menu on my comment — handy for the next first-time contributor who searches for the same thing.

Good luck with the PR.

[pront]

Hi @AdwaitKulkarni58, thank you for your contribution. If we need anything else we always respond on the PR itself. Please also see https://github.com/vectordotdev/vector/blob/master/COMMUNITY_RESPONSE_EXPECTATIONS.md.

[pront]

Regarding this question, we require approval maintainer to run these checks mostly for security reasons.