feat(new source): add kubernetes_events source#24448
Conversation
maycmlee
left a comment
There was a problem hiding this comment.
Just some small suggestions!
…events.cue Co-authored-by: May Lee <may.lee@datadoghq.com>
…events.cue Co-authored-by: May Lee <may.lee@datadoghq.com>
…events.cue Co-authored-by: May Lee <may.lee@datadoghq.com>
Co-authored-by: May Lee <may.lee@datadoghq.com>
Co-authored-by: May Lee <may.lee@datadoghq.com>
Co-authored-by: May Lee <may.lee@datadoghq.com>
Co-authored-by: May Lee <may.lee@datadoghq.com>
Co-authored-by: May Lee <may.lee@datadoghq.com>
Co-authored-by: May Lee <may.lee@datadoghq.com>
Co-authored-by: May Lee <may.lee@datadoghq.com>
|
@maycmlee friendly ping. Possible to merge? Thanks |
maycmlee
left a comment
There was a problem hiding this comment.
Looks good for docs! Let me see if someone from eng can review.
|
@lukasmrtvy someone from eng will review and be in touch. Thanks for opening this PR! |
|
@maycmlee are there any news for the PR please? thank you |
|
@Smana sorry for the delayed response! I'm checking in with the eng team again. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e04ba0a88
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@maycmlee / maintainers — what's the status of this PR from an engineering perspective? @elohmeier great work on this. Do you have plans to extend it with leader election I'd like to add both, but unsure whether to wait your PR merge, build on top of this PR or do it separately. |
Looping in @pront to address your questions. Thanks! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ccd00532ff
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9e58987167
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
I'm grateful for the interest in this PR. currently fixing the open codex issues |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6616b0ca26
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 447ed29457
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@pront I there anything left to do? I've addressed all the Codex issues, I think this might be ready to be merged. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a5e6f9c1b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Hi, any update? |
@shahar-h There are a few unresolved threads in this PR. I will try to make time next week to review this. |
Treat Kubernetes resourceVersion values as opaque strings and seed leader bootstrap state without emitting preexisting events after failover. Document the Lease RBAC required when leader election is enabled.
|
Thanks @pront, let me know if anything needs to be fixed. I've addressed the remaining issues in the last commit. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d941527850
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Suppress takeover bootstrap replays only before the previous holder's last renewal so events created while no leader was active are still emitted. Prune stale dedupe entries before bootstrap membership checks and use the configured Helm chart repo in the k8s e2e test.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e751b4799f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Use the previous Lease renewal as the bootstrap cutoff for same-holder restarts and always seed pre-cutoff InitApply objects, even when the UID is cached. Remove invalid source metadata fields from the docs CUE.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb63684618
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Lease renew_time is not delivery progress because renewal can happen while downstream send is still pending. Bootstrap InitApply items rely on delivered-event dedupe instead. Prefer event_time over deprecated timestamps for singleton Events.
Summary
This PR adds a new kubernetes_events source that watches the Kubernetes Events API and emits each event as a Vector log event. This addresses a long-standing feature request and brings Vector closer to feature parity with other observability tools in the Kubernetes ecosystem.
The design is influenced by similar implementations in:
Key features:
We've been using this in Production in various clusters for some weeks now and it has been working fine.
Vector configuration
How did you test this PR?
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
kubernetes_system_eventssource #1293