Function arguments aren't guaranteed to resolve in order

[fuchsnj]

A note for the community

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Problem

When calculating the type definition of a function call, the arguments are evaluated in order, from left to right.

However, there is nothing that guarantees the actual arguments are resolved in the same order (or resolved at all).

Arguments should be resolved in order and only the Value passed to functions.

$ format_number(1000, 2, {.foo = "message"; "."}, {.foo = true; ","})
"1,000.00"

$ .
{ "foo": "message" }

$ type_def(.)
{ "object": { "foo": { "boolean": true } } }

Version

master / 9a049b5

[fuchsnj]

Enforcing this can't be easily done today since not all functions can accept just Value as an argument. For example, the unnest function requires a "query" argument.

We might be able to support query arguments with this once "literal" type definitions are improved (so that queries are treated as a compile time literal and not the runtime value of the query).