Skip to content

Commit 84017f1

Browse files
committed
Fix spec regexes for Ruby 3.4 compatibility
Ruby 3.4 changed NoMethodError messages to use single quotes instead of backticks, and Hash#inspect to use symbol-key syntax ({key: "val"}) instead of rocket syntax ({:key=>"val"}). Update test regexes to accept both formats.
1 parent c686dc0 commit 84017f1

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

spec/advanced_sneakers_activejob/workers_registry/method_missing_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
subject { registry.foobar }
2222

2323
it 'raises NoMethodError' do
24-
expect { subject }.to raise_error(NoMethodError, /undefined method `foobar'/)
24+
expect { subject }.to raise_error(NoMethodError, /undefined method [`']foobar'/)
2525
end
2626
end
2727
end

spec/integration/action_mailer_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
in_app_process(adapter: :sneakers) { SampleMailer.greetings(name: 'Sneakers').deliver_later }
1010

1111
expect_logs name: 'rails',
12-
to_include: /Enqueued ActionMailer::(Mail)?DeliveryJob to Sneakers\(mailers\) with arguments: "SampleMailer", "greetings", "deliver_now", .*\{:name=>"Sneakers"\}/,
12+
to_include: /Enqueued ActionMailer::(Mail)?DeliveryJob to Sneakers\(mailers\) with arguments: "SampleMailer", "greetings", "deliver_now", .*\{(?::name=>|name: )"Sneakers"\}/,
1313
to_exclude: [
1414
'Hello, Sneakers',
1515
/Performed ActionMailer::(Mail)?DeliveryJob/
@@ -25,7 +25,7 @@
2525

2626
expect_logs name: 'rails',
2727
to_include: [
28-
/Enqueued ActionMailer::(Mail)?DeliveryJob to AdvancedSneakers\(mailers\) with arguments: "SampleMailer", "greetings", "deliver_now", .*\{:name=>"Advanced sneakers"\}/,
28+
/Enqueued ActionMailer::(Mail)?DeliveryJob to AdvancedSneakers\(mailers\) with arguments: "SampleMailer", "greetings", "deliver_now", .*\{(?::name=>|name: )"Advanced sneakers"\}/,
2929
'Hello, Advanced sneakers',
3030
/Performed ActionMailer::(Mail)?DeliveryJob/
3131
]

0 commit comments

Comments
 (0)