Skip to content

Commit 4b0f464

Browse files
authored
Merge pull request #3481 from vegaprotocol/release/v0.36.0
Release v0.36.0
2 parents 150398c + 83e8be4 commit 4b0f464

295 files changed

Lines changed: 11302 additions & 8476 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.drone-github.yml

Lines changed: 30 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ steps:
4848
./script/build-multiarch-no-cgo.sh default || exit 1 ;
4949
else
5050
echo "No Go files changed. Skipping building of binary." ;
51-
rm -f cmd/vega/vega-* ;
51+
rm -f cmd/vega/vega-* cmd/vegabenchmark/vegabenchmark-* ;
5252
fi
5353
depends_on:
5454
- fetch
@@ -73,6 +73,35 @@ steps:
7373
event:
7474
- pull_request
7575

76+
- name: build_docker_image-PR
77+
image: docker.pkg.github.com/vegaprotocol/devops-infra/cipipeline-docker:18.09.9
78+
volumes:
79+
- name: dockersock
80+
path: /run/docker.sock
81+
environment:
82+
DOCKER_HOST: unix:///run/docker.sock
83+
DOCKER_CONFIG_JSON:
84+
from_secret: dockerconfig
85+
commands:
86+
- mkdir -p docker/bin
87+
- find cmd -maxdepth 1 -and -not -name cmd | sed -e 's#^cmd/##' | while read -r app ; do
88+
if test -f "cmd/$$app/$$app-linux-amd64" ; then
89+
cp -a "cmd/$$app/$$app-linux-amd64" "docker/bin/$$app" || exit 1 ;
90+
else
91+
echo "dummy_noop" >"docker/bin/$$app" ;
92+
fi ;
93+
done
94+
- tmptag="$$(openssl rand -hex 10)"
95+
- docker build -t "docker.pkg.github.com/vegaprotocol/vega/vega:$$tmptag" docker/
96+
- rm -rf docker/bin
97+
- mkdir -p "$$HOME/.docker" ; echo "$$DOCKER_CONFIG_JSON" >"$$HOME/.docker/config.json" ; unset DOCKER_CONFIG_JSON
98+
- docker rmi "docker.pkg.github.com/vegaprotocol/vega/vega:$$tmptag"
99+
depends_on:
100+
- build-PR
101+
when:
102+
event:
103+
- pull_request
104+
76105
- name: test-PR
77106
image: docker.pkg.github.com/vegaprotocol/devops-infra/cipipeline:1.16.2
78107
volumes:
Lines changed: 115 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,115 @@
1+
---
2+
name: Feature ticket
3+
about: A full description of a new feature, or part of a feature, that we wish to develop
4+
title: ''
5+
labels: "feature"
6+
assignees: ''
7+
---
8+
9+
_Ensure the ticket title clearly communicates what this feature ticket makes possible_
10+
11+
_Add the **milestone** and **project** of the Major Release this feature is part of i.e. Oregon Trail_
12+
13+
_Add a **label** for the feature that this ticket is part of i.e. Data Sourcing_
14+
15+
# Feature Overview
16+
A simple overview that describes what this feature (or sub feature) needs to do and why it's valuable.
17+
This should be brief, understandable by anyone in the business and use the format:
18+
19+
As a (who - the type of user/actor the feature serves)
20+
21+
I want (what - the action to be performed / made possible)
22+
23+
So that (why - the goal/result/value it achieves to the user/actor or the business)
24+
25+
# Tasks
26+
A checklist of the tasks that are needed to develop the feature and meet the accceptance criteria and feature test scenarios. Ideally, tasks would reflect the pull requests likely to be created when developing the feature.
27+
28+
- [ ]
29+
- [ ]
30+
- [ ]
31+
32+
# Product Owner
33+
The name of the person in the Product team that is responsible for this feature. This will be the go-to person for the engineer working on this ticket for any questions / clarifications, to get feedback on work in progress and who will ultimately accept the feature ticket as 'done'.
34+
35+
_**Assign** the named product owner to the ticket_
36+
37+
# Acceptance Criteria
38+
A list of criteria (aim for 3!) that have to be met for this feature to be accepted as 'done' by the product owner. Acceptance criteria should be simple, single sentence, statements written from the perspective of the work already having been done. Each statement should be able to be objectively determined to be true or false. For example:
39+
40+
- It is possible to
41+
- It is possible to
42+
- Vega does
43+
- Vega does
44+
45+
Acceptance Criteria and Feature Test Scenarios can, in some cases, be closely related. If acceptance criteria become fully covered by feature test scenarios they can be removed leaving on acceptance criteria that can't be directly or fully proven with tests.
46+
47+
# Test Scenarios
48+
Detailed scenarios (1-3!) that can be executed as feature tests to verify that the feature has been implemented as expected. We use the follow format:
49+
50+
GIVEN (setup/context)
51+
52+
WHEN (action)
53+
54+
THEN (assertion)
55+
56+
For example...
57+
58+
```gherkin
59+
Feature: Account Holder withdraws cash
60+
Scenario: Account has sufficient funds
61+
Given the account balance is $100
62+
And the card is valid
63+
And the machine contains enough money
64+
When the Account Holder requests $20
65+
Then the ATM should dispense $20
66+
And the account balance should be $80
67+
And the card should be returned
68+
```
69+
70+
See https://github.com/vegaprotocol/vega/tree/develop/integration/ for more format information and examples.
71+
72+
_TBC whether these should be separate files - will come back to this_
73+
74+
# Impacted Systems / Engines
75+
A list of the engines that we believe will be impacted by the development of this feature. _Delete as appropriate_
76+
77+
- Core - banking
78+
- Core - collateral
79+
- Core - execution
80+
- Core - fee
81+
- Core - governance
82+
- Core - liquidity
83+
- Core - oracles
84+
- Core - positions
85+
- Core - risk
86+
- Core - settlement
87+
- Core - monitor
88+
- API
89+
- Wallet
90+
- Liquidity bot
91+
- Trader bot
92+
93+
# API Calls
94+
A list of the API calls that are needed for this feature, written in an implementation-agnostic format i.e. "Get a list of widgets, categorised by X", rather than "GET /widgets?category=X":
95+
96+
- Get a list of widgets, categorised by X
97+
- Get x
98+
- Get y
99+
100+
# Dependencies
101+
Links to the tickets that represent work that this feature ticket is dependent on to be able to start / finish development. This could be another feature ticket, an important refactoring task, some infrastructure work etc. For each dependency please add a categorisation of the type of dependency (hard or soft) and whether it is internal or external to the team.
102+
103+
- #Link to ticket + Dependency ticket name | hard/soft | internal/external
104+
- #Link to ticket + Dependency ticket name | hard/soft | internal/external
105+
- #Link to ticket + Dependency ticket name | hard/soft | internal/external
106+
107+
_Add a **label(s)** to represent the types of dependency this feature ticket has (soft_internal_dependency, soft_external_dependency, hard_internal_dependency, hard_external_dependency)_
108+
109+
# Additional Details (optional)
110+
Any additional information that provides context or gives information that will help us develop the feature.
111+
112+
Feature spec:
113+
114+
# Examples (optional)
115+
Code snippets from the spec for reference

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# Vega specific entries
22
cmd/*/*-dbg
33
cmd/vega/vega*
4+
cmd/vegabenchmark/vegabenchmark*
45
data/
56
.DS_Store
67
.envrc
@@ -17,3 +18,4 @@ vendor/
1718
.vscode/
1819
proto/**.orig
1920
*.pb.go-re
21+
gomock_reflect_*

.spelling

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ lifecycle
3535
linters
3636
MacOSX
3737
MarkToMarket
38+
mempools
3839
multisig
3940
mutex
4041
mutexes

CHANGELOG.md

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,36 @@
11
# Changelog
22

3+
## 0.36.0
4+
*2021-05-13*
5+
6+
### Improvements
7+
- [#3408](https://github.com/vegaprotocol/vega/pull/3408) - Add more information on token proportion/weight on proposal votes APIs
8+
- [#3360](https://github.com/vegaprotocol/vega/pull/3360) - :fire: REST: Move deposits endpoint to `/parties/[partyId]/deposits`
9+
- [#3431](https://github.com/vegaprotocol/vega/pull/3431) - Improve caching of values when exiting auctions
10+
- [#3459](https://github.com/vegaprotocol/vega/pull/3459) - Add extra validation for Order, Vote, Withdrawal and LP transactions
11+
- [#3433](https://github.com/vegaprotocol/vega/pull/3433) - Reject non-persistent orders that fall outside price monitoring bounds
12+
- [#3443](https://github.com/vegaprotocol/vega/pull/3443) - Party is no longer required when submitting an order amendment
13+
- [#3446](https://github.com/vegaprotocol/vega/pull/3443) - Party is no longer required when submitting an order cancellation
14+
- [#3449](https://github.com/vegaprotocol/vega/pull/3449) - Party is no longer required when submitting an withdrawal request
15+
16+
### Fixes
17+
- [#3451](https://github.com/vegaprotocol/vega/pull/3451) - Remove float usage in liquidity engine
18+
- [#3447](https://github.com/vegaprotocol/vega/pull/3447) - Clean up order submission code
19+
- [#3436](https://github.com/vegaprotocol/vega/pull/3436) - Break up internal proposal definitions
20+
- [#3452](https://github.com/vegaprotocol/vega/pull/3452) - Tidy up LP implementation internally
21+
- [#3458](https://github.com/vegaprotocol/vega/pull/3458) - Fix spelling errors in GraphQL docs
22+
- [#3434](https://github.com/vegaprotocol/vega/pull/3434) - Improve test coverage around Liquidity Provisions on auction close
23+
- [#3411](https://github.com/vegaprotocol/vega/pull/3411) - Fix settlement tests
24+
- [#3418](https://github.com/vegaprotocol/vega/pull/3418) - Rename External Resource Checker to Witness
25+
- [#3419](https://github.com/vegaprotocol/vega/pull/3419) - Fix blank IDs on oracle specs in genesis markets
26+
- [#3412](https://github.com/vegaprotocol/vega/pull/3412) - Refactor internal Vote Submission type to be separate from Vote type
27+
- [#3421](https://github.com/vegaprotocol/vega/pull/3421) - Improve test coverage around order uncrossing
28+
- [#3425](https://github.com/vegaprotocol/vega/pull/3425) - Remove debug steps from feature tests
29+
- [#3430](https://github.com/vegaprotocol/vega/pull/3430) - Remove `LiquidityPoolBalance` from configuration
30+
- [#3468](https://github.com/vegaprotocol/vega/pull/3468) - Increase rate limit that was causing mempools to fill up unnecessarily
31+
- [#3438](https://github.com/vegaprotocol/vega/pull/3438) - Split protobuf definitions
32+
- [#3450](https://github.com/vegaprotocol/vega/pull/3450) - Do not emit amendments from liquidity engine
33+
334
## 0.35.0
435
*2021-04-21*
536

GETTING_STARTED.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ git clone git@github.com:vegaprotocol/vega.git
9090
cd vega
9191
git status # On branch develop, Your branch is up to date with 'origin/develop'.
9292

93-
make gettools_build # get the build tools
9493
make deps # get the source dependencies
9594
make install # build the binaries and put them in $GOPATH/bin
9695

Makefile

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,7 @@ race: ## Run data race detector
2929

3030
.PHONY: mocks
3131
mocks: ## Make mocks
32-
@[ -d vendor ] && mv vendor vendor.tmp
33-
@go generate ./...
34-
@[ -d vendor.tmp ] && mv vendor.tmp vendor
32+
@./script/build.sh -a mocks
3533

3634
.PHONY: msan
3735
msan: ## Run memory sanitizer
@@ -125,10 +123,6 @@ print_check: ## Check for fmt.Print functions in Go code
125123
rm -f "$$f" && \
126124
if test "$$count" -gt 0 ; then exit 1 ; fi
127125

128-
.PHONY: gettools_build
129-
gettools_build:
130-
@./script/gettools.sh build
131-
132126
.PHONY: gettools_develop
133127
gettools_develop:
134128
@./script/gettools.sh develop

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Vega
22

3-
Version 0.35.0.
3+
Version 0.36.0.
44

55
A decentralised trading platform that allows pseudo-anonymous trading of derivatives on a blockchain.
66

accounts/service.go

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,11 @@ import (
99
"code.vegaprotocol.io/vega/contextutil"
1010
"code.vegaprotocol.io/vega/logging"
1111
types "code.vegaprotocol.io/vega/proto"
12+
commandspb "code.vegaprotocol.io/vega/proto/commands/v1"
1213
)
1314

1415
var (
15-
// ErrMissingPartyID signals that the payload is expected to contain a party id
16-
ErrMissingPartyID = errors.New("missing party id")
17-
// usually the party specified an amount of 0
16+
// ErrInvalidWithdrawAmount usually the party specified an amount of 0
1817
ErrInvalidWithdrawAmount = errors.New("invalid withdraw amount (must be > 0)")
1918
// ErrMissingAsset signals that an asset was required but not specified
2019
ErrMissingAsset = errors.New("missing asset")
@@ -63,10 +62,7 @@ func (s *Svc) ReloadConf(cfg Config) {
6362
s.Config = cfg
6463
}
6564

66-
func (s *Svc) PrepareWithdraw(ctx context.Context, w *types.WithdrawSubmission) error {
67-
if len(w.PartyId) <= 0 {
68-
return ErrMissingPartyID
69-
}
65+
func (s *Svc) PrepareWithdraw(ctx context.Context, w *commandspb.WithdrawSubmission) error {
7066
if len(w.Asset) <= 0 {
7167
return ErrMissingAsset
7268
}

api/mocks/account_service_mock.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)