Merge pull request #3240 from vegaprotocol/release/v0.34.0

Release v0.34.0

Author: jeremyletang

.drone-github.yml

@@ -19,7 +19,7 @@ steps:
   # ====== Pipeline for pull requests ======
 
   - name: build-PR
-    image: docker.pkg.github.com/vegaprotocol/devops-infra/cipipeline:1.14.4
+    image: docker.pkg.github.com/vegaprotocol/devops-infra/cipipeline:1.16.2
     pull: always
     volumes:
       - name: gocache
@@ -76,7 +76,7 @@ steps:
         - pull_request
 
   - name: test-PR
-    image: docker.pkg.github.com/vegaprotocol/devops-infra/cipipeline:1.14.4
+    image: docker.pkg.github.com/vegaprotocol/devops-infra/cipipeline:1.16.2
     volumes:
       - name: gocache
         path: /go/cache
@@ -90,8 +90,6 @@ steps:
         from_secret: SLACK_HOOK_URL
     commands:
       - failed=""
-      - make staticcheck
-      - make buflint
       - if test "$$DRONE_TARGET_BRANCH" = master -o "$$(grep -cE '(^go.(mod|sum)|\.go)$$' git_diff.txt)" -gt 0 ; then
           make retest || exit 1 ;
           for target in gqlgen_check print_check proto_check race vet ;
@@ -102,7 +100,7 @@ steps:
         else
           echo "No Go files changed. Skipping go tests" ;
         fi
-      - for target in codeowners_check ; do
+      - for target in codeowners_check buflint misspell staticcheck; do
           echo "$$COL_CYAN$$target$$COL_RESET" ;
           make "$$target" || failed="$$failed $$target" ;
         done
@@ -141,7 +139,7 @@ steps:
   # ====== Pipeline for main branches (master, develop) and tags ======
 
   - name: build-branch
-    image: docker.pkg.github.com/vegaprotocol/devops-infra/cipipeline:1.14.4
+    image: docker.pkg.github.com/vegaprotocol/devops-infra/cipipeline:1.16.2
     pull: always
     volumes:
       - name: gocache
@@ -174,7 +172,7 @@ steps:
         - refs/tags/*
 
   - name: deploy_devnet
-    image: docker.pkg.github.com/vegaprotocol/devops-infra/cipipeline:1.14.4
+    image: docker.pkg.github.com/vegaprotocol/devops-infra/cipipeline:1.16.2
     volumes:
       - name: gopkg
         path: /go/pkg
@@ -256,7 +254,7 @@ steps:
         - refs/tags/*
 
   - name: build-multiarch
-    image: docker.pkg.github.com/vegaprotocol/devops-infra/xgo:1.14.4
+    image: docker.pkg.github.com/vegaprotocol/devops-infra/xgo:1.16.2
     pull: always
     volumes:
       - name: gocache
@@ -298,7 +296,7 @@ steps:
       - build-multiarch
 
   - name: changelog_slack
-    image: docker.pkg.github.com/vegaprotocol/devops-infra/cipipeline:1.14.4
+    image: docker.pkg.github.com/vegaprotocol/devops-infra/cipipeline:1.16.2
     environment:
       SLACK_HOOK_URL:
         from_secret: SLACK_HOOK_URL

CHANGELOG.md

@@ -1,5 +1,60 @@
 # Changelog
 
+## 0.34.0
+
+*2021-04-07*
+
+### Improvements
+
+- [#3302](https://github.com/vegaprotocol/vega/pull/3302) - Add reference to LP in orders created by LP
+- [#3183](https://github.com/vegaprotocol/vega/pull/3183) - All orders from LP - including rejected orders - are now sent through the event bus
+- [#3248](https://github.com/vegaprotocol/vega/pull/3248) - Store and propagate bond penalty
+- [#3266](https://github.com/vegaprotocol/vega/pull/3266) - Add network parameters to control auction duration & extension
+- [#3264](https://github.com/vegaprotocol/vega/pull/3264) - Add Liquidity Provision ID to orders created by LP commitments
+- [#3126](https://github.com/vegaprotocol/vega/pull/3126) - Add transfer for bond slashing
+- [#3281](https://github.com/vegaprotocol/vega/pull/3281) - Update scripts to go 1.16.2
+- [#3280](https://github.com/vegaprotocol/vega/pull/3280) - Update to go 1.16.2
+- [#3235](https://github.com/vegaprotocol/vega/pull/3235) - Extend unit test coverage for products
+- [#3219](https://github.com/vegaprotocol/vega/pull/3219) - Remove `liquidityFee` network parameter
+- [#3217](https://github.com/vegaprotocol/vega/pull/3217) - Add an event bus event when a market closes
+- [#3214](https://github.com/vegaprotocol/vega/pull/3214) - Add arbitrary data signing wallet endpoint
+- [#3316](https://github.com/vegaprotocol/vega/pull/3316) - Add tests for traders closing their own position
+- [#3270](https://github.com/vegaprotocol/vega/pull/3270) - _Feature test refactor_: Add Liquidity Provision feature tests
+- [#3289](https://github.com/vegaprotocol/vega/pull/3289) - _Feature test refactor_: Remove unused steps
+- [#3275](https://github.com/vegaprotocol/vega/pull/3275) - _Feature test refactor_: Refactor order cancellation steps
+- [#3230](https://github.com/vegaprotocol/vega/pull/3230) - _Feature test refactor_: Refactor trader amends step
+- [#3226](https://github.com/vegaprotocol/vega/pull/3226) - _Feature test refactor_: Refactor features with invalid order specs
+- [#3200](https://github.com/vegaprotocol/vega/pull/3200) - _Feature test refactor_: Add step to end opening auction
+- [#3201](https://github.com/vegaprotocol/vega/pull/3201) - _Feature test refactor_: Add step to amend order by reference
+- [#3204](https://github.com/vegaprotocol/vega/pull/3204) - _Feature test refactor_: Add step to place pegged orders
+- [#3207](https://github.com/vegaprotocol/vega/pull/3207) - _Feature test refactor_: Add step to create Liquidity Provision
+- [#3212](https://github.com/vegaprotocol/vega/pull/3212) - _Feature test refactor_: Remove unused settlement price step
+- [#3203](https://github.com/vegaprotocol/vega/pull/3203) - _Feature test refactor_: Rework Submit Order step
+- [#3251](https://github.com/vegaprotocol/vega/pull/3251) - _Feature test refactor_:  Split market declaration
+- [#3314](https://github.com/vegaprotocol/vega/pull/3314) - _Feature test refactor_:  Apply naming convention to assertions
+- [#3295](https://github.com/vegaprotocol/vega/pull/3295) - Refactor governance engine tests
+- [#3298](https://github.com/vegaprotocol/vega/pull/3298) - Add order book caching
+- [#3307](https://github.com/vegaprotocol/vega/pull/3307) - Use `UpdateNetworkParams` to validate network parameter updates
+- [#3308](https://github.com/vegaprotocol/vega/pull/3308) - Add probability of trading
+
+### Fixes
+- [#3249](https://github.com/vegaprotocol/vega/pull/3249) - GraphQL: `LiquidityProvision` is no longer missing from the `EventBus` union
+- [#3253](https://github.com/vegaprotocol/vega/pull/3253) - Verify all properties on oracle specs
+- [#3224](https://github.com/vegaprotocol/vega/pull/3224) - Check for wash trades when FOK orders uncross
+- [#3257](https://github.com/vegaprotocol/vega/pull/3257) - Order Status is now only `Active` when it is submitted to the book
+- [#3285](https://github.com/vegaprotocol/vega/pull/3285) - LP provisions are now properly stopped when a market is rejected
+- [#3290](https://github.com/vegaprotocol/vega/pull/3290) - Update Market Value Proxy at the end of each block
+- [#3267](https://github.com/vegaprotocol/vega/pull/3267) - Ensure Liquidity Auctions are not left if it would result in an empty book
+- [#3286](https://github.com/vegaprotocol/vega/pull/3286) - Reduce some log levels
+- [#3263](https://github.com/vegaprotocol/vega/pull/3263) - Fix incorrect context object in Liquidity Provisions
+- [#3283](https://github.com/vegaprotocol/vega/pull/3283) - Remove debug code
+- [#3198](https://github.com/vegaprotocol/vega/pull/3198) - chore: Add spell checking to build pipeline
+- [#3303](https://github.com/vegaprotocol/vega/pull/3303) - Reduce market depth updates when nothing changes
+- [#3310](https://github.com/vegaprotocol/vega/pull/3310) - Fees are no longer paid to inactive LPs
+- [#3305](https://github.com/vegaprotocol/vega/pull/3305) - Fix validation of governance proposal terms
+- [#3311](https://github.com/vegaprotocol/vega/pull/3311) - `targetStake` is now an unsigned integer
+- [#3313](https://github.com/vegaprotocol/vega/pull/3313) - Fix invalid account wrapping
+
 ## 0.33.0
 
 *2021-02-16*

CODEOWNERS

@@ -1,4 +1,4 @@
 # VEGA code owners - aka 'people who should probably be included in reviews on...'
 
-# GraphQL schema changes should be reviewd by Team Vega Console
+# GraphQL schema changes should be reviewed by Team Vega Console
 gateway/graphql/schema.graphql @edd @mattrussell36 

GETTING_STARTED.md

@@ -18,27 +18,27 @@ The following OS packages are required:
 
 ## Installing Golang
 
-**Required version: 1.14.4**
+**Required version: 1.16.2**
 
 Get Golang via OS package manager, or directly from from https://golang.org/dl/.
 See also the [Golang installation guide](https://golang.org/doc/install).
 Install it somewhere, then point "`$GOROOT`" at that location:
 
 ```bash
 # Add to $HOME/.bashrc:
-export GOROOT="/path/to/your/go1.14.4"
+export GOROOT="/path/to/your/go1.16.2"
 export PATH="$PATH:$GOROOT/bin"
 ```
 
 Ensure you have `go` and `gofmt`:
 
 ```bash
 $ which go gofmt
-/path/to/your/go1.14.4/bin/go
-/path/to/your/go1.14.4/bin/gofmt
+/path/to/your/go1.16.2/bin/go
+/path/to/your/go1.16.2/bin/gofmt
 
 $ go version
-go version go1.14.4 linux/amd64
+go version go1.16.2 linux/amd64
 ```
 
 ## Set up Go source path

Makefile

@@ -157,6 +157,10 @@ staticcheck: ## Run statick analysis checks
 buflint: ## Run buf lint
 	@./script/build.sh -a buflint
 
+.PHONY: misspell
+misspell: # Run go specific misspell checks
+	@./script/build.sh -a misspell
+
 .PHONY: semgrep
 semgrep: ## Run semgrep static analysis checks
 	@./script/build.sh -a semgrep

README.md

@@ -1,6 +1,6 @@
 # Vega
 
-Version 0.33.0.
+Version 0.34.0.
 
 A decentralised trading platform that allows pseudo-anonymous trading of derivatives on a blockchain.
 

REFACTORING.md

@@ -0,0 +1,45 @@
+# Refactoring
+
+This document is an attempt to get the team on the same page about the refactoring process we want to adopt.
+
+## Why?
+* Defined a goal to reach.
+  * Make the code easier to deal with.
+  * Ease the addition (or update) of features.
+
+## How?
+* Defined how we can reach that goal.
+  * Which techniques? More domain-oriented and less "algorithmic".
+* Defined critical code path for maximum impact.
+  * Identify the hottest path of code change.
+* Defined medium to share the knowledge.
+  * Create workshops on specific problems to find a solution, and be on the same page.
+  * Save our decisions into a file.
+
+## When?
+### Opportunistic refactoring
+It's done along the way.
+
+#### Preparatory refactoring
+Refactor just before we add a feature to a code base, to ease its addition.
+
+**Questions:**
+
+* What kind of code makes feature harder to add?
+
+#### Comprehension refactoring
+Refactor to make the code more understandable.
+
+**Questions:**
+
+* What's a code that is easier to understand?
+
+#### Clean-up refactoring
+Basically, the boy scout's rule.
+
+> Always leave the camp site cleaner than when you found it.
+
+**Questions:**
+
+* How to avoid overlapping with someone else?
+* Into the same PR as the one of the feature or a different one?

api/trading.go

@@ -322,7 +322,7 @@ func verifySignature(
 	validator, err := crypto.NewSignatureAlgorithm(crypto.Ed25519)
 	if err != nil {
 		if log != nil {
-			log.Error("unable to instanciate new algorithm", logging.Error(err))
+			log.Error("unable to instantiate new algorithm", logging.Error(err))
 		}
 		return err
 	}

api/trading_data.go

@@ -1747,7 +1747,7 @@ func (t *tradingDataService) updateNetInfo(ctx context.Context) {
 
 func (t *tradingDataService) getGenesisTimeAndChainID(ctx context.Context) error {
 	const refused = "connection refused"
-	// just lock in here, ideally we'ill come here only once, so not a big issue to lock
+	// just lock in here, ideally we'll come here only once, so not a big issue to lock
 	t.mu.Lock()
 	defer t.mu.Unlock()
 
@@ -2136,7 +2136,7 @@ func (t *tradingDataService) ObserveEventBus(
 		return apiError(codes.InvalidArgument, ErrMalformedRequest, err)
 	}
 
-	// now we will aggregaate filter out of the initial reuqest
+	// now we will aggregate filter out of the initial request
 	types, err := events.ProtoToInternal(req.Type...)
 	if err != nil {
 		return apiError(codes.InvalidArgument, ErrMalformedRequest, err)
@@ -2217,7 +2217,7 @@ func (t *tradingDataService) recvEventRequest(
 	select {
 	case <-readCtx.Done():
 		if err != nil {
-			// this means the client disconnectd
+			// this means the client disconnected
 			return nil, err
 		}
 		// this mean we timedout

assets/asset.go

@@ -8,7 +8,7 @@ import (
 )
 
 type isAsset interface {
-	// get informations about the asset itself
+	// get information about the asset itself
 	ProtoAsset() *types.Asset
 	// get the internal asset class
 	GetAssetClass() common.AssetClass