Skip to content

Commit 97426f2

Browse files
committed
Merge pull request #3523 from vegaprotocol/bugfix/3499-fix-panic
check for nil pointer on proposal submission before using fields
1 parent 70c0d61 commit 97426f2

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

api/trading.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,9 @@ func (s *tradingService) PrepareProposalSubmission(
227227
if err := req.Validate(); err != nil {
228228
return nil, apiError(codes.InvalidArgument, ErrMalformedRequest, err)
229229
}
230+
if req.Submission == nil {
231+
return nil, apiError(codes.InvalidArgument, ErrMalformedRequest, errors.New("missing submission"))
232+
}
230233
proposal, err := s.governanceService.PrepareProposal(ctx, req.Submission.Reference, req.Submission.Terms)
231234
if err != nil {
232235
return nil, apiError(codes.Internal, ErrPrepareProposal, err)

0 commit comments

Comments
 (0)