Cleanup some Lua Diagnostics issues

Author: veger

scripts/camera.lua

@@ -35,7 +35,7 @@ local Camera = {}
 --- @field screenshotIntervalRealtime number Interval (game ticks) between two screenshots for realtime transitions (calculated from frameRate)
 --- @field screenshotIntervalTransition number Interval (game ticks) between two screenshots during transitions (calculated from frameRate)
 --- @field speedGain number Amount (factor) that the timelapse movie should speed up compared to the game.
---- @field surfaceName string
+--- @field surfaceName SurfaceIdentification
 --- @field trackers Tracker.tracker[]
 --- @field chartTags table Chart tags used to render viewfinder boxes on the map
 --- @field width number

scripts/gui.lua

@@ -500,13 +500,13 @@ function GUI.onSelected(event)
     elseif event.element.name == "camera-surface" then
         playerSettings.cameras[playerSettings.guiPersist.selectedCamera].surfaceName = event.element.get_item(event
             .element
-            .selected_index)
+            .selected_index) --[[@as SurfaceIdentification]]
 
         GUI.createCameraTrackerList(playerSettings)
     elseif event.element.name == "tracker-surface" then
         playerSettings.trackers[playerSettings.guiPersist.selectedTracker].surfaceName = event.element.get_item(event
             .element
-            .selected_index)
+            .selected_index) --[[@as SurfaceIdentification]]
 
         GUI.createCameraTrackerList(playerSettings)
     end

scripts/main.lua

@@ -185,7 +185,7 @@ end
 ---@field minPos MapPosition.0
 ---@field maxPos MapPosition.0
 
----@param surface string
+---@param surface SurfaceIdentification
 ---@return BaseBBox|nil
 function Main.getBaseBBox(surface)
     local entities = game.surfaces[surface].find_entities_filtered { force = "player" }

scripts/tracker.lua

@@ -7,10 +7,10 @@ local Tracker = {}
 --- @field name string
 --- @field realtimeCamera boolean
 --- @field smooth boolean When true, smooth transitions are enabled/required for this tracker
---- @field surfaceName string
+--- @field surfaceName SurfaceIdentification
 --- @field type string
 --- @field untilBuild boolean
---- @field userCanEnable boolean When true, the user can enabled/disable the tracker, otherwise the tracker is controlled by TBLE
+--- @field userCanEnable boolean When true, the user can enabled/disable the tracker, otherwise the tracker is controlled by TLBE
 --- @field moveToNextTracker boolean|nil Disables the tracker after the cameras are processed (end of game tick)
 --- @field changeId integer Incremented on each position/size change of the tracker
 --- @field centerPos MapPosition.0|nil Center position of the tracker area (Calculated from minPos and maxPos)
@@ -87,7 +87,7 @@ end
 
 ---find the city block containing the position and relocate to that one
 ---@param tracker Tracker.tracker
----@param pos MapPosition.0|MapPosition.1
+---@param pos MapPosition
 function Tracker.focusCityBlock(tracker, pos)
     local cityBlock = tracker.cityBlock
     if cityBlock == nil then