Fix CI: route menus via ?type=<code>, not a dynamic [code] segment

`next.config.ts` sets `output: "export"` for production, which forbids
runtime-discovered dynamic route params — `generateStaticParams()`
must enumerate every path at build time and menu codes are defined in
the database. The `/[locale]/menu/[code]/page.tsx` route I added in
Phase 5 broke `next build`:

  Error: Page "/[locale]/menu/[code]" is missing "generateStaticParams()"
  so it cannot be used with "output: export" config.

Reverts to the existing query-param routing pattern: the menu code is
read from `?type=<code>`, generalising the legacy `?type=drinks` value
that existing QR codes already use. The home page links to
`/menu?type=<code>` per published menu. Drops the `[code]/page.tsx`
route entirely, the redirect side-effect, and the `useRouter` mock in
the test fixture.

Backwards compat: `?type=drinks` still resolves to the menu coded
`drinks` if present, falling back to `takeaway` for the legacy seed.

Author: vekexasia

web/src/app/[locale]/menu/MenuPageClient.test.tsx

@@ -6,12 +6,9 @@ import { render, screen, fireEvent } from '@testing-library/react';
 const loadRestaurantMock = vi.fn();
 const chatPanelMock = vi.fn(() => <div data-testid="chat-panel" />);
 
-const routerReplaceMock = vi.fn();
-
 vi.mock('next/navigation', () => ({
-  useParams: () => ({ locale: 'it', code: 'food' }),
+  useParams: () => ({ locale: 'it' }),
   useSearchParams: () => new URLSearchParams(''),
-  useRouter: () => ({ replace: routerReplaceMock, push: vi.fn(), prefetch: vi.fn(), back: vi.fn(), forward: vi.fn(), refresh: vi.fn() }),
 }));
 
 vi.mock('@/lib/i18n', () => ({

web/src/app/[locale]/menu/MenuPageClient.tsx

@@ -3,7 +3,7 @@
 import { useEffect, useState, useRef, useMemo } from "react";
 import { useTranslations } from "@/lib/i18n";
 import Image from "next/image";
-import { useParams, useRouter, useSearchParams } from "next/navigation";
+import { useParams, useSearchParams } from "next/navigation";
 import { useRestaurantStore, useCategories } from "@/stores/restaurantStore";
 import { MenuItemDetail } from "@/components/menu/MenuItemDetail";
 import { RestaurantInfoModal } from "@/components/menu/RestaurantInfoModal";
@@ -26,10 +26,12 @@ type MenuEntryWithDetails = MenuEntry & { description?: string; image?: string;
 export default function MenuPageClient() {
   const t = useTranslations();
   const params = useParams();
-  const router = useRouter();
   const searchParams = useSearchParams();
   const locale = params.locale as string;
-  const menuCodeParam = (params.code as string | undefined) ?? undefined;
+  // Menu code lives in the query string (?type=<code>) because `output: "export"`
+  // forbids runtime-discovered dynamic route params. The legacy `?type=drinks`
+  // value is honored as an alias for any 'drinks'- or 'takeaway'-coded menu.
+  const typeParam = searchParams.get("type") ?? undefined;
   const aiChatDevOverride = process.env.NODE_ENV !== 'production' && searchParams.get('aiChat') === '1';
   const hasChatWorker = Boolean(process.env.NEXT_PUBLIC_CHAT_WORKER_URL);
   const { data, isLoading, error, loadRestaurant } = useRestaurantStore();
@@ -86,31 +88,24 @@ export default function MenuPageClient() {
     sessionStorage.setItem('promo_seen', '1');
   };
 
-  // Resolve the current menu from the route param. Falls back to the first published menu
-  // when the user lands on /menu without a code (handled below by a redirect).
+  // Resolve the current menu from `?type=<code>`. Falls back to the first published menu
+  // when no `type` is in the query string. The legacy value `drinks` aliases to any menu
+  // coded `drinks` (or `takeaway` for old QR codes from before the rename).
   const publishedMenus = useMemo(
     () => (data?.menus ?? []).filter((m) => m.published),
     [data?.menus],
   );
   const currentMenu = useMemo(() => {
     if (!data) return undefined;
-    if (menuCodeParam) {
-      return data.menus.find((m) => m.code === menuCodeParam);
-    }
-    // Legacy /menu?type=drinks shim: pick a 'drinks' or 'takeaway'-coded menu if present.
-    const legacyType = searchParams.get("type");
-    if (legacyType === "drinks") {
-      return publishedMenus.find((m) => m.code === "drinks") || publishedMenus.find((m) => m.code === "takeaway");
+    if (typeParam) {
+      const direct = data.menus.find((m) => m.code === typeParam);
+      if (direct) return direct;
+      if (typeParam === "drinks") {
+        return publishedMenus.find((m) => m.code === "takeaway");
+      }
     }
     return publishedMenus[0];
-  }, [data, menuCodeParam, publishedMenus, searchParams]);
-
-  // If we're on /menu (no code) and the data is loaded, redirect to the resolved menu's URL.
-  useEffect(() => {
-    if (!data || menuCodeParam) return;
-    if (!currentMenu) return;
-    router.replace(`/${locale}/menu/${currentMenu.code}`);
-  }, [data, menuCodeParam, currentMenu, locale, router]);
+  }, [data, typeParam, publishedMenus]);
 
   const isVisible = (entry: MenuEntry) => {
     if (!currentMenu) return false;

web/src/app/[locale]/menu/[code]/page.tsx

@@ -179,7 +179,7 @@ export default function HomePage() {
               return (
                 <Link
                   key={menu.id}
-                  href={`/${locale}/menu/${menu.code}`}
+                  href={`/${locale}/menu?type=${menu.code}`}
                   data-locale-anchor={`home:menu-${menu.code}`}
                   className="bg-white rounded-2xl shadow-lg p-6 flex flex-col items-center justify-center aspect-square hover:shadow-xl transition-shadow"
                 >