feat: add internalCode (article code) to menu entries

vekexasia · vekexasia · commit 4973c20d98ef · 2026-05-15T15:36:55.000+02:00
- DB migration: ALTER TABLE menu_entries ADD COLUMN internal_code TEXT
- Schema: internalCode in CatalogEntrySchema, CreateEntryBody, UpdateEntryBody
- Backend: catalog builder maps internalCode; admin routes handle create/update
- Store: catalogToStore maps internalCode to MenuEntry
- List view: shows code in gray monospace top-right of item name
- Detail view: shows code alongside title (both image/no-image layouts)
- MenuItemDetail (bottom sheet): passes internalCode through
- Chat bubble (ItemCard): shows code next to item name in Tony cards
- Admin EditEntryPage: internalCode form field + live preview
- i18n: internalCodeLabel + internalCodePlaceholder in all 10 locales
- Fix pre-existing test TS errors (as never -&gt; as unknown as Type)
diff --git a/backend/drizzle/0009_internal_code.sql b/backend/drizzle/0009_internal_code.sql
@@ -0,0 +1,2 @@
+-- Add internal article code to menu entries (optional, kitchen/POS use)
+ALTER TABLE menu_entries ADD COLUMN internal_code TEXT;
diff --git a/backend/src/db/schema.ts b/backend/src/db/schema.ts
@@ -111,6 +111,7 @@ export const menuEntries = sqliteTable(
       .references(() => menuCategories.id, { onDelete: 'cascade' }),
     name: text('name').notNull(),
     description: text('description'),
+    internalCode: text('internal_code'),
     // Prices stored as integer cents (€12.50 → 1250) to avoid IEEE 754 float drift.
     // Divide by 100 when returning to API clients.
     price: integer('price').notNull(),
diff --git a/backend/src/routes/admin.ts b/backend/src/routes/admin.ts
@@ -459,6 +459,7 @@ admin.post('/categories/:categoryId/entries', ...base, async (c) => {
       hidden: body.hidden ?? false,
       allergens: body.allergens || null,
       i18n: body.i18n || null,
+      internalCode: body.internalCode ?? null,
     });
 
   if (body.menuIds && body.menuIds.length > 0) {
@@ -488,6 +489,7 @@ admin.put('/entries/:entryId', ...base, async (c) => {
   if (body.priceUnit !== undefined) updates.priceUnit = body.priceUnit;
   if (body.i18n !== undefined) updates.i18n = body.i18n;
   if (body.hidden !== undefined) updates.hidden = body.hidden;
+  if (body.internalCode !== undefined) updates.internalCode = body.internalCode ?? null;
 
   const db = c.get('db');
   await db
diff --git a/backend/src/routes/catalog.ts b/backend/src/routes/catalog.ts
@@ -404,6 +404,7 @@ export async function buildCatalogFromDb(
         id: e.id,
         name: e.name,
         description: e.description,
+        internalCode: e.internalCode ?? null,
         price: e.price / 100,
         priceUnit: e.priceUnit,
         imageUrl: e.imageUrl,
diff --git a/packages/schemas/src/admin.ts b/packages/schemas/src/admin.ts
@@ -59,6 +59,7 @@ export const CreateEntryBodySchema = z.object({
   menuIds: z.array(z.string()).optional(),
   labelIds: z.array(z.string()).optional(),
   hidden: z.boolean().optional(),
+  internalCode: z.string().nullable().optional(),
 });
 export type CreateEntryBody = z.infer<typeof CreateEntryBodySchema>;
 
@@ -74,6 +75,7 @@ export const UpdateEntryBodySchema = z.object({
   menuIds: z.array(z.string()).optional(),
   labelIds: z.array(z.string()).optional(),
   hidden: z.boolean().optional(),
+  internalCode: z.string().nullable().optional(),
 });
 export type UpdateEntryBody = z.infer<typeof UpdateEntryBodySchema>;
 
diff --git a/packages/schemas/src/catalog.ts b/packages/schemas/src/catalog.ts
@@ -20,6 +20,7 @@ export const CatalogEntrySchema = z.object({
   id: z.string(),
   name: z.string(),
   description: z.string().nullable(),
+  internalCode: z.string().nullable().optional(),
   price: z.number(),
   priceUnit: z.string().nullable(),
   imageUrl: z.string().nullable(),
diff --git a/web/messages/de.json b/web/messages/de.json
@@ -234,6 +234,8 @@
     "entries.modal.descPrimary": "Beschreibung ({locale} - Hauptsprache)",
     "entries.modal.descPlaceholder": "Item description...",
     "entries.modal.priceLabel": "Price (€)",
+    "entries.modal.internalCodeLabel": "Article code",
+    "entries.modal.internalCodePlaceholder": "e.g. 042",
     "entries.modal.unitLabel": "Unit",
     "entries.modal.unitPlaceholder": "kg, l...",
     "entries.modal.outOfStock": "Out of stock",
diff --git a/web/messages/en.json b/web/messages/en.json
@@ -234,6 +234,8 @@
     "entries.modal.descPrimary": "Description ({locale} - primary)",
     "entries.modal.descPlaceholder": "Item description...",
     "entries.modal.priceLabel": "Price (€)",
+    "entries.modal.internalCodeLabel": "Article code",
+    "entries.modal.internalCodePlaceholder": "e.g. 042",
     "entries.modal.unitLabel": "Unit",
     "entries.modal.unitPlaceholder": "kg, l...",
     "entries.modal.outOfStock": "Out of stock",
diff --git a/web/messages/es.json b/web/messages/es.json
@@ -234,6 +234,8 @@
     "entries.modal.descPrimary": "Descripción ({locale} - principal)",
     "entries.modal.descPlaceholder": "Item description...",
     "entries.modal.priceLabel": "Price (€)",
+    "entries.modal.internalCodeLabel": "Article code",
+    "entries.modal.internalCodePlaceholder": "e.g. 042",
     "entries.modal.unitLabel": "Unit",
     "entries.modal.unitPlaceholder": "kg, l...",
     "entries.modal.outOfStock": "Out of stock",
diff --git a/web/messages/fr.json b/web/messages/fr.json
@@ -234,6 +234,8 @@
     "entries.modal.descPrimary": "Description ({locale} - principal)",
     "entries.modal.descPlaceholder": "Item description...",
     "entries.modal.priceLabel": "Price (€)",
+    "entries.modal.internalCodeLabel": "Article code",
+    "entries.modal.internalCodePlaceholder": "e.g. 042",
     "entries.modal.unitLabel": "Unit",
     "entries.modal.unitPlaceholder": "kg, l...",
     "entries.modal.outOfStock": "Out of stock",
diff --git a/web/messages/hu.json b/web/messages/hu.json
@@ -234,6 +234,8 @@
     "entries.modal.descPrimary": "Description ({locale} - primary)",
     "entries.modal.descPlaceholder": "Item description...",
     "entries.modal.priceLabel": "Price (€)",
+    "entries.modal.internalCodeLabel": "Article code",
+    "entries.modal.internalCodePlaceholder": "e.g. 042",
     "entries.modal.unitLabel": "Unit",
     "entries.modal.unitPlaceholder": "kg, l...",
     "entries.modal.outOfStock": "Out of stock",
diff --git a/web/messages/it.json b/web/messages/it.json
@@ -234,6 +234,8 @@
     "entries.modal.descPrimary": "Descrizione ({locale} - principale)",
     "entries.modal.descPlaceholder": "Descrizione del piatto...",
     "entries.modal.priceLabel": "Prezzo (€)",
+    "entries.modal.internalCodeLabel": "Codice articolo",
+    "entries.modal.internalCodePlaceholder": "es. 042",
     "entries.modal.unitLabel": "Unità",
     "entries.modal.unitPlaceholder": "kg, l...",
     "entries.modal.outOfStock": "Esaurito",
diff --git a/web/messages/nl.json b/web/messages/nl.json
@@ -234,6 +234,8 @@
     "entries.modal.descPrimary": "Beschrijving ({locale} - primair)",
     "entries.modal.descPlaceholder": "Item description...",
     "entries.modal.priceLabel": "Price (€)",
+    "entries.modal.internalCodeLabel": "Article code",
+    "entries.modal.internalCodePlaceholder": "e.g. 042",
     "entries.modal.unitLabel": "Unit",
     "entries.modal.unitPlaceholder": "kg, l...",
     "entries.modal.outOfStock": "Out of stock",
diff --git a/web/messages/pt.json b/web/messages/pt.json
@@ -234,6 +234,8 @@
     "entries.modal.descPrimary": "Descrição ({locale} - principal)",
     "entries.modal.descPlaceholder": "Item description...",
     "entries.modal.priceLabel": "Price (€)",
+    "entries.modal.internalCodeLabel": "Article code",
+    "entries.modal.internalCodePlaceholder": "e.g. 042",
     "entries.modal.unitLabel": "Unit",
     "entries.modal.unitPlaceholder": "kg, l...",
     "entries.modal.outOfStock": "Out of stock",
diff --git a/web/messages/ru.json b/web/messages/ru.json
@@ -234,6 +234,8 @@
     "entries.modal.descPrimary": "Описание ({locale} — основной)",
     "entries.modal.descPlaceholder": "Item description...",
     "entries.modal.priceLabel": "Price (€)",
+    "entries.modal.internalCodeLabel": "Article code",
+    "entries.modal.internalCodePlaceholder": "e.g. 042",
     "entries.modal.unitLabel": "Unit",
     "entries.modal.unitPlaceholder": "kg, l...",
     "entries.modal.outOfStock": "Out of stock",
diff --git a/web/messages/vec.json b/web/messages/vec.json
@@ -234,6 +234,8 @@
     "entries.modal.descPrimary": "Descrission ({locale} - prinsipale)",
     "entries.modal.descPlaceholder": "Item description...",
     "entries.modal.priceLabel": "Price (€)",
+    "entries.modal.internalCodeLabel": "Article code",
+    "entries.modal.internalCodePlaceholder": "e.g. 042",
     "entries.modal.unitLabel": "Unit",
     "entries.modal.unitPlaceholder": "kg, l...",
     "entries.modal.outOfStock": "Out of stock",
diff --git a/web/src/app/[locale]/menu/MenuPageClient.test.tsx b/web/src/app/[locale]/menu/MenuPageClient.test.tsx
@@ -41,6 +41,7 @@ vi.mock('@/components/menu/RestaurantInfoModal', () => ({ RestaurantInfoModal: (
 vi.mock('@/components/menu/PromotionPopup', () => ({ PromotionPopup: () => null }));
 
 import { useRestaurantStore } from '@/stores/restaurantStore';
+import type { RestaurantData } from '@/lib/types';
 import { useChatActionsStore } from '@/stores/chatActionsStore';
 import { useSelectionStore, SELECTION_STORAGE_KEY } from '@/stores/selectionStore';
 import MenuPageClient from './MenuPageClient';
@@ -92,7 +93,7 @@ const menuData = {
       ],
     },
   ],
-} as never;
+} as unknown as RestaurantData;
 
 describe('MenuPageClient', () => {
   it('renders the loading spinner when isLoading is true', () => {
@@ -187,7 +188,7 @@ describe('MenuPageClient', () => {
       updatedAt: Date.now(),
       lines: [{ entryId: 'entry-bruschetta', quantity: 2, addedAt: Date.now() }],
     }));
-    useRestaurantStore.setState({ data: { ...menuData, features: { aiChat: true, selection: true } }, isLoading: false } as never);
+    useRestaurantStore.setState({ data: { ...menuData, features: { aiChat: true, selection: true } } as unknown as RestaurantData, isLoading: false });
 
     render(<MenuPageClient />);
 
diff --git a/web/src/app/[locale]/menu/MenuPageClient.tsx b/web/src/app/[locale]/menu/MenuPageClient.tsx
@@ -363,6 +363,7 @@ export default function MenuPageClient() {
                         priceUnit: entryWithDesc.priceUnit,
                         image: entryWithDesc.image,
                         outOfStock: entryWithDesc.outOfStock,
+                        internalCode: entryWithDesc.internalCode,
                         labels: entry.labelIds?.length
                           ? allLabels.filter(l => entry.labelIds!.includes(l.id)).map(l => resolveLabel(l, locale))
                           : undefined,
diff --git a/web/src/components/admin/pages/EditEntryPage.tsx b/web/src/components/admin/pages/EditEntryPage.tsx
@@ -56,6 +56,7 @@ interface MenuEntry {
   menuIds: string[];
   labelIds: string[];
   hidden: boolean;
+  internalCode?: string;
 }
 
 function RichTextEditor({
@@ -208,6 +209,7 @@ export default function EditEntryPage() {
         menuIds: defaultMenuIds,
         labelIds: [],
         hidden: false,
+        internalCode: undefined,
       });
       setActiveTranslationTab(primaryLocale);
       setLoading(false);
@@ -250,6 +252,7 @@ export default function EditEntryPage() {
       menuIds: cached.menuIds,
       labelIds: (cached.labelIds || []) as string[],
       hidden: cached.hidden,
+      internalCode: cached.internalCode ?? undefined,
     });
     setActiveTranslationTab(primaryLocale);
     setLoading(false);
@@ -345,6 +348,7 @@ export default function EditEntryPage() {
           menuIds: editingEntry.menuIds,
           labelIds: editingEntry.labelIds,
           hidden: editingEntry.hidden,
+          internalCode: editingEntry.internalCode || null,
         });
       } else {
         await updateEntry(editingEntry.id, {
@@ -359,6 +363,7 @@ export default function EditEntryPage() {
           menuIds: editingEntry.menuIds,
           labelIds: editingEntry.labelIds,
           hidden: editingEntry.hidden,
+          internalCode: editingEntry.internalCode || null,
         });
       }
       navigateBackAfterMutation();
@@ -598,6 +603,22 @@ export default function EditEntryPage() {
             </TranslationTabs>
           </div>
 
+          {/* Internal code */}
+          <div>
+            <label className="block text-sm font-medium text-gray-700 mb-1">
+              {t("entries.modal.internalCodeLabel")}
+            </label>
+            <input
+              type="text"
+              value={editingEntry.internalCode || ""}
+              onChange={(e) =>
+                setEditingEntry({ ...editingEntry, internalCode: e.target.value || undefined })
+              }
+              className="w-full px-3 py-2 border rounded-lg font-mono text-sm"
+              placeholder={t("entries.modal.internalCodePlaceholder")}
+            />
+          </div>
+
           {/* Price */}
           <div className="flex gap-4">
             <div className="flex-1">
@@ -885,6 +906,7 @@ export default function EditEntryPage() {
             allergens: editingEntry.allergens,
             outOfStock: editingEntry.outOfStock,
             containsFrozenIngredient: editingEntry.frozen,
+            internalCode: editingEntry.internalCode,
             labels: previewLabels,
           };
           return (
diff --git a/web/src/components/chat/ChatBubble.tsx b/web/src/components/chat/ChatBubble.tsx
@@ -77,12 +77,17 @@ function ItemCard({ itemId, locale, onClick }: { itemId: string; locale: string;
         </div>
       )}
       <div className="flex-1 min-w-0">
-        <p className="font-semibold text-gray-800 text-xs leading-tight">
-          <span className="block">{name.primary}</span>
-          {name.secondary && (
-            <span className="mt-0.5 block text-[10px] font-medium text-gray-500">
-              {name.secondary}
-            </span>
+        <p className="font-semibold text-gray-800 text-xs leading-tight flex items-start justify-between gap-1">
+          <span>
+            <span className="block">{name.primary}</span>
+            {name.secondary && (
+              <span className="mt-0.5 block text-[10px] font-medium text-gray-500">
+                {name.secondary}
+              </span>
+            )}
+          </span>
+          {entry.internalCode && (
+            <span className="font-mono text-[10px] font-normal text-gray-400 shrink-0">{entry.internalCode}</span>
           )}
         </p>
         {desc && <p className="text-[11px] text-gray-500 mt-0.5 line-clamp-1">{desc}</p>}
diff --git a/web/src/components/menu/MenuItemDetail.test.tsx b/web/src/components/menu/MenuItemDetail.test.tsx
@@ -2,6 +2,7 @@ import { beforeEach, describe, expect, it, vi } from 'vitest';
 import { fireEvent, render, screen } from '@testing-library/react';
 import { MenuItemDetail } from './MenuItemDetail';
 import { useRestaurantStore } from '@/stores/restaurantStore';
+import type { MenuEntry } from '@/lib/types';
 import { useSelectionStore } from '@/stores/selectionStore';
 
 vi.mock('@/lib/i18n', () => ({
@@ -33,11 +34,11 @@ const item = {
   menuIds: ['menu-food'],
   hidden: false,
   allergens: [],
-} as never;
+} as unknown as MenuEntry;
 
 function resetStores() {
   localStorage.clear();
-  useRestaurantStore.setState({ data: { id: 'restaurant-1' } } as never);
+  useRestaurantStore.setState({ data: { id: 'restaurant-1' } as unknown as import('@/lib/types').RestaurantData });
   useSelectionStore.setState({ restaurantId: null, updatedAt: 0, lines: [] });
   useSelectionStore.getState().initialize('restaurant-1');
 }
@@ -74,7 +75,7 @@ describe('MenuItemDetail selection controls', () => {
   });
 
   it('hides selection controls for out of stock items', () => {
-    render(<MenuItemDetail item={{ ...item, outOfStock: true } as never} onClose={vi.fn()} locale="it" selectionEnabled />);
+    render(<MenuItemDetail item={{ ...item, outOfStock: true } as unknown as MenuEntry} onClose={vi.fn()} locale="it" selectionEnabled />);
 
     expect(screen.queryByRole('button', { name: 'Add to selection' })).not.toBeInTheDocument();
   });
diff --git a/web/src/components/menu/MenuItemDetail.tsx b/web/src/components/menu/MenuItemDetail.tsx
@@ -96,6 +96,7 @@ export function MenuItemDetail({ item, onClose, locale, hidePrice, selectionEnab
                   : undefined,
                 outOfStock: item.outOfStock,
                 containsFrozenIngredient: item.frozen,
+                internalCode: item.internalCode,
               }}
               hidePrice={hidePrice}
               allergyWarning={t('allergyWarning')}
diff --git a/web/src/components/menu/views/MenuItemDetailView.tsx b/web/src/components/menu/views/MenuItemDetailView.tsx
@@ -75,7 +75,12 @@ export function MenuItemDetailView({ item, hidePrice, allergyWarning, frozenWarn
         {item.image ? (
           <div className="flex justify-between items-start gap-4 mb-3">
             <h2 className="text-2xl font-bold text-gray-800 flex-1">
-              <span className="block">{item.name}</span>
+              <span className="flex items-start justify-between gap-2">
+                <span>{item.name}</span>
+                {item.internalCode && (
+                  <span className="font-mono text-sm font-normal text-gray-400 shrink-0 mt-1">{item.internalCode}</span>
+                )}
+              </span>
               {item.nameSecondary && (
                 <span className="mt-1 block text-sm font-medium text-gray-500">{item.nameSecondary}</span>
               )}
@@ -89,7 +94,12 @@ export function MenuItemDetailView({ item, hidePrice, allergyWarning, frozenWarn
         ) : (
           <>
             <h2 className="text-2xl font-bold text-gray-800 mb-3">
-              <span className="block">{item.name}</span>
+              <span className="flex items-start justify-between gap-2">
+                <span>{item.name}</span>
+                {item.internalCode && (
+                  <span className="font-mono text-sm font-normal text-gray-400 shrink-0 mt-1">{item.internalCode}</span>
+                )}
+              </span>
               {item.nameSecondary && (
                 <span className="mt-1 block text-sm font-medium text-gray-500">{item.nameSecondary}</span>
               )}
diff --git a/web/src/components/menu/views/MenuItemListView.tsx b/web/src/components/menu/views/MenuItemListView.tsx
@@ -15,6 +15,8 @@ import { labelColorStyle } from "@/lib/label-colors";
 export interface MenuItemView {
   /** Primary display name (already localized). */
   name: string;
+  /** Internal article code (shown only when present). */
+  internalCode?: string | null;
   /** Secondary display name (e.g. fallback locale). */
   nameSecondary?: string | null;
   /** Description (already localized). */
@@ -58,12 +60,17 @@ export function MenuItemListView({ item, outOfStockLabel, onClick }: MenuItemLis
       } ${interactive ? "cursor-pointer hover:shadow-md transition-all" : ""}`}
     >
       <div className="flex-1 min-w-0">
-        <h4 className="font-semibold text-gray-800">
-          <span className="block">{item.name}</span>
-          {item.nameSecondary && (
-            <span className="mt-0.5 block text-xs font-medium text-gray-500">
-              {item.nameSecondary}
-            </span>
+        <h4 className="font-semibold text-gray-800 flex items-start justify-between gap-2">
+          <span>
+            <span className="block">{item.name}</span>
+            {item.nameSecondary && (
+              <span className="mt-0.5 block text-xs font-medium text-gray-500">
+                {item.nameSecondary}
+              </span>
+            )}
+          </span>
+          {item.internalCode && (
+            <span className="font-mono text-xs font-normal text-gray-400 shrink-0 mt-0.5">{item.internalCode}</span>
           )}
         </h4>
         {item.labels && item.labels.length > 0 && (
diff --git a/web/src/stores/restaurantStore.ts b/web/src/stores/restaurantStore.ts
@@ -176,6 +176,7 @@ function catalogToStore(catalog: CatalogResponse) {
       menuIds: e.menuIds,
       labelIds: e.labelIds ?? [],
       hidden: e.hidden,
+      internalCode: e.internalCode ?? undefined,
       overriddenVariantPaths: (e.metadata?.variantRefs as string[]) || [],
       overriddenExtraPaths: (e.metadata?.extraRefs as string[]) || [],
       i18n: e.i18n as Record<string, Record<string, string>> | undefined,

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+-- Add internal article code to menu entries (optional, kitchen/POS use)`
	`2`	`+ALTER TABLE menu_entries ADD COLUMN internal_code TEXT;`