Fix InterfaceDirRelative at top-level

Relates to #1133. This parameter, if provided at the package-level config or above,
could cause mockery to crash. This happened because mockery was parsing the config
templates for the package-level config even though none of these values were used.
The solution was simple enough: just don't parse package-level configs.

Author: LandonTClipp

.mockery_matryer.yml

@@ -1,7 +1,6 @@
 template: matryer
 structname: "Moq{{.InterfaceName}}"
 filename: "mocks_matryer_{{.SrcPackageName}}_test.go"
-
 all: true
 template-data:
   skip-ensure: False

.mockery_testify.yml

@@ -139,4 +139,8 @@ packages:
         configs:
           - structname: FunServerWithDifferentFile
           - structname: AnotherFunServerWithDifferentFile
-  github.com/vektra/mockery/v3/internal/fixtures/constraint_ifaces:
+  github.com/vektra/mockery/v3/internal/fixtures/constraint_ifaces:
+  github.com/vektra/mockery/v3/internal/fixtures/interface_dir_relative:
+    config:
+      dir: '{{.InterfaceDir}}/{{  replaceAll "internal/" "" (index (splitAfterN "/" 2 .InterfaceDirRelative) 0) }}/mocks/{{index (splitAfterN "/" 2 .InterfaceDirRelative) 1}}'
+      filename: "mocks_{{.InterfaceName}}.go"

config/config.go

@@ -653,7 +653,13 @@ func (c *Config) ParseTemplates(
 	workingDir = filepath.ToSlash(workingDir)
 	ifaceFilePath = filepath.ToSlash(filepath.Clean(ifaceFilePath))
 	interfaceDirPath := filepath.ToSlash(filepath.Dir(ifaceFilePath))
-	interfaceDirRelativePath, err := filepath.Rel(filepath.FromSlash(workingDir), filepath.FromSlash(interfaceDirPath))
+	configPathAbs, err := filepath.Abs(*c.ConfigFile)
+	if err != nil {
+		return fmt.Errorf("getting absolute path of config file: %w", err)
+	}
+	configPathDir := filepath.ToSlash(filepath.Dir(configPathAbs))
+
+	interfaceDirRelativePath, err := filepath.Rel(filepath.FromSlash(configPathDir), filepath.FromSlash(interfaceDirPath))
 
 	var interfaceDirRelative string
 
@@ -663,6 +669,7 @@ func (c *Config) ParseTemplates(
 			Str("working-dir", workingDir).
 			Str("interfaceDirPath", interfaceDirPath).
 			Str("interface-dir-relative-path", interfaceDirRelativePath).
+			Str("iface-file-path", ifaceFilePath).
 			Msg("can't make path relative to working dir, setting to './'")
 		interfaceDirRelative = "."
 	} else {
@@ -672,7 +679,7 @@ func (c *Config) ParseTemplates(
 			Str("interfaceDirPath", interfaceDirPath).
 			Str("interface-dir-relative-path", interfaceDirRelativePath).
 			Msg("found relative path")
-		interfaceDirRelative = interfaceDirRelativePath
+		interfaceDirRelative = interfaceDirRelativePath + "/"
 	}
 
 	// data is the struct sent to the template parser
@@ -723,6 +730,7 @@ func (c *Config) ParseTemplates(
 			}
 			var parsedBuffer bytes.Buffer
 
+			log.Debug().Str("template-data", fmt.Sprintf("%+v", data)).Msg("executing template with data")
 			if err := attributeTempl.Execute(&parsedBuffer, data); err != nil {
 				return fmt.Errorf("failed to execute %s template: %w", name, err)
 			}

internal/cmd/mockery.go

@@ -304,18 +304,20 @@ func (r *RootApp) Run() error {
 					ifaceConfig.InPackage,
 					*ifaceConfig.RequireTemplateSchemaExists,
 				)
-				log.Debug().Str("file-path", filePath).Msg("creating new interface collection")
+				ifaceLog.Debug().Str("file-path", filePath).Msg("creating new interface collection")
 			}
+			ifaceWithTypes := internal.NewInterface(
+				iface.Name,
+				iface.TypeSpec,
+				iface.GenDecl,
+				iface.FilePath,
+				iface.FileSyntax,
+				iface.Pkg,
+				ifaceConfig)
+			ifaceLog.Debug().Str("ifaceWithTypes", fmt.Sprintf("%+v", ifaceWithTypes)).Msg("created iface with types")
 			if err := mockFileToInterfaces[filePath].Append(
 				ctx,
-				internal.NewInterface(
-					iface.Name,
-					iface.TypeSpec,
-					iface.GenDecl,
-					iface.FilePath,
-					iface.FileSyntax,
-					iface.Pkg,
-					ifaceConfig),
+				ifaceWithTypes,
 			); err != nil {
 				return err
 			}
@@ -326,15 +328,10 @@ func (r *RootApp) Run() error {
 		fileLog := log.With().Str("file", outFilePath).Logger()
 		fileCtx := fileLog.WithContext(ctx)
 
-		fileLog.Debug().Int("interfaces-in-file-len", len(collection.interfaces)).Msgf("%v", collection)
-
 		packageConfig, err := r.Config.GetPackageConfig(fileCtx, collection.config.SrcPkgPath)
 		if err != nil {
 			return err
 		}
-		if err := packageConfig.Config.ParseTemplates(ctx, "", "", collection.srcPkg); err != nil {
-			return err
-		}
 
 		interfacesInFileDir := filepath.ToSlash(filepath.Dir(collection.config.OutFilePath))
 		generator, err := pkg.NewTemplateGenerator(

internal/fixtures/directive_comments/mocks_matryer_directive_comments_test.go

@@ -0,0 +1,5 @@
+package interfacedirrelative
+
+type Foo interface {
+	Bar() string
+}

internal/fixtures/directive_comments/mocks_testify_directive_comments_test.go

@@ -0,0 +1,15 @@
+package interfacedirrelative
+
+import (
+	"testing"
+
+	mocks "github.com/vektra/mockery/v3/internal/fixtures/interface_dir_relative/mocks/fixtures/interface_dir_relative"
+)
+
+func TestFoo(t *testing.T) {
+	m := mocks.NewMockFoo(t)
+	m.EXPECT().Bar().Return("foo")
+	if m.Bar() != "foo" {
+		t.Errorf("expected foo but got %s", m.Bar())
+	}
+}