perf: better string concatenation

nolanemirot · nolanemirot · commit 2e2aab6f2e5d · 2026-04-14T11:16:37.000-07:00
diff --git a/pkg/util/csi/volume_snapshot.go b/pkg/util/csi/volume_snapshot.go
@@ -709,8 +709,7 @@ func DiagnoseVS(vs *snapshotv1api.VolumeSnapshot, events *corev1api.EventList) s
 	}
 
 	var diag strings.Builder
-	baseString := fmt.Sprintf("VS %s/%s, bind to %s, readyToUse %v, errMessage %s\n", vs.Namespace, vs.Name, vscName, readyToUse, errMessage)
-	diag.WriteString(baseString)
+	_, _ = fmt.Fprintf(&diag, "VS %s/%s, bind to %s, readyToUse %v, errMessage %s\n", vs.Namespace, vs.Name, vscName, readyToUse, errMessage)
 
 	if events != nil {
 		for _, e := range events.Items {

Original file line number	Diff line number	Diff line change
`@@ -709,8 +709,7 @@ func DiagnoseVS(vs snapshotv1api.VolumeSnapshot, events corev1api.EventList) s`
`709`	`709`	`}`
`710`	`710`
`711`	`711`	`var diag strings.Builder`
`712`		`- baseString := fmt.Sprintf("VS %s/%s, bind to %s, readyToUse %v, errMessage %s\n", vs.Namespace, vs.Name, vscName, readyToUse, errMessage)`
`713`		`- diag.WriteString(baseString)`
	`712`	`+ _, _ = fmt.Fprintf(&diag, "VS %s/%s, bind to %s, readyToUse %v, errMessage %s\n", vs.Namespace, vs.Name, vscName, readyToUse, errMessage)`
`714`	`713`
`715`	`714`	`if events != nil {`
`716`	`715`	`for _, e := range events.Items {`