Skip to content

Commit 4d23571

Browse files
fix: add changelog and nolint explanation for CI
Add missing changelog entry for PR 9654 (fixes Changelog Check). Add explanation to //nolint:errcheck directives (fixes nolintlint). Signed-off-by: Pierluigi Lenoci <pierluigilenoci@gmail.com>
1 parent 0fa1910 commit 4d23571

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fix issue #9658, Honor --stderrthreshold when --logtostderr is enabled

pkg/cmd/velero/velero.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,8 +135,8 @@ operations can also be performed as 'velero backup get' and 'velero schedule cre
135135
// Opt into the new klog behavior so that -stderrthreshold is honored even
136136
// when -logtostderr=true (the default).
137137
// Ref: kubernetes/klog#212, kubernetes/klog#432
138-
flag.CommandLine.Set("legacy_stderr_threshold_behavior", "false") //nolint:errcheck
139-
flag.CommandLine.Set("stderrthreshold", "INFO") //nolint:errcheck
138+
flag.CommandLine.Set("legacy_stderr_threshold_behavior", "false") //nolint:errcheck // flag is registered by klog.InitFlags above
139+
flag.CommandLine.Set("stderrthreshold", "INFO") //nolint:errcheck // flag is registered by klog.InitFlags above
140140
c.PersistentFlags().AddGoFlagSet(flag.CommandLine)
141141

142142
return c

0 commit comments

Comments
 (0)