Skip to content

Commit b182707

Browse files
committed
Merge branch 'main' into cbt-bitmap-implementation
2 parents 3ef3089 + 1160ae2 commit b182707

4 files changed

Lines changed: 151 additions & 0 deletions

File tree

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fix issue #9709, add interfaces for CBT service and CBT bitmap

pkg/cbtservice/service.go

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
/*
2+
Copyright The Velero Contributors.
3+
4+
Licensed under the Apache License, Version 2.0 (the "License");
5+
you may not use this file except in compliance with the License.
6+
You may obtain a copy of the License at
7+
8+
http://www.apache.org/licenses/LICENSE-2.0
9+
10+
Unless required by applicable law or agreed to in writing, software
11+
distributed under the License is distributed on an "AS IS" BASIS,
12+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
See the License for the specific language governing permissions and
14+
limitations under the License.
15+
*/
16+
17+
package cbtservice
18+
19+
import "context"
20+
21+
// Range defines the range of a change
22+
type Range struct {
23+
Offset int64
24+
Length int64
25+
}
26+
27+
// SourceInfo is the information provided to the uploader, the uploader calls CBT service with this information
28+
type SourceInfo struct {
29+
// Snapshot is the identifier of the current snapshot
30+
Snapshot string
31+
32+
// ChangeID is the identifier associated to the current snapshot that is used as changeID for following backups
33+
ChangeID string
34+
35+
// VolumeID is the identifier uniquely identifier a volume in the storage to which the CBT is associated
36+
VolumeID string
37+
}
38+
39+
// Service defines the methods for CBT service which could be implemented by Kubernetes SnapshotMetadataService or other customized services
40+
type Service interface {
41+
// GetAllocatedBlocks enumerates the allocated blocks of the snapshot and call the record callback
42+
GetAllocatedBlocks(ctx context.Context, snapshot string, record func([]Range) error) error
43+
44+
// GetChangedBlocks enumerates the changed blocks of the snapshot since PIT of changeID and call the record callback
45+
GetChangedBlocks(ctx context.Context, snapshot string, changeID string, record func([]Range) error) error
46+
}

pkg/uploader/cbt/bitmap.go

Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
1+
/*
2+
Copyright The Velero Contributors.
3+
4+
Licensed under the Apache License, Version 2.0 (the "License");
5+
you may not use this file except in compliance with the License.
6+
You may obtain a copy of the License at
7+
8+
http://www.apache.org/licenses/LICENSE-2.0
9+
10+
Unless required by applicable law or agreed to in writing, software
11+
distributed under the License is distributed on an "AS IS" BASIS,
12+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
See the License for the specific language governing permissions and
14+
limitations under the License.
15+
*/
16+
17+
package cbt
18+
19+
import "github.com/vmware-tanzu/velero/pkg/cbtservice"
20+
21+
// Bitmap defines the methods to store and iterate the CBT bitmap
22+
type Bitmap interface {
23+
// Set sets bits within the provided range
24+
Set(cbtservice.Range)
25+
26+
// SetFull sets all bits to the bitmap
27+
SetFull()
28+
29+
// Snapshot returns snapshot of the bitmap
30+
SourceID() string
31+
32+
// ChangeID returns the changeID of the bitmap
33+
ChangeID() string
34+
35+
// Iterator returns the iterator for the CBT Bitmap
36+
Iterator() Iterator
37+
}
38+
39+
// Iterator defines the methods to iterate the CBT bitmap and query the associated information
40+
type Iterator interface {
41+
// ChangeID returns the changeID of the bitmap
42+
ChangeID() string
43+
44+
// Snapshot returns snapshot of the bitmap
45+
Snapshot() string
46+
47+
// BlockSize returns the granularity of the bitmap
48+
BlockSize() int
49+
50+
// Count returns the toal number of count in the bitmap
51+
Count() uint64
52+
53+
// Next returns the offset of the next set block and whether it comes to the end of the iteration
54+
Next() (int64, bool)
55+
}

pkg/uploader/cbt/set.go

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
/*
2+
Copyright The Velero Contributors.
3+
4+
Licensed under the Apache License, Version 2.0 (the "License");
5+
you may not use this file except in compliance with the License.
6+
You may obtain a copy of the License at
7+
8+
http://www.apache.org/licenses/LICENSE-2.0
9+
10+
Unless required by applicable law or agreed to in writing, software
11+
distributed under the License is distributed on an "AS IS" BASIS,
12+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
See the License for the specific language governing permissions and
14+
limitations under the License.
15+
*/
16+
17+
package cbt
18+
19+
import (
20+
"context"
21+
22+
"github.com/vmware-tanzu/velero/pkg/cbtservice"
23+
)
24+
25+
// SetBitmapOrFull translates the allocated/changed blocks from CBT service to the given bitmap or set the bitmap to full when error happens
26+
func SetBitmapOrFull(ctx context.Context, service cbtservice.Service, bitmap Bitmap) error {
27+
var err error
28+
if bitmap.ChangeID() == "" {
29+
err = setFromAllocatedBlocks(ctx, service, bitmap)
30+
} else {
31+
err = setFromChangedBlocks(ctx, service, bitmap)
32+
}
33+
34+
if err != nil {
35+
bitmap.SetFull()
36+
}
37+
38+
return err
39+
}
40+
41+
// TODO implement in following PRs
42+
func setFromAllocatedBlocks(_ context.Context, _ cbtservice.Service, _ Bitmap) error {
43+
return nil
44+
}
45+
46+
// TODO implement in following PRs
47+
func setFromChangedBlocks(_ context.Context, _ cbtservice.Service, _ Bitmap) error {
48+
return nil
49+
}

0 commit comments

Comments
 (0)