Skip to content

Commit d32f63a

Browse files
committed
Simplify .gitconfig mount - use existing repository mount
Removed separate .gitconfig mount as the file is already accessible through the main repository mount at /github.com/vmware-tanzu/velero. Git automatically finds the configuration file in the working directory. This approach is simpler, more robust, and avoids any path issues. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
1 parent 7b8c543 commit d32f63a

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

.gitconfig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Git configuration for containerized builds
22
#
3-
# This file is mounted as ~/.gitconfig in the container by the 'shell'
4-
# target in the Makefile to fix VCS stamping errors in Podman environments.
3+
# This file is available in the container working directory through the main
4+
# repository mount to fix VCS stamping errors in Podman environments.
55
#
66
# When Docker/Podman mounts the repository, the mount point directory
77
# (/github.com/vmware-tanzu/velero) is owned by root:root but the files

Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,6 @@ shell: build-dirs build-env
213213
-v "$$(pwd)/.go/std/$(GOOS)/$(GOARCH):/usr/local/go/pkg/$(GOOS)_$(GOARCH)_static:delegated" \
214214
-v "$$(pwd)/.go/go-build:/.cache/go-build:delegated" \
215215
-v "$$(pwd)/.go/golangci-lint:/.cache/golangci-lint:delegated" \
216-
-v "$$(pwd)/.gitconfig:$$HOME/.gitconfig:ro" \
217216
-w /github.com/vmware-tanzu/velero \
218217
$(BUILDER_IMAGE) \
219218
/bin/sh $(CMD)

0 commit comments

Comments
 (0)