Skip to content

Commit d556efb

Browse files
pierluigilenociblackpiglet
authored andcommitted
fix: add clarifying comment for stderrthreshold defaults
Address review nit: clarify that flag.Set calls set programmatic defaults that can be overridden via command-line flags. Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@gmail.com>
1 parent c156774 commit d556efb

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

pkg/cmd/velero/velero.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,9 @@ operations can also be performed as 'velero backup get' and 'velero schedule cre
133133
// init and add the klog flags
134134
klog.InitFlags(flag.CommandLine)
135135
// Opt into fixed stderrthreshold behavior (kubernetes/klog#212).
136+
// These set the programmatic defaults; users can still override via
137+
// --stderrthreshold=<level> on the command line (flag parsing in
138+
// cmd.Execute() runs after this).
136139
_ = flag.Set("legacy_stderr_threshold_behavior", "false")
137140
_ = flag.Set("stderrthreshold", "INFO")
138141
c.PersistentFlags().AddGoFlagSet(flag.CommandLine)

0 commit comments

Comments
 (0)