Returned null if the requested controller does ont exist, as promised in the method docblock.

thirsch · thirsch · commit 9c652bf0a308 · 2019-03-30T10:43:48.000+01:00
diff --git a/lib/controller/sfController.class.php b/lib/controller/sfController.class.php
@@ -299,7 +299,10 @@ protected function getController($moduleName, $controllerName, $extension)
     $classSuffix = ucfirst(strtolower($extension));
     if (!isset($this->controllerClasses[$moduleName.'_'.$controllerName.'_'.$classSuffix]))
     {
-      $this->controllerExists($moduleName, $controllerName, $extension, true);
+      if (!$this->controllerExists($moduleName, $controllerName, $extension, true))
+      {
+        return null;
+      }
     }
 
     $class = $this->controllerClasses[$moduleName.'_'.$controllerName.'_'.$classSuffix];

Original file line number	Diff line number	Diff line change
`@@ -299,7 +299,10 @@ protected function getController($moduleName, $controllerName, $extension)`
`299`	`299`	`$classSuffix = ucfirst(strtolower($extension));`
`300`	`300`	`if (!isset($this->controllerClasses[$moduleName.'_'.$controllerName.'_'.$classSuffix]))`
`301`	`301`	`{`
`302`		`- $this->controllerExists($moduleName, $controllerName, $extension, true);`
	`302`	`+ if (!$this->controllerExists($moduleName, $controllerName, $extension, true))`
	`303`	`+ {`
	`304`	`+ return null;`
	`305`	`+ }`
`303`	`306`	`}`
`304`	`307`
`305`	`308`	`$class = $this->controllerClasses[$moduleName.'_'.$controllerName.'_'.$classSuffix];`