Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Retrieve the softDelete ProductOptionGroup #3363

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hooooooouzx
Copy link

@hooooooouzx hooooooouzx commented Feb 13, 2025

Description

Hey sir, I just updated one line, this PR is related to #3281, I can retrieve the ProductOptionGroup which had been soft deleted.

I use removeOptionGroupFromProduct to remove an optionGroup from a product,all the productVariants have been softDelete.

But after this remove,I can still useProductOptionGroup GraphQL API get the optionGroup which had been soft deleted .I checked the database and the column deletedAt has value.

Breaking changes

N/A

Screenshots

Database:

image

GraphQL:

image

Before Updating:

image

After Updating:

image

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Feb 13, 2025 3:18pm

Copy link
Contributor

github-actions bot commented Feb 13, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@hooooooouzx
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant