Remove onEvent action lambda argument

Author: mantono

lib/src/main/kotlin/io/nexure/fsm/StateMachine.kt

@@ -39,25 +39,3 @@ interface StateMachine<S : Any, E : Any> {
         fun <S : Any, E : Any> builder(): StateMachineBuilder.Uninitialized<S, E> = StateMachineBuilder()
     }
 }
-
-/**
- * Execute a transition from [state] to another state depending on [event].
- * Returns a [Transition] indicating if the transition was permitted and
- * successful or not by the state machine.
- *
- * It is recommended that the return value is checked for the desired outcome, if it is critical
- * that an event for example is accepted and not rejected.
- *
- * This extension method is just syntactic sugar for calling
- * ```kotlin
- * stateMachine.onEvent(currentState, event).onTransition { newState ->
- *     // Do something
- * }
- * ```
- */
-inline fun <S : Any, E : Any> StateMachine<S, E>.onEvent(
-    state: S,
-    event: E,
-    action: (state: S) -> Unit
-): Transition<S> = onEvent(state, event).onTransition { action(it) }
-

lib/src/test/kotlin/io/nexure/fsm/ExampleStateMachine.kt

@@ -36,7 +36,7 @@ fun callExampleStateMachine(fsm: StateMachine<PaymentState, PaymentEvent>) {
     assertEquals(Accepted(PaymentState.Pending), state1)
 
     // Transition from state PENDING into state AUTHORIZED
-    val state2 = fsm.onEvent(PaymentState.Pending, PaymentEvent.BankAuthorization) {
+    val state2 = fsm.onEvent(PaymentState.Pending, PaymentEvent.BankAuthorization).onTransition {
         // Invoke some optional action when payment was authorized
     }
     assertEquals(Accepted(PaymentState.Authorized), state2)

lib/src/test/kotlin/io/nexure/fsm/StateMachineTest.kt

@@ -63,8 +63,8 @@ class StateMachineTest {
             .connect('b', 'c', Event.E3)
             .build()
 
-        assertEquals(Accepted('b'), fsm.onEvent('a', Event.E2) { n += 2})
-        assertEquals(Accepted('c'), fsm.onEvent('b', Event.E3) { n += 3})
+        assertEquals(Accepted('b'), fsm.onEvent('a', Event.E2).onTransition { n += 2})
+        assertEquals(Accepted('c'), fsm.onEvent('b', Event.E3).onTransition { n += 3})
 
         assertEquals(5, n)
     }
@@ -140,7 +140,7 @@ class StateMachineTest {
             .connect(State.S1, State.S2, Event.E1)
             .build()
 
-        fsm.onEvent(State.S1, Event.E1){
+        fsm.onEvent(State.S1, Event.E1).onTransition {
             semaphore.tryAcquire(4)
         }
 
@@ -168,7 +168,7 @@ class StateMachineTest {
             .connect(State.S1, State.S2, Event.E1)
             .build()
 
-        fsm.onEvent(State.S1, Event.E1, ::toggle)
+        fsm.onEvent(State.S1, Event.E1).onTransition(::toggle)
         assertTrue(executed)
     }
 
@@ -184,7 +184,7 @@ class StateMachineTest {
             .connect(State.S1, State.S2, Event.E1)
             .build()
 
-        fsm.onEvent(State.S1, Event.E1) { toggle() }
+        fsm.onEvent(State.S1, Event.E1).onTransition { toggle() }
         assertTrue(executed)
     }
 
@@ -277,7 +277,7 @@ class StateMachineTest {
             .connect(State.S1, State.S2, Event.E1)
             .build()
 
-        fsm.onEvent(State.S1, Event.E1) { throw exception }
+        fsm.onEvent(State.S1, Event.E1).onTransition { throw exception }
     }
 }