refactor(comid): remove PSA and CCA specific types and cleanup

feat(profiles/psa): extract and consolidate PSA logic into profile package

Signed-off-by: Abhishek kumar <[email protected]>

Author: abhiraj-ku

comid/cbor.go

@@ -32,9 +32,6 @@ var (
 		560: TaggedBytes{},
 		561: TaggedCertPathThumbprint{},
 		564: TaggedRawIntRange{},
-		// PSA profile tags
-		601: TaggedPSARefValID{},
-		602: TaggedCCAPlatformConfigID(""),
 	}
 )
 

comid/ccaplatformconfigid.go

@@ -31,17 +31,6 @@ func NewClassUUID(uuid UUID) *Class {
 	return &Class{ClassID: classID}
 }
 
-// NewClassImplID instantiates a new Class object that identifies the specified PSA
-// Implementation ID
-func NewClassImplID(implID ImplID) *Class {
-	classID, err := NewImplIDClassID(implID)
-	if err != nil {
-		return nil
-	}
-
-	return &Class{ClassID: classID}
-}
-
 // NewClassOID instantiates a new Class object that identifies the OID
 func NewClassOID(oid string) *Class {
 	classID, err := NewOIDClassID(oid)

comid/ccaplatformconfigid_test.go

@@ -30,25 +30,6 @@ func TestClass_MarshalCBOR_UUID_full(t *testing.T) {
 	assert.Equal(t, expected, actual)
 }
 
-func TestClass_MarshalCBOR_ImplID_full(t *testing.T) {
-	tv := NewClassImplID(TestImplID).
-		SetVendor("EMCA Ltd").
-		SetModel("Rennurdaor").
-		SetLayer(2).
-		SetIndex(1)
-	require.NotNil(t, tv)
-
-	// {0: 560(h'61636D652D696D706C656D656E746174696F6E2D69642D303030303030303031'), 1: "EMCA Ltd", 2: "Rennurdaor", 3: 2, 4: 1}
-	expected := MustHexDecode(t, "a500d90230582061636d652d696d706c656d656e746174696f6e2d69642d3030303030303030310168454d4341204c7464026a52656e6e757264616f7203020401")
-
-	actual, err := tv.ToCBOR()
-
-	fmt.Printf("CBOR: %x\n", actual)
-
-	assert.Nil(t, err)
-	assert.Equal(t, expected, actual)
-}
-
 func TestClass_MarshalCBOR_OID_full(t *testing.T) {
 	tv := NewClassOID(TestOID).
 		SetVendor("EMCA Ltd").
@@ -233,3 +214,28 @@ func TestClass_UnmarshalJSON_full(t *testing.T) {
 	assert.NotNil(t, actual.Index)
 	assert.Equal(t, uint64(2), actual.GetIndex())
 }
+
+func TestClass_NewClassBytes(t *testing.T) {
+	// Valid bytes
+	c := NewClassBytes([]byte{0x01, 0x02, 0x03})
+	assert.NotNil(t, c)
+
+	// Invalid type returns nil
+	c = NewClassBytes(12345)
+	assert.Nil(t, c)
+}
+
+func TestClass_ToJSON(t *testing.T) {
+	// Valid class
+	c := NewClassUUID(TestUUID).SetVendor("ACME Ltd")
+	require.NotNil(t, c)
+
+	data, err := c.ToJSON()
+	assert.NoError(t, err)
+	assert.NotEmpty(t, data)
+
+	// Invalid/empty class
+	var empty Class
+	_, err = empty.ToJSON()
+	assert.Error(t, err)
+}