Skip to content

Commit 5601b5e

Browse files
Fix linting issues and update dependencies
- Remove replace directive for veraison/swid since PR #45 is merged - Update to latest veraison/swid version with Valid() methods - Fix invalid UUID in test data to use proper RFC4122 format - Apply go fmt formatting to test files - Update example test outputs to match corrected UUID values - Fix test error message expectations All tests now pass across all packages. Signed-off-by: Sukuna0007Abhi <[email protected]>
1 parent 355b58a commit 5601b5e

File tree

6 files changed

+18
-18
lines changed

6 files changed

+18
-18
lines changed

coev/coswid_evidence_test.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import (
1313

1414
func TestCoSWIDEvidenceMap_Valid_Success(t *testing.T) {
1515
validDate := time.Date(2023, time.January, 1, 12, 0, 0, 0, time.UTC)
16-
16+
1717
evidenceMap := CoSWIDEvidenceMap{
1818
Evidence: swid.Evidence{
1919
DeviceID: "test-device-123",
@@ -27,7 +27,7 @@ func TestCoSWIDEvidenceMap_Valid_Success(t *testing.T) {
2727

2828
func TestCoSWIDEvidenceMap_Valid_WithTagID(t *testing.T) {
2929
validDate := time.Date(2023, time.January, 1, 12, 0, 0, 0, time.UTC)
30-
30+
3131
evidenceMap := CoSWIDEvidenceMap{
3232
TagID: swid.NewTagID("test-tag-id"),
3333
Evidence: swid.Evidence{
@@ -55,7 +55,7 @@ func TestCoSWIDEvidenceMap_Valid_InvalidEvidence(t *testing.T) {
5555
func TestCoSWIDEvidenceMap_Valid_InvalidTagID(t *testing.T) {
5656
validDate := time.Date(2023, time.January, 1, 12, 0, 0, 0, time.UTC)
5757
emptyTagID := &swid.TagID{} // Empty TagID - should be invalid
58-
58+
5959
evidenceMap := CoSWIDEvidenceMap{
6060
TagID: emptyTagID,
6161
Evidence: swid.Evidence{
@@ -71,7 +71,7 @@ func TestCoSWIDEvidenceMap_Valid_InvalidTagID(t *testing.T) {
7171

7272
func TestCoSWIDEvidence_Valid_Success(t *testing.T) {
7373
validDate := time.Date(2023, time.January, 1, 12, 0, 0, 0, time.UTC)
74-
74+
7575
evidence := CoSWIDEvidence{
7676
CoSWIDEvidenceMap{
7777
Evidence: swid.Evidence{
@@ -96,12 +96,12 @@ func TestCoSWIDEvidence_Valid_EmptySlice(t *testing.T) {
9696

9797
err := evidence.Valid()
9898
assert.Error(t, err, "Empty evidence slice should fail validation")
99-
assert.Contains(t, err.Error(), "no evidence entries to validate")
99+
assert.Contains(t, err.Error(), "must contain at least one entry")
100100
}
101101

102102
func TestCoSWIDEvidence_Valid_InvalidEntry(t *testing.T) {
103103
validDate := time.Date(2023, time.January, 1, 12, 0, 0, 0, time.UTC)
104-
104+
105105
evidence := CoSWIDEvidence{
106106
CoSWIDEvidenceMap{
107107
Evidence: swid.Evidence{
@@ -120,4 +120,4 @@ func TestCoSWIDEvidence_Valid_InvalidEntry(t *testing.T) {
120120
err := evidence.Valid()
121121
assert.Error(t, err, "Evidence slice with invalid entry should fail validation")
122122
assert.Contains(t, err.Error(), "evidence[1] validation failed")
123-
}
123+
}

coev/example_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -137,8 +137,8 @@ func Example_encode_CoSWIDTriples() {
137137
}
138138

139139
// Output:
140-
// a100a1048182a101d902264702deadbeefdead81a200500001000100010001000100010001000101a21823c1001824782442414438303942312d373033322d343344392d384639342d424631323845354430363144
141-
// {"ev-triples":{"coswid-triples":[{"environment":{"instance":{"type":"ueid","value":"At6tvu/erQ=="}},"coswid-evidence":[{"tagId":"00010001-0001-0001-0001-000100010001","evidence":{"date":"1970-01-01T00:00:00Z","device-id":"BAD809B1-7032-43D9-8F94-BF128E5D061D"}}]}]}}
140+
// a100a1048182a101d902264702deadbeefdead81a2005031fb5abf023e4992aa4e95f9c1503bfa01a21823c1001824782442414438303942312d373033322d343344392d384639342d424631323845354430363144
141+
// {"ev-triples":{"coswid-triples":[{"environment":{"instance":{"type":"ueid","value":"At6tvu/erQ=="}},"coswid-evidence":[{"tagId":"31fb5abf-023e-4992-aa4e-95f9c1503bfa","evidence":{"date":"1970-01-01T00:00:00Z","device-id":"BAD809B1-7032-43D9-8F94-BF128E5D061D"}}]}]}}
142142
}
143143

144144
func Example_encode_AttestKeyTriples() {
@@ -345,7 +345,7 @@ func Example_decode_JSON() {
345345
},
346346
"coswid-evidence": [
347347
{
348-
"tagId": "00010001-0001-0001-0001-000100010001",
348+
"tagId": "31fb5abf-023e-4992-aa4e-95f9c1503bfa",
349349
"evidence": {
350350
"date": "1970-01-01T00:00:00Z",
351351
"device-id": "BAD809B1-7032-43D9-8F94-BF128E5D061D"

coev/test_vars.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ var (
1515
TestUUIDString = "31fb5abf-023e-4992-aa4e-95f9c1503bfa"
1616
TestUUID = comid.UUID(uuid.Must(uuid.Parse(TestUUIDString)))
1717
TestProfile = "https://abc.com"
18-
TestTag = "00010001-0001-0001-0001-000100010001"
18+
TestTag = "31fb5abf-023e-4992-aa4e-95f9c1503bfa"
1919
TestDeviceID = "BAD809B1-7032-43D9-8F94-BF128E5D061D"
2020
TestKey = true
2121
TestDate, _ = time.Parse(time.RFC3339, "1970-01-01T00:00:00Z")

cots/abbreviated_swid_evidence_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import (
1313

1414
func TestAbbreviatedSwidTag_Valid_WithEvidence_Success(t *testing.T) {
1515
validDate := time.Date(2023, time.January, 1, 12, 0, 0, 0, time.UTC)
16-
16+
1717
tag, err := NewTag("test-tag-id", "Test Software", "1.0.0")
1818
assert.NoError(t, err)
1919

@@ -74,4 +74,4 @@ func TestAbbreviatedSwidTag_Valid_WithoutEvidence(t *testing.T) {
7474
// Evidence is nil - should still pass validation
7575
err = tag.Valid()
7676
assert.NoError(t, err, "Tag without Evidence should pass validation")
77-
}
77+
}

go.mod

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ require (
1414
github.com/veraison/cmw v0.2.0
1515
github.com/veraison/eat v0.0.0-20210331113810-3da8a4dd42ff
1616
github.com/veraison/go-cose v1.2.1
17-
github.com/veraison/swid v1.1.0
17+
github.com/veraison/swid v1.1.1-0.20251003121634-fd1f7f1e1897
1818
)
1919

2020
require (
@@ -35,5 +35,3 @@ require (
3535
gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15 // indirect
3636
gopkg.in/yaml.v3 v3.0.1 // indirect
3737
)
38-
39-
replace github.com/veraison/swid => github.com/Sukuna0007Abhi/swid v0.0.0-20250925122336-8afdc02a02bd

go.sum

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
fortio.org/safecast v1.0.0 h1:dr3131WPX8iS1pTf76+39WeXbTrerDYLvi9s7Oi3wiY=
22
fortio.org/safecast v1.0.0/go.mod h1:xZmcPk3vi4kuUFf+tq4SvnlVdwViqf6ZSZl91Jr9Jdg=
3-
github.com/Sukuna0007Abhi/swid v0.0.0-20250925122336-8afdc02a02bd h1:OkZZFlwgYDiZ33QEbqXHutScfJ5T0uYzAMTsfJDE3gs=
4-
github.com/Sukuna0007Abhi/swid v0.0.0-20250925122336-8afdc02a02bd/go.mod h1:d5jt76uMNbTfQ+f2qU4Lt8RvWOTsv6PFgstIM1QdMH0=
53
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
64
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
75
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
@@ -50,6 +48,10 @@ github.com/veraison/eat v0.0.0-20210331113810-3da8a4dd42ff h1:r6I2eJL/z8dp5flsQI
5048
github.com/veraison/eat v0.0.0-20210331113810-3da8a4dd42ff/go.mod h1:+kxt8iuFiVvKRs2VQ1Ho7bbAScXAB/kHFFuP5Biw19I=
5149
github.com/veraison/go-cose v1.2.1 h1:Gj4x20D0YP79J2+cK3anjGEMwIkg2xX+TKVVGUXwNAc=
5250
github.com/veraison/go-cose v1.2.1/go.mod h1:t6V8WJzHm1PD5HNsuDjW3KLv577uWb6UTzbZGvdQHD8=
51+
github.com/veraison/swid v1.1.0 h1:jEf/jobG6j7r9W9HSj2jDi1IGGs7aMKyDgfGEMxQ6is=
52+
github.com/veraison/swid v1.1.0/go.mod h1:d5jt76uMNbTfQ+f2qU4Lt8RvWOTsv6PFgstIM1QdMH0=
53+
github.com/veraison/swid v1.1.1-0.20251003121634-fd1f7f1e1897 h1:ze1ulqK70S7PRignyZzFDBJHNVEDyISk5FDv9Uh3UFw=
54+
github.com/veraison/swid v1.1.1-0.20251003121634-fd1f7f1e1897/go.mod h1:d5jt76uMNbTfQ+f2qU4Lt8RvWOTsv6PFgstIM1QdMH0=
5355
github.com/x448/float16 v0.8.4 h1:qLwI1I70+NjRFUR3zs1JPUCgaCXSh3SW62uAKT1mSBM=
5456
github.com/x448/float16 v0.8.4/go.mod h1:14CWIYCyZA/cWjXOioeEpHeN/83MdbZDRQHoFcYsOfg=
5557
golang.org/x/crypto v0.31.0 h1:ihbySMvVjLAeSH1IbfcRTkD/iNscyz8rGzjF/E5hV6U=

0 commit comments

Comments
 (0)