Yogesh's review comments

Signed-off-by: Thomas Fossati <[email protected]>

Author: thomas-fossati

coserv/cmd/coserv-service/Makefile

@@ -1,4 +1,4 @@
-# Copyright 2023 Contributors to the Veraison project.
+# Copyright 2025 Contributors to the Veraison project.
 # SPDX-License-Identifier: Apache-2.0
 
 .DEFAULT_GOAL := all

coserv/endorsementdistributor/Makefile

@@ -1,4 +1,4 @@
-# Copyright 2023 Contributors to the Veraison project.
+# Copyright 2025 Contributors to the Veraison project.
 # SPDX-License-Identifier: Apache-2.0
 
 .DEFAULT_GOAL := test

coserv/endorsementdistributor/iendorsementdistributor.go

@@ -5,17 +5,19 @@ package endorsementdistributor
 
 import "github.com/veraison/services/proto"
 
+// IEndorsementDistributor provides the bridge between the coserv REST API
+// handler and VTS gRPC service endpoints relevant to endorsement distribution.
 type IEndorsementDistributor interface {
 	// SupportedMediaTypes returns a list of supported media types
 	SupportedMediaTypes() ([]string, error)
 
 	// GetEndorsements retrieves endorsements matching the given query
-	// for the given tenantID, formatted as specified by resultMediaType
+	// for the given tenantID, formatted as specified by mediaType
 	// (which must be one of the media types returned by SupportedMediaTypes())
 	//
-	// If no endorsement can be found matching the query, an empty result set
+	// If no endorsements can be found matching the query, an empty result set
 	// is returned with no error.
-	GetEndorsements(tenantID string, query string, resultMediaType string) ([]byte, error)
+	GetEndorsements(tenantID string, query string, mediaType string) ([]byte, error)
 
 	// GetPublicKey returns the public key used to sign CoSERV responses
 	// (if any). If no signing is performed, nil is returned.

proto/endorsement_query.proto

@@ -12,11 +12,12 @@ option go_package = "github.com/veraison/services/proto";
 message EndorsementQueryIn {
   // media type (including profile)
   string media_type = 1;
-  // base64url-encoded CoSERV
+  // base64url-encoded CoSERV query
   string query = 2;
 }
 
 message EndorsementQueryOut {
   Status status = 1;
+  // CBOR-encoded CoSERV result set
   bytes result_set = 2;
 }

scheme/amd-kds-coserv/coserv_handler.go

@@ -129,7 +129,7 @@ func (s CoservProxyHandler) GetEndorsements(tenantID string, query string) ([]by
 	// Begin with an empty result set
 	coservResult := *coserv.NewResultSet()
 
-	// Loop over all of the class environments in the query, and call the AMD KDS cloud service for each one.
+	// Loop over all of the instance environments in the query, and call the AMD KDS cloud service for each one.
 	for _, i := range *q.Query.EnvironmentSelector.Instances {
 		err := s.addTrustAnchorForInstance(&i, &coservResult)
 		if err != nil {

scheme/nvidia-coserv/coserv_handler.go

@@ -82,15 +82,15 @@ func callRimService(rimid *string) (*RimServiceResponse, error) {
 
 func (s CoservProxyHandler) addReferenceValuesForClass(query *coserv.Query, c *coserv.StatefulClass, results *coserv.ResultSet) error {
 	if *c.Class.Vendor != "NVIDIA" {
-		return fmt.Errorf("vendors other than NVIDIA not supported by this proxy plug-in")
+		return errors.New("vendors other than NVIDIA not supported by this proxy plug-in")
 	}
 
 	if c.Measurements != nil {
-		return fmt.Errorf("NVIDIA CoSERV proxy plug-in does not expect stateful class environments")
+		return errors.New("NVIDIA CoSERV proxy plug-in does not expect stateful class environments")
 	}
 
 	if c.Class.Model == nil {
-		return fmt.Errorf("no Model field supplied in NVIDIA class environment")
+		return errors.New("no Model field supplied in NVIDIA class environment")
 	}
 
 	rimid := c.Class.Model

scheme/nvidia-coserv/plugin/Makefile

@@ -1,3 +1,5 @@
+# Copyright 2025 Contributors to the Veraison project.
+# SPDX-License-Identifier: Apache-2.0
 
 ifndef COMBINED_PLUGINS
   SUBDIR += coserv-handler

scheme/parsec-cca/endorsement_handler.go

@@ -52,5 +52,5 @@ func (o EndorsementHandler) Decode(data []byte, mediaType string, caCertPool []b
 }
 
 func (o EndorsementHandler) CoservRepackage(coservQuery string, resultSet []string) ([]byte, error) {
-	return nil, errors.New("TODO")
+	return nil, errors.New("Parsec CCA CoservRepackage not implemented")
 }

scheme/parsec-tpm/endorsement_handler.go

@@ -53,5 +53,5 @@ func (o EndorsementHandler) Decode(data []byte, mediaType string, caCertPool []b
 }
 
 func (o EndorsementHandler) CoservRepackage(coservQuery string, resultSet []string) ([]byte, error) {
-	return nil, errors.New("TODO")
+	return nil, errors.New("Parsec TPM CoservRepackage not implemented")
 }

scheme/psa-iot/endorsement_handler.go

@@ -53,5 +53,5 @@ func (o EndorsementHandler) Decode(data []byte, mediaType string, caCertPool []b
 }
 
 func (o EndorsementHandler) CoservRepackage(coservQuery string, resultSet []string) ([]byte, error) {
-	return nil, errors.New("TODO")
+	return nil, errors.New("PSA-IoT CoservRepackage not implemented")
 }