unskip

Author: cramforce

PROJECT.md

@@ -260,14 +260,14 @@ xargs — build argument lists
   - But only read files from disk once the user actually wants to read them
 - Make this a new directory
 
-## All before this is done
-
-Woohoo
-
 ## Implementation phase 19
 
 Find documentation for all bash commannds and builtins, grammar, functionality, semantics, etc. ideally in markdown or text or similar form and copy it into /tmp/official-bash-docs/$sourceDomain
 
 ## Implementation phase 20
 
 - Implement which and proper PATH to resolve commands
+
+## All before this is done
+
+Woohoo

package.json

@@ -64,5 +64,6 @@
     "minimatch": "^10.1.1",
     "sprintf-js": "^1.1.3",
     "turndown": "^7.2.2"
-  }
+  },
+  "packageManager": "pnpm@8.15.9+sha512.499434c9d8fdd1a2794ebf4552b3b25c0a633abcee5bb15e7b5de90f32f47b513aca98cd5cfd001c31f0db454bc3804edccd578501e4ca293a6816166bbd9f81"
 }

src/commands/which/which.ts

@@ -33,8 +33,6 @@ export const whichCommand: Command = {
         showAll = true;
         silent = true;
       } else if (arg.startsWith("-") && arg !== "-") {
-        // Unknown option - ignore like real which
-        continue;
       } else {
         names.push(arg);
       }

src/spec-tests/KNOWN_LIMITATIONS.md

@@ -24,7 +24,7 @@ The `shopt -s globskipdots` option is not implemented.
 
 ## Builtins
 
-### read options (39 tests)
+### read options (24 tests)
 Advanced `read` options are not implemented:
 - `-n N` / `-N N` - read N characters
 - `-d delim` - custom delimiter
@@ -45,9 +45,6 @@ The `hash` builtin for managing the command hash table is not implemented.
 ### history (29 tests)
 The `history` builtin and history expansion are not implemented.
 
-### which (31 tests)
-The `which` command is not implemented (use `command -v` instead).
-
 ## Variables
 
 ### PIPESTATUS (11 tests)
@@ -72,10 +69,11 @@ Automatic file descriptor allocation with `{fd}>file` syntax is not implemented.
 ### Close/move syntax (8 tests)
 File descriptor close (`>&-`, `<&-`) and move (`>&N-`) syntax is not implemented.
 
-### Advanced redirections (9 tests)
+### Advanced redirections (10 tests)
 - `exec N<file` - opening specific file descriptors
 - `N<&M` - duplicating file descriptors
 - Read-write mode `<>` (3 tests)
+- Stderr output inside command block with stdout redirect (1 test)
 
 ### FD propagation (1 test)
 File descriptor inheritance across statements is not fully implemented.
@@ -91,8 +89,11 @@ Symlink operations including:
 ### File time comparison (3 tests)
 `-ot` (older than), `-nt` (newer than), `-ef` (same file) test operators are not implemented.
 
-### Permission denied execution (2 tests)
-Execution permission checking for scripts is not fully implemented.
+### Permission denied execution (3 tests)
+Execution permission checking for scripts is not fully implemented. Returns exit code 127 instead of 126.
+
+### Ambiguous redirect (1 test)
+Redirect to `"$@"` with multiple arguments should produce "ambiguous redirect" error.
 
 ## Arithmetic
 
@@ -115,7 +116,7 @@ Comments inside `$((...))` are not supported.
 
 ## Parameter Expansion
 
-### Right brace in default value (75 tests)
+### Right brace in default value (54 tests)
 Complex parameter expansions with `}` in default values like `${x:-a}b}` have parsing limitations.
 
 ### ${@:0:N} slice (5 tests)
@@ -146,7 +147,7 @@ Complex escaped braces in expansion are not handled.
 
 ## Control Flow
 
-### errexit in compound commands (21 tests)
+### errexit in compound commands (9 tests)
 `set -e` (errexit) doesn't interact correctly with:
 - Brace groups `{ }`
 - Pipelines
@@ -206,9 +207,12 @@ The `%(format)T` strftime format is not implemented.
 
 ## Parsing
 
-### Parse error detection (16 tests)
+### Parse error detection (11 tests)
 Some parse error messages and detection differ from bash.
 
+### Nested array literal (1 test)
+`a=( inside=() )` should be a parse error but is not detected.
+
 ### Newlines in compound lists (1 test)
 Newline handling in some compound command contexts.
 

src/spec-tests/cases/arith.test.sh

@@ -97,7 +97,6 @@ should not get here
 ## N-I bash/mksh/zsh status: 0
 
 #### Integer constant parsing
-## SKIP: Comments in arithmetic expansion not implemented
 echo $(( 0x12A ))
 echo $(( 0x0A ))
 echo $(( 0777 ))
@@ -348,14 +347,12 @@ echo $((array[1] + array[2]*3))
 ## N-I dash stdout-json: ""
 
 #### Constants in base 36
-## SKIP: Comments in arithmetic expansion not implemented
 echo $((36#a))-$((36#z))
 ## stdout: 10-35
 ## N-I dash stdout-json: ""
 ## N-I dash status: 2
 
 #### Constants in bases 2 to 64
-## SKIP: which command not implemented
 # This is a truly bizarre syntax.  Oh it comes from zsh... which allows 36.
 echo $((64#a))-$((64#z)), $((64#A))-$((64#Z)), $((64#@)), $(( 64#_ ))
 ## stdout: 10-35, 36-61, 62, 63
@@ -365,14 +362,12 @@ echo $((64#a))-$((64#z)), $((64#A))-$((64#Z)), $((64#@)), $(( 64#_ ))
 ## N-I mksh/zsh status: 1
 
 #### Multiple digit constants with base N
-## SKIP: Comments in arithmetic expansion not implemented
 echo $((10#0123)), $((16#1b))
 ## stdout: 123, 27
 ## N-I dash stdout-json: ""
 ## N-I dash status: 2
 
 #### Dynamic base constants
-## SKIP: Comments in arithmetic expansion not implemented
 base=16
 echo $(( ${base}#a ))
 ## stdout: 10
@@ -459,7 +454,6 @@ max positive = 2147483647
 ## END
 
 #### More 64-bit ops
-## SKIP: 64-bit integer edge cases not implemented
 case $SH in dash) exit ;; esac
 
 #shopt -s strict_arith
@@ -572,7 +566,6 @@ echo $(( 3 ** 2 ))
 ## N-I mksh status: 1
 
 #### Exponentiation operator has buggy precedence
-## SKIP: which command not implemented
 # NOTE: All shells agree on this, but R and Python give -9, which is more
 # mathematically correct.
 echo $(( -3 ** 2 ))
@@ -629,7 +622,6 @@ echo $((array + 5))
 ## N-I mksh/zsh stdout-json: ""
 
 #### Add integer to associative array (a[0] decay)
-## SKIP: Associative array value coercion in arithmetic not implemented
 typeset -A assoc
 assoc[0]=42
 echo $((assoc + 5))
@@ -691,7 +683,6 @@ declared
 ## N-I dash stdout-json: ""
 
 #### comma operator
-## SKIP: which command not implemented
 a=(4 5 6)
 
 # zsh and osh can't evaluate the array like that

src/spec-tests/cases/array.test.sh

@@ -76,14 +76,12 @@ argv.py "${a[3]}"
 ## stdout: ['']
 
 #### Negative index
-## SKIP: Right brace in parameter default value not implemented
 a=(1 '2 3')
 argv.py "${a[-1]}" "${a[-2]}" "${a[-5]}"  # last one out of bounds
 ## stdout: ['2 3', '1', '']
 ## N-I mksh stdout: ['', '', '']
 
 #### Negative index and sparse array
-## SKIP: Right brace in parameter default value not implemented
 a=(0 1 2 3 4)
 unset a[1]
 unset a[4]
@@ -121,7 +119,6 @@ echo ${a[@]}
 ## END
 
 #### Negative index and sparse array
-## SKIP: Right brace in parameter default value not implemented
 a=(0 1)
 unset 'a[-1]'  # remove last element
 a+=(2 3)
@@ -854,7 +851,6 @@ bash: line 2: a[-1]: bad array subscript
 
 
 #### Regression: Negative index in [[ -v a[index] ]]
-## SKIP: Array negative index error messages with line numbers not implemented
 a[0]=x
 a[5]=y
 a[10]=z
@@ -942,7 +938,6 @@ bash: line 4: unset: [-2]: bad array subscript
 
 
 #### Regression: Out-of-bound negative offset for ${a[@]:offset}
-## SKIP: Right brace in parameter default value not implemented
 case $SH in mksh) exit ;; esac
 
 a=(1 2 3 4)

src/spec-tests/cases/assign.test.sh

@@ -267,7 +267,6 @@ eggs
 
 
 #### Modify a temporary binding
-## SKIP: Temp binding edge cases not implemented
 # (regression for bug found by Michael Greenberg)
 f() {
   echo "x before = $x"
@@ -375,7 +374,6 @@ x=global
 ## END
 
 #### Using ${x-default} after unsetting local shadowing a global
-## SKIP: Right brace in parameter default value not implemented
 f() {
   echo "x=$x"
   local x='local'
@@ -635,7 +633,6 @@ STDERR
 ## END
 
 #### redirect after declare -p
-## SKIP: which command not implemented
 case $SH in *dash) exit 99 ;; esac  # stderr unpredictable
 
 foo=bar

src/spec-tests/cases/brace-expansion.test.sh

@@ -50,7 +50,6 @@ echo -{\X"b",'cd'}-
 ## stdout: -Xb- -cd-
 
 #### expansion with simple var
-## SKIP: Brace expansion with variables order not implemented
 a=A
 echo -{$a,b}-
 ## stdout: -A- -b-

src/spec-tests/cases/builtin-bracket.test.sh

@@ -214,7 +214,6 @@ true
 ## END
 
 #### operator/operand ambiguity with ]
-## SKIP: which command not implemented
 # bash parses this as '-z' AND ']', which is true.  It's a syntax error in
 # dash/mksh.
 [ -z -a ] ]
@@ -530,7 +529,6 @@ status=2
 ## END
 
 #### -nt -ot
-## SKIP: File time/inode comparison (-ot, -nt, -ef) not implemented
 [ present -nt absent ] || exit 1
 [ absent -ot present ] || exit 2
 ## status: 1
@@ -557,7 +555,6 @@ different
 ## END
 
 #### Overflow error
-## SKIP: 64-bit integer edge cases not implemented
 test -t 12345678910
 echo status=$?
 ## STDOUT:

src/spec-tests/cases/builtin-cd.test.sh

@@ -239,7 +239,6 @@ target
 ## stderr-json: ""
 
 #### Test the current directory after 'cd ..' involving symlinks
-## SKIP: Symbolic links (ln -s) not implemented
 dir=$TMP/symlinktest
 mkdir -p $dir
 cd $dir